Patch Detail
Show a patch.
GET /api/1.1/patches/25918/?format=api
{ "id": 25918, "url": "https://patchwork.libcamera.org/api/1.1/patches/25918/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25918/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260121173737.376113-12-kieran.bingham@ideasonboard.com>", "date": "2026-01-21T17:37:30", "name": "[v6,11/16] ipa: mali-c55: Reduce AWB calculations to float precision", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "dad72009d7a127545c0a6b7ff4f2c8dab5dcac4f", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25918/mbox/", "series": [ { "id": 5730, "url": "https://patchwork.libcamera.org/api/1.1/series/5730/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5730", "date": "2026-01-21T17:37:19", "name": "libipa: Introduce a Quantized type", "version": 6, "mbox": "https://patchwork.libcamera.org/series/5730/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25918/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25918/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 84A51C32E7\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 21 Jan 2026 17:38:00 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E2A5661FF5;\n\tWed, 21 Jan 2026 18:37:58 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CAF9B61FCA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 21 Jan 2026 18:37:44 +0100 (CET)", "from Monstersaurus.hippo-penny.ts.net\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D0DA821D0;\n\tWed, 21 Jan 2026 18:37:12 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OMD/CzJy\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1769017032;\n\tbh=jUXrNpD5O+E67bCsFbHO1Y9uWRmV5hk6P4zDQcH5uHo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=OMD/CzJyEQjcGss9KpFk/EXJOpAHsP9lE9UztzQBOgHPD3RufFqnC6Iyxt3qZr8Uk\n\tbufkxcdmrt5ZMWOto9OPXF9ZvR5PhpIf6ZO8B7+7BKa1vvnM5GcedN6P3Vh0Qvfdj3\n\tFzm80h5Ng3hvqzGWGI4NmQwj56nD49idz5ApLzlI=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Cc": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v6 11/16] ipa: mali-c55: Reduce AWB calculations to float\n\tprecision", "Date": "Wed, 21 Jan 2026 17:37:30 +0000", "Message-ID": "<20260121173737.376113-12-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260121173737.376113-1-kieran.bingham@ideasonboard.com>", "References": "<20260121173737.376113-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The AWB calculations are determined using double precision, and then\nwill be soon stored in a quantized float.\n\nUse float types for the intermediate types after the sums have been\nconverted to an average to remove static cast assignments.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n---\nv5:\n - New in v5\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/mali-c55/algorithms/awb.cpp | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/ipa/mali-c55/algorithms/awb.cpp b/src/ipa/mali-c55/algorithms/awb.cpp\nindex 964e810882a9..b179dd7f0c1c 100644\n--- a/src/ipa/mali-c55/algorithms/awb.cpp\n+++ b/src/ipa/mali-c55/algorithms/awb.cpp\n@@ -159,7 +159,7 @@ void Awb::process(IPAContext &context, const uint32_t frame,\n \t * Sometimes the first frame's statistics have no valid pixels, in which\n \t * case we'll just assume a grey world until they say otherwise.\n \t */\n-\tdouble rgAvg, bgAvg;\n+\tfloat rgAvg, bgAvg;\n \tif (!counted_zones) {\n \t\trgAvg = 1.0;\n \t\tbgAvg = 1.0;\n@@ -174,15 +174,15 @@ void Awb::process(IPAContext &context, const uint32_t frame,\n \t * figure by the gains that were applied when the statistics for this\n \t * frame were generated.\n \t */\n-\tdouble rRatio = rgAvg / frameContext.awb.rGain;\n-\tdouble bRatio = bgAvg / frameContext.awb.bGain;\n+\tfloat rRatio = rgAvg / frameContext.awb.rGain;\n+\tfloat bRatio = bgAvg / frameContext.awb.bGain;\n \n \t/*\n \t * And then we can simply invert the ratio to find the gain we should\n \t * apply.\n \t */\n-\tdouble rGain = 1 / rRatio;\n-\tdouble bGain = 1 / bRatio;\n+\tfloat rGain = 1 / rRatio;\n+\tfloat bGain = 1 / bRatio;\n \n \t/*\n \t * Running at full speed, this algorithm results in oscillations in the\n@@ -190,7 +190,7 @@ void Awb::process(IPAContext &context, const uint32_t frame,\n \t * changes in gain, unless we're in the startup phase in which case we\n \t * want to fix the miscolouring as quickly as possible.\n \t */\n-\tdouble speed = frame < kNumStartupFrames ? 1.0 : 0.2;\n+\tfloat speed = frame < kNumStartupFrames ? 1.0 : 0.2;\n \trGain = speed * rGain + context.activeState.awb.rGain * (1.0 - speed);\n \tbGain = speed * bGain + context.activeState.awb.bGain * (1.0 - speed);\n \n", "prefixes": [ "v6", "11/16" ] }