Patch Detail
Show a patch.
GET /api/1.1/patches/25866/?format=api
{ "id": 25866, "url": "https://patchwork.libcamera.org/api/1.1/patches/25866/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25866/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260120-sklug-lsc-resampling-v2-dev-v4-11-2411c4be6d6d@ideasonboard.com>", "date": "2026-01-20T08:45:53", "name": "[v4,11/14] ipa: rkisp1: lsc: Pass sampling positions into samplePolynomial", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "3dd4192690006676d19cbb11458c690ef29120ca", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25866/mbox/", "series": [ { "id": 5720, "url": "https://patchwork.libcamera.org/api/1.1/series/5720/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5720", "date": "2026-01-20T08:45:42", "name": "Add resampling support for polynomial LSC data", "version": 4, "mbox": "https://patchwork.libcamera.org/series/5720/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25866/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25866/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 792C2BDCBF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 20 Jan 2026 08:46:26 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 259CF61FDE;\n\tTue, 20 Jan 2026 09:46:26 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B18DE61FDC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Jan 2026 09:46:24 +0100 (CET)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:7f76:a386:d798:7544])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id B747119D3; \n\tTue, 20 Jan 2026 09:45:53 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gVZwQy4w\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768898753;\n\tbh=WMnOyu5+JCM7fibqidVGqhdcsyz4EZDEPP4/vrCqOhM=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=gVZwQy4whLvhQvT9qKyvCKRpRPWzoPfXeTDoQ0ewm+MmoHyGO8EAzQw2QBQIuSrjq\n\tmHuohFHF3tDEtKj11xyDvceGEejWfxkUXk2BR//TwW/tlcE3qhRtHyLx5yZpHw6ZEi\n\tSPX3s5nv0U6Pbz7yNAeJ+gcoWv0Ivio/T92WexaQ=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "Date": "Tue, 20 Jan 2026 09:45:53 +0100", "Subject": "[PATCH v4 11/14] ipa: rkisp1: lsc: Pass sampling positions into\n\tsamplePolynomial", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260120-sklug-lsc-resampling-v2-dev-v4-11-2411c4be6d6d@ideasonboard.com>", "References": "<20260120-sklug-lsc-resampling-v2-dev-v4-0-2411c4be6d6d@ideasonboard.com>", "In-Reply-To": "<20260120-sklug-lsc-resampling-v2-dev-v4-0-2411c4be6d6d@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>, =?utf-8?q?Barnab=C3=A1s_P?=\n\t=?utf-8?b?xZFjemU=?= <barnabas.pocze@ideasonboard.com>, Laurent Pinchart\n\t<laurent.pinchart@ideasonboard.com>", "X-Mailer": "b4 0.14.2", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "There is no need to recalculate the sampling positions over and over.\nPass them as parameter into the sampling function. The vectors are still\nkept inside the loop as this is also a preparatory change for the\nupcoming refactoring.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n---\n\nChanges in v2:\n- Small fixes from review:\n - Replaced move construction by move assignments\n - Replaced some vectors by Spans\n- Collected tags\n---\n src/ipa/rkisp1/algorithms/lsc.cpp | 37 ++++++++++++++++++-------------------\n 1 file changed, 18 insertions(+), 19 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\nindex b7c2ebe43dc0de6716a90b50153cc4dee5d717af..4420fe72ab99398af6ec37dd03255e650e3e8447 100644\n--- a/src/ipa/rkisp1/algorithms/lsc.cpp\n+++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n@@ -91,7 +91,9 @@ public:\n \n private:\n \tstd::vector<double> sizesListToPositions(const std::vector<double> &sizes);\n-\tstd::vector<uint16_t> samplePolynomial(const LscPolynomial &poly);\n+\tstd::vector<uint16_t> samplePolynomial(const LscPolynomial &poly,\n+\t\t\t\t\t Span<const double> xPositions,\n+\t\t\t\t\t Span<const double> yPositions);\n \n \tSize sensorSize_;\n \tRectangle cropRectangle_;\n@@ -131,10 +133,13 @@ int LscPolynomialLoader::parseLscData(const YamlObject &yamlSets,\n \t\tpgr->setReferenceImageSize(sensorSize_);\n \t\tpgb->setReferenceImageSize(sensorSize_);\n \t\tpb->setReferenceImageSize(sensorSize_);\n-\t\tset.r = samplePolynomial(*pr);\n-\t\tset.gr = samplePolynomial(*pgr);\n-\t\tset.gb = samplePolynomial(*pgb);\n-\t\tset.b = samplePolynomial(*pb);\n+\n+\t\tstd::vector<double> xPos = sizesListToPositions(xSizes_);\n+\t\tstd::vector<double> yPos = sizesListToPositions(ySizes_);\n+\t\tset.r = samplePolynomial(*pr, xPos, yPos);\n+\t\tset.gr = samplePolynomial(*pgr, xPos, yPos);\n+\t\tset.gb = samplePolynomial(*pgb, xPos, yPos);\n+\t\tset.b = samplePolynomial(*pb, xPos, yPos);\n \t}\n \n \tif (lscData.empty()) {\n@@ -171,10 +176,10 @@ std::vector<double> LscPolynomialLoader::sizesListToPositions(const std::vector<\n \treturn positions;\n }\n \n-std::vector<uint16_t> LscPolynomialLoader::samplePolynomial(const LscPolynomial &poly)\n+std::vector<uint16_t> LscPolynomialLoader::samplePolynomial(const LscPolynomial &poly,\n+\t\t\t\t\t\t\t Span<const double> xPositions,\n+\t\t\t\t\t\t\t Span<const double> yPositions)\n {\n-\tconstexpr int k = RKISP1_CIF_ISP_LSC_SAMPLES_MAX;\n-\n \tdouble m = poly.getM();\n \tdouble x0 = cropRectangle_.x / m;\n \tdouble y0 = cropRectangle_.y / m;\n@@ -182,18 +187,12 @@ std::vector<uint16_t> LscPolynomialLoader::samplePolynomial(const LscPolynomial\n \tdouble h = cropRectangle_.height / m;\n \tstd::vector<uint16_t> samples;\n \n-\tASSERT(xSizes_.size() * 2 + 1 == k);\n-\tASSERT(ySizes_.size() * 2 + 1 == k);\n-\n-\tsamples.reserve(k * k);\n-\n-\tstd::vector<double> xPos(sizesListToPositions(xSizes_));\n-\tstd::vector<double> yPos(sizesListToPositions(ySizes_));\n+\tsamples.reserve(xPositions.size() * yPositions.size());\n \n-\tfor (int y = 0; y < k; y++) {\n-\t\tfor (int x = 0; x < k; x++) {\n-\t\t\tdouble xp = x0 + xPos[x] * w;\n-\t\t\tdouble yp = y0 + yPos[y] * h;\n+\tfor (double y : yPositions) {\n+\t\tfor (double x : xPositions) {\n+\t\t\tdouble xp = x0 + x * w;\n+\t\t\tdouble yp = y0 + y * h;\n \t\t\t/*\n \t\t\t * The hardware uses 2.10 fixed point format and limits\n \t\t\t * the legal values to [1..3.999]. Scale and clamp the\n", "prefixes": [ "v4", "11/14" ] }