Patch Detail
Show a patch.
GET /api/1.1/patches/25860/?format=api
{ "id": 25860, "url": "https://patchwork.libcamera.org/api/1.1/patches/25860/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25860/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260120-sklug-lsc-resampling-v2-dev-v4-5-2411c4be6d6d@ideasonboard.com>", "date": "2026-01-20T08:45:47", "name": "[v4,05/14] ipa: rkisp1: lsc: Rename res to ret", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "c6138798ee3dd37481ae7118fc0d8d7d79808cb2", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25860/mbox/", "series": [ { "id": 5720, "url": "https://patchwork.libcamera.org/api/1.1/series/5720/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5720", "date": "2026-01-20T08:45:42", "name": "Add resampling support for polynomial LSC data", "version": 4, "mbox": "https://patchwork.libcamera.org/series/5720/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25860/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25860/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 04A0FBDCBF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 20 Jan 2026 08:46:12 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 79A4861FD3;\n\tTue, 20 Jan 2026 09:46:11 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4ADE661FD2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Jan 2026 09:46:08 +0100 (CET)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:7f76:a386:d798:7544])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 0EEED18D7; \n\tTue, 20 Jan 2026 09:45:37 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tefhS+U+\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768898737;\n\tbh=Q66L+qBP3d9HUh5DEB9HQOwvALS5AmnZ9rrQY4rui1k=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=tefhS+U+EelwFYw0Rop/WuNGUcjOQlZSiDrVHfTSlz0ROSl2k4FqaXHlIyxrxIcAR\n\tCjRlOjVqtOgi+3AsPO9xFQmNXmJdKc2QIhgrsN1mHcg60m8q4x5PXTnE3BW7QqclMw\n\tXiir8uuNysagLyeR/x9h/iIsfjXgs0tt/x5d29KI=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "Date": "Tue, 20 Jan 2026 09:45:47 +0100", "Subject": "[PATCH v4 05/14] ipa: rkisp1: lsc: Rename res to ret", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260120-sklug-lsc-resampling-v2-dev-v4-5-2411c4be6d6d@ideasonboard.com>", "References": "<20260120-sklug-lsc-resampling-v2-dev-v4-0-2411c4be6d6d@ideasonboard.com>", "In-Reply-To": "<20260120-sklug-lsc-resampling-v2-dev-v4-0-2411c4be6d6d@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>, =?utf-8?q?Barnab=C3=A1s_P?=\n\t=?utf-8?b?xZFjemU=?= <barnabas.pocze@ideasonboard.com>,\n\tRui Wang <rui.wang@ideasonboard.com>", "X-Mailer": "b4 0.14.2", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Rename res to ret as that is used in libcamera for return codes.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nReviewed-by: Rui Wang <rui.wang@ideasonboard.com>\n\n---\n\nChanges in v2:\n- Restored old variable order\n- Collected tags\n---\n src/ipa/rkisp1/algorithms/lsc.cpp | 13 +++++++------\n 1 file changed, 7 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\nindex bb58386ae646ad6089322ba63d2a9e89664884d2..68e262a2b057d12a9019a6a92c1b300272b04c4d 100644\n--- a/src/ipa/rkisp1/algorithms/lsc.cpp\n+++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n@@ -321,27 +321,28 @@ int LensShadingCorrection::init([[maybe_unused]] IPAContext &context,\n \t}\n \n \tstd::map<unsigned int, Components> lscData;\n-\tint res = 0;\n+\tint ret = 0;\n+\n \tstd::string type = tuningData[\"type\"].get<std::string>(\"table\");\n \tif (type == \"table\") {\n \t\tLOG(RkISP1Lsc, Debug) << \"Loading tabular LSC data.\";\n \t\tauto loader = LscTableLoader();\n-\t\tres = loader.parseLscData(yamlSets, lscData);\n+\t\tret = loader.parseLscData(yamlSets, lscData);\n \t} else if (type == \"polynomial\") {\n \t\tLOG(RkISP1Lsc, Debug) << \"Loading polynomial LSC data.\";\n \t\tauto loader = LscPolynomialLoader(context.sensorInfo.activeAreaSize,\n \t\t\t\t\t\t context.sensorInfo.analogCrop,\n \t\t\t\t\t\t xSize_,\n \t\t\t\t\t\t ySize_);\n-\t\tres = loader.parseLscData(yamlSets, lscData);\n+\t\tret = loader.parseLscData(yamlSets, lscData);\n \t} else {\n \t\tLOG(RkISP1Lsc, Error) << \"Unsupported LSC data type '\"\n \t\t\t\t << type << \"'\";\n-\t\tres = -EINVAL;\n+\t\tret = -EINVAL;\n \t}\n \n-\tif (res)\n-\t\treturn res;\n+\tif (ret)\n+\t\treturn ret;\n \n \tsets_.setData(std::move(lscData));\n \n", "prefixes": [ "v4", "05/14" ] }