Patch Detail
Show a patch.
GET /api/1.1/patches/25794/?format=api
{ "id": 25794, "url": "https://patchwork.libcamera.org/api/1.1/patches/25794/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25794/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260114-sklug-lsc-resampling-v2-dev-v3-14-80cd24f4dd61@ideasonboard.com>", "date": "2026-01-14T11:58:07", "name": "[v3,14/15] libcamera: control_ids: Introduce LensShadingCorrectionEnable", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "17049199c1778757d5c814b3cc556cc66ec82927", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25794/mbox/", "series": [ { "id": 5707, "url": "https://patchwork.libcamera.org/api/1.1/series/5707/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5707", "date": "2026-01-14T11:57:53", "name": "Add resampling support for polynomial LSC data", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5707/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25794/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25794/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E3F61C3226\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 14 Jan 2026 11:58:41 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9F26661FD2;\n\tWed, 14 Jan 2026 12:58:41 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B777A61FD0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 14 Jan 2026 12:58:40 +0100 (CET)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:b781:dff2:957:7831])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 136834BB;\n\tWed, 14 Jan 2026 12:58:14 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BrCoTl1K\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768391894;\n\tbh=l2OgRVSM0AY54TpUR6RuzVrXqx/vDN2aZdAVq0yhDzQ=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=BrCoTl1KiShlcxnG0cWFPh0v/V36zTz70hnCwQABb8RtusFVL/Pw0F5jzt5If9QBF\n\tUDmrQeyHt5fyEHtEec/np2PCDv82DweuNR1SyXLdasjr0eQEdPYEEjlDYXB2UTA3SV\n\t+t+g4TU8RriA7Di5ICht2/lp/krdqWSbLCbcAYN8=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "Date": "Wed, 14 Jan 2026 12:58:07 +0100", "Subject": "[PATCH v3 14/15] libcamera: control_ids: Introduce\n\tLensShadingCorrectionEnable", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20260114-sklug-lsc-resampling-v2-dev-v3-14-80cd24f4dd61@ideasonboard.com>", "References": "<20260114-sklug-lsc-resampling-v2-dev-v3-0-80cd24f4dd61@ideasonboard.com>", "In-Reply-To": "<20260114-sklug-lsc-resampling-v2-dev-v3-0-80cd24f4dd61@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>, \n\tJacopo Mondi <jacopo@jmondi.org>", "X-Mailer": "b4 0.14.2", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Introduce a control to enable and disable LSC and replace the\ndraft android control. Having a map as in andoid doesn't give a benefit\nas up to today no values apart from ON/OFF were ever implemented.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n\n---\n\nChanges in v2:\n- Renamed LensShadingEnable to LensShadingCorrectionEnable\n- Fixed android code to properly handle the boolean value\n- Added \"only if tuned\" info sentence to the control description\n---\n src/android/camera_capabilities.cpp | 11 ++++-------\n src/libcamera/control_ids_core.yaml | 9 +++++++++\n src/libcamera/control_ids_draft.yaml | 14 --------------\n 3 files changed, 13 insertions(+), 21 deletions(-)", "diff": "diff --git a/src/android/camera_capabilities.cpp b/src/android/camera_capabilities.cpp\nindex b161bc6b3ed68b7206e524762f8a941816812e45..9948868d3bd99a9cfb59a5d48a20ccc455a94964 100644\n--- a/src/android/camera_capabilities.cpp\n+++ b/src/android/camera_capabilities.cpp\n@@ -1223,13 +1223,10 @@ int CameraCapabilities::initializeStaticMetadata()\n \t{\n \t\tstd::vector<uint8_t> data;\n \t\tdata.reserve(2);\n-\t\tconst auto &infoMap = controlsInfo.find(&controls::draft::LensShadingMapMode);\n-\t\tif (infoMap != controlsInfo.end()) {\n-\t\t\tfor (const auto &value : infoMap->second.values())\n-\t\t\t\tdata.push_back(value.get<int32_t>());\n-\t\t} else {\n-\t\t\tdata.push_back(ANDROID_STATISTICS_LENS_SHADING_MAP_MODE_OFF);\n-\t\t}\n+\t\tdata.push_back(ANDROID_STATISTICS_LENS_SHADING_MAP_MODE_OFF);\n+\t\tconst auto &infoMap = controlsInfo.find(&controls::LensShadingCorrectionEnable);\n+\t\tif (infoMap != controlsInfo.end())\n+\t\t\tdata.push_back(ANDROID_STATISTICS_LENS_SHADING_MAP_MODE_ON);\n \t\tstaticMetadata_->addEntry(ANDROID_STATISTICS_INFO_AVAILABLE_LENS_SHADING_MAP_MODES,\n \t\t\t\t\t data);\n \t}\ndiff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\nindex 8e99bd84825f6060dbc323be3f4b0cd6283e0942..ced98e4625bfba9165be4f93d1fd2756881a2d1b 100644\n--- a/src/libcamera/control_ids_core.yaml\n+++ b/src/libcamera/control_ids_core.yaml\n@@ -1356,4 +1356,13 @@ controls:\n Enable or disable lens dewarping. This control is only available if lens\n dewarp parameters are configured in the tuning file.\n \n+ - LensShadingCorrectionEnable:\n+ type: bool\n+ direction: inout\n+ description: |\n+ Enable or disable the lens shading algorithm.\n+\n+ This control is only available when there are valid lens shading\n+ correction parameters available in the tuning file.\n+\n ...\ndiff --git a/src/libcamera/control_ids_draft.yaml b/src/libcamera/control_ids_draft.yaml\nindex 03309eeac34fa76eee4bb5d1c87d6467b890c9a7..14026de46ad6de92cfd978e5c68c9944ce9987fa 100644\n--- a/src/libcamera/control_ids_draft.yaml\n+++ b/src/libcamera/control_ids_draft.yaml\n@@ -110,20 +110,6 @@ controls:\n row and the start of exposure of the last row. Currently identical to\n ANDROID_SENSOR_ROLLING_SHUTTER_SKEW\n \n- - LensShadingMapMode:\n- type: int32_t\n- direction: inout\n- description: |\n- Control to report if the lens shading map is available. Currently\n- identical to ANDROID_STATISTICS_LENS_SHADING_MAP_MODE.\n- enum:\n- - name: LensShadingMapModeOff\n- value: 0\n- description: No lens shading map mode is available.\n- - name: LensShadingMapModeOn\n- value: 1\n- description: The lens shading map mode is available.\n-\n - PipelineDepth:\n type: int32_t\n direction: out\n", "prefixes": [ "v3", "14/15" ] }