Patch Detail
Show a patch.
GET /api/1.1/patches/25783/?format=api
{ "id": 25783, "url": "https://patchwork.libcamera.org/api/1.1/patches/25783/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25783/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260114-sklug-lsc-resampling-v2-dev-v3-3-80cd24f4dd61@ideasonboard.com>", "date": "2026-01-14T11:57:56", "name": "[v3,03/15] ipa: rkisp1: lsc: Replace assert with ASSERT", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "8094acb57bebdfcfd211f102066d2286aa26def8", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25783/mbox/", "series": [ { "id": 5707, "url": "https://patchwork.libcamera.org/api/1.1/series/5707/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5707", "date": "2026-01-14T11:57:53", "name": "Add resampling support for polynomial LSC data", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5707/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25783/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25783/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1E235C3226\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 14 Jan 2026 11:58:11 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CE51B61FC1;\n\tWed, 14 Jan 2026 12:58:10 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6AA0461FA3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 14 Jan 2026 12:58:09 +0100 (CET)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:b781:dff2:957:7831])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id BA78D6A8;\n\tWed, 14 Jan 2026 12:57:42 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"va106RFw\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768391862;\n\tbh=XclvvXKia3KXTQl/qKvBdoELOBtaOgq+NkY74Ldf5HU=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=va106RFweLHg3kQoCIzPWihQIzeu/EOf3+OsrbEob/Mk9adrRg3rRGQTJaYbTTiQl\n\tsEAAdsdDPcV2Ny94C8v6aw0/b81XM0s+KedK4SKoNsZPBTjvdQp9/RtIPyNeSqr/UC\n\tXs+YiRiGkdAH2mxsXsp/4O1dewowQTN8EGBl0n0o=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "Date": "Wed, 14 Jan 2026 12:57:56 +0100", "Subject": "[PATCH v3 03/15] ipa: rkisp1: lsc: Replace assert with ASSERT", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260114-sklug-lsc-resampling-v2-dev-v3-3-80cd24f4dd61@ideasonboard.com>", "References": "<20260114-sklug-lsc-resampling-v2-dev-v3-0-80cd24f4dd61@ideasonboard.com>", "In-Reply-To": "<20260114-sklug-lsc-resampling-v2-dev-v3-0-80cd24f4dd61@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>, =?utf-8?q?Barnab=C3=A1s_P?=\n\t=?utf-8?b?xZFjemU=?= <barnabas.pocze@ideasonboard.com>,\n\tRui Wang <rui.wang@ideasonboard.com>", "X-Mailer": "b4 0.14.2", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Replace assert() by ASSERT() and drop a set of unnecessary curly braces.\nThose were noticed in the former review but after the series was\napplied. Fix them now.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nReviewed-by: Rui Wang <rui.wang@ideasonboard.com>\n\n---\n\nChanges in v2:\n- Collected tags\n---\n src/ipa/rkisp1/algorithms/lsc.cpp | 9 ++++-----\n 1 file changed, 4 insertions(+), 5 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\nindex ab0ada4eed46bc3fdbce17377164a7fbfb321957..c581e6441853d18618284b51bfa25c25e1fc8083 100644\n--- a/src/ipa/rkisp1/algorithms/lsc.cpp\n+++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n@@ -33,11 +33,10 @@ template<typename T>\n void interpolateVector(const std::vector<T> &a, const std::vector<T> &b,\n \t\t std::vector<T> &dest, double lambda)\n {\n-\tassert(a.size() == b.size());\n+\tASSERT(a.size() == b.size());\n \tdest.resize(a.size());\n-\tfor (size_t i = 0; i < a.size(); i++) {\n+\tfor (size_t i = 0; i < a.size(); i++)\n \t\tdest[i] = a[i] * (1.0 - lambda) + b[i] * lambda;\n-\t}\n }\n \n template<>\n@@ -167,8 +166,8 @@ private:\n \t\tdouble h = cropRectangle_.height / m;\n \t\tstd::vector<uint16_t> res;\n \n-\t\tassert(xSizes_.size() * 2 + 1 == k);\n-\t\tassert(ySizes_.size() * 2 + 1 == k);\n+\t\tASSERT(xSizes_.size() * 2 + 1 == k);\n+\t\tASSERT(ySizes_.size() * 2 + 1 == k);\n \n \t\tres.reserve(k * k);\n \n", "prefixes": [ "v3", "03/15" ] }