Patch Detail
Show a patch.
GET /api/1.1/patches/25781/?format=api
{ "id": 25781, "url": "https://patchwork.libcamera.org/api/1.1/patches/25781/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25781/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260114-sklug-lsc-resampling-v2-dev-v3-1-80cd24f4dd61@ideasonboard.com>", "date": "2026-01-14T11:57:54", "name": "[v3,01/15] ipa: rkisp1: lsc: Drop unused member variable", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "39d85ad1e3b9c1d40cca1731917279650380e2c9", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25781/mbox/", "series": [ { "id": 5707, "url": "https://patchwork.libcamera.org/api/1.1/series/5707/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5707", "date": "2026-01-14T11:57:53", "name": "Add resampling support for polynomial LSC data", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5707/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25781/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25781/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BCFA8C3226\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 14 Jan 2026 11:58:05 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 67E2A61FB9;\n\tWed, 14 Jan 2026 12:58:05 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B3D3861FA3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 14 Jan 2026 12:58:03 +0100 (CET)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:b781:dff2:957:7831])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 064D64BB;\n\tWed, 14 Jan 2026 12:57:36 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Nt7CmJv3\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768391857;\n\tbh=OcEp1RGR9Yo43utM4YX0sN8zvzSy2va566Bm6G86NKo=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=Nt7CmJv3k21o26sF6q7w7MGAE88UHS0RJM0Wz/kyMzRTbY6TK+ayBXS/Zu3W8I+i7\n\twHZn05aAYlUBfES1znJK246UpTTXbItI0yAhH2pk4ggU1EBF8GHYwtL+/I35MgoSNV\n\tTzN0RxNXGVgyz2jKC4e/nmlw9x5qjobd52Q0S02c=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "Date": "Wed, 14 Jan 2026 12:57:54 +0100", "Subject": "[PATCH v3 01/15] ipa: rkisp1: lsc: Drop unused member variable", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260114-sklug-lsc-resampling-v2-dev-v3-1-80cd24f4dd61@ideasonboard.com>", "References": "<20260114-sklug-lsc-resampling-v2-dev-v3-0-80cd24f4dd61@ideasonboard.com>", "In-Reply-To": "<20260114-sklug-lsc-resampling-v2-dev-v3-0-80cd24f4dd61@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>, =?utf-8?q?Barnab=C3=A1s_P?=\n\t=?utf-8?b?xZFjemU=?= <barnabas.pocze@ideasonboard.com>,\n\tRui Wang <rui.wang@ideasonboard.com>", "X-Mailer": "b4 0.14.2", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The Components::ct member is not used anywhere. Drop it.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nReviewed-by: Rui Wang <rui.wang@ideasonboard.com>\n\n---\n\nChanges in v2:\n- Collected tags\n---\n src/ipa/rkisp1/algorithms/lsc.cpp | 2 --\n src/ipa/rkisp1/algorithms/lsc.h | 1 -\n 2 files changed, 3 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\nindex e7301bfec86393c4aad4e645800513d8c262e6f9..ab0ada4eed46bc3fdbce17377164a7fbfb321957 100644\n--- a/src/ipa/rkisp1/algorithms/lsc.cpp\n+++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n@@ -113,7 +113,6 @@ public:\n \t\t\t\treturn -EINVAL;\n \t\t\t}\n \n-\t\t\tset.ct = ct;\n \t\t\tpr->setReferenceImageSize(sensorSize_);\n \t\t\tpgr->setReferenceImageSize(sensorSize_);\n \t\t\tpgb->setReferenceImageSize(sensorSize_);\n@@ -221,7 +220,6 @@ public:\n \n \t\t\tLensShadingCorrection::Components &set = lscData[ct];\n \n-\t\t\tset.ct = ct;\n \t\t\tset.r = parseTable(yamlSet, \"r\");\n \t\t\tset.gr = parseTable(yamlSet, \"gr\");\n \t\t\tset.gb = parseTable(yamlSet, \"gb\");\ndiff --git a/src/ipa/rkisp1/algorithms/lsc.h b/src/ipa/rkisp1/algorithms/lsc.h\nindex 5a0824e36dd5b45660514ce295fc2f42fdc4fa30..0e3745d5589c2ea94f63efbbb0eb51670cbc2793 100644\n--- a/src/ipa/rkisp1/algorithms/lsc.h\n+++ b/src/ipa/rkisp1/algorithms/lsc.h\n@@ -30,7 +30,6 @@ public:\n \t\t RkISP1Params *params) override;\n \n \tstruct Components {\n-\t\tuint32_t ct;\n \t\tstd::vector<uint16_t> r;\n \t\tstd::vector<uint16_t> gr;\n \t\tstd::vector<uint16_t> gb;\n", "prefixes": [ "v3", "01/15" ] }