Patch Detail
Show a patch.
GET /api/1.1/patches/25776/?format=api
{ "id": 25776, "url": "https://patchwork.libcamera.org/api/1.1/patches/25776/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25776/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260114113016.25162-12-mzamazal@redhat.com>", "date": "2026-01-14T11:30:13", "name": "[v3,11/14] libcamera: ipa: simple: Use float type for adjustment controls", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "887257f85edae7a25843e9a6f7272e2c9b50b0ad", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/1.1/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25776/mbox/", "series": [ { "id": 5706, "url": "https://patchwork.libcamera.org/api/1.1/series/5706/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5706", "date": "2026-01-14T11:30:02", "name": "Simple pipeline IPA cleanup", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5706/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25776/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25776/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 333D3C3226\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 14 Jan 2026 11:31:07 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CA71861FDA;\n\tWed, 14 Jan 2026 12:31:06 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 85FA161FDC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 14 Jan 2026 12:31:05 +0100 (CET)", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-286-tp8vVzFjOzupsrlcDkUEhw-1;\n\tWed, 14 Jan 2026 06:31:01 -0500", "from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.93])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 7BC73180034A; Wed, 14 Jan 2026 11:31:00 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.32.217])\n\tby mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id D16C4180009E; Wed, 14 Jan 2026 11:30:58 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"TEGWzxCC\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1768390264;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=yQ/EME8k3Sd4zv5VogG4YMeC7fzR90geKLGDwhN8Wo0=;\n\tb=TEGWzxCCfELCYQznBmwMiYWymKym8KhKimU/9Fdfyr/pddoHCJnkOPGZXGFP/Vy6DkON4o\n\tAYoNBYq7D46ym7BpPO/XYsFgOywsmAB2Hu7J9xNkc55hXHaOZEyXGkGfWfmNifbiz0vFGd\n\toSvZuVXYuQFxbCRlyEbMsmIyRUzi3qs=", "X-MC-Unique": "tp8vVzFjOzupsrlcDkUEhw-1", "X-Mimecast-MFC-AGG-ID": "tp8vVzFjOzupsrlcDkUEhw_1768390260", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>, Kieran Bingham\n\t<kieran.bingham@ideasonboard.com>, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t<barnabas.pocze@ideasonboard.com>", "Subject": "[PATCH v3 11/14] libcamera: ipa: simple: Use float type for\n\tadjustment controls", "Date": "Wed, 14 Jan 2026 12:30:13 +0100", "Message-ID": "<20260114113016.25162-12-mzamazal@redhat.com>", "In-Reply-To": "<20260114113016.25162-1-mzamazal@redhat.com>", "References": "<20260114113016.25162-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.93", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "MqpF3KV1YuZPQfZhaCKuPUr5TJFOUqRTC1C2gefPavg_1768390260", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "control_ids.h defines the contrast type as float, let's use the same in\nsimple IPA, instead of double. Saturation and gamma already use float,\nexcept for the knobs, let's use float for the knobs too.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n include/libcamera/internal/software_isp/debayer_params.h | 2 +-\n src/ipa/simple/algorithms/adjust.cpp | 6 +++---\n src/ipa/simple/algorithms/lut.cpp | 2 +-\n src/ipa/simple/ipa_context.h | 8 ++++----\n 4 files changed, 9 insertions(+), 9 deletions(-)", "diff": "diff --git a/include/libcamera/internal/software_isp/debayer_params.h b/include/libcamera/internal/software_isp/debayer_params.h\nindex 256c7d43d..2d69bd295 100644\n--- a/include/libcamera/internal/software_isp/debayer_params.h\n+++ b/include/libcamera/internal/software_isp/debayer_params.h\n@@ -59,7 +59,7 @@ struct DebayerParams {\n \tMatrix<float, 3, 3> ccm;\n \tRGB<float> blackLevel;\n \tfloat gamma;\n-\tdouble contrastExp;\n+\tfloat contrastExp;\n };\n \n } /* namespace libcamera */\ndiff --git a/src/ipa/simple/algorithms/adjust.cpp b/src/ipa/simple/algorithms/adjust.cpp\nindex cfbc39610..95032799f 100644\n--- a/src/ipa/simple/algorithms/adjust.cpp\n+++ b/src/ipa/simple/algorithms/adjust.cpp\n@@ -33,9 +33,9 @@ int Adjust::init(IPAContext &context, [[maybe_unused]] const YamlObject &tuningD\n int Adjust::configure(IPAContext &context,\n \t\t [[maybe_unused]] const IPAConfigInfo &configInfo)\n {\n-\tcontext.activeState.knobs.gamma = std::optional<double>();\n-\tcontext.activeState.knobs.contrast = std::optional<double>();\n-\tcontext.activeState.knobs.saturation = std::optional<double>();\n+\tcontext.activeState.knobs.gamma = std::optional<float>();\n+\tcontext.activeState.knobs.contrast = std::optional<float>();\n+\tcontext.activeState.knobs.saturation = std::optional<float>();\n \n \treturn 0;\n }\ndiff --git a/src/ipa/simple/algorithms/lut.cpp b/src/ipa/simple/algorithms/lut.cpp\nindex a6dbd7b1d..f31a7e631 100644\n--- a/src/ipa/simple/algorithms/lut.cpp\n+++ b/src/ipa/simple/algorithms/lut.cpp\n@@ -41,7 +41,7 @@ void Lut::updateGammaTable(IPAContext &context)\n \t\t1.0 / context.activeState.knobs.gamma.value_or(kDefaultGamma);\n \tconst auto contrast = context.activeState.knobs.contrast.value_or(1.0);\n \t/* Convert 0..2 to 0..infinity; avoid actual inifinity at tan(pi/2) */\n-\tdouble contrastExp = tan(std::clamp(contrast * M_PI_4, 0.0, M_PI_2 - 0.00001));\n+\tfloat contrastExp = tan(std::clamp(contrast * M_PI_4, 0.0, M_PI_2 - 0.00001));\n \n \tif (!context.gpuIspEnabled) {\n \t\tauto &gammaTable = context.activeState.gamma.gammaTable;\ndiff --git a/src/ipa/simple/ipa_context.h b/src/ipa/simple/ipa_context.h\nindex 680b72eb9..85455bbfa 100644\n--- a/src/ipa/simple/ipa_context.h\n+++ b/src/ipa/simple/ipa_context.h\n@@ -58,8 +58,8 @@ struct IPAActiveState {\n \t\tstd::array<double, kGammaLookupSize> gammaTable;\n \t\tuint8_t blackLevel;\n \t\tfloat gamma;\n-\t\tdouble contrast;\n-\t\tdouble contrastExp;\n+\t\tfloat contrast;\n+\t\tfloat contrastExp;\n \t} gamma;\n \n \tMatrix<float, 3, 3> ccm;\n@@ -69,7 +69,7 @@ struct IPAActiveState {\n \tstruct {\n \t\tstd::optional<float> gamma;\n \t\t/* 0..2 range, 1.0 = normal */\n-\t\tstd::optional<double> contrast;\n+\t\tstd::optional<float> contrast;\n \t\tstd::optional<float> saturation;\n \t} knobs;\n };\n@@ -88,7 +88,7 @@ struct IPAFrameContext : public FrameContext {\n \t} gains;\n \n \tstd::optional<float> gamma;\n-\tstd::optional<double> contrast;\n+\tstd::optional<float> contrast;\n \tstd::optional<float> saturation;\n };\n \n", "prefixes": [ "v3", "11/14" ] }