Patch Detail
Show a patch.
GET /api/1.1/patches/25717/?format=api
{ "id": 25717, "url": "https://patchwork.libcamera.org/api/1.1/patches/25717/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25717/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260112103740.18360-3-robert.mader@collabora.com>", "date": "2026-01-12T10:37:38", "name": "[v2,2/4] egl: Remove bpp variable", "commit_ref": "22b15ff683123bd2196fd5806f698717edbf5196", "pull_url": null, "state": "accepted", "archived": false, "hash": "6921b75202d415f092887f300eadbc162894d1d3", "submitter": { "id": 140, "url": "https://patchwork.libcamera.org/api/1.1/people/140/?format=api", "name": "Robert Mader", "email": "robert.mader@collabora.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25717/mbox/", "series": [ { "id": 5702, "url": "https://patchwork.libcamera.org/api/1.1/series/5702/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5702", "date": "2026-01-12T10:37:36", "name": "GPUISP cleanups", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5702/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25717/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25717/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 02266BE08B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 12 Jan 2026 10:38:18 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B6EC861FC0;\n\tMon, 12 Jan 2026 11:38:18 +0100 (CET)", "from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com\n\t[136.143.188.112])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 635A461FBE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 12 Jan 2026 11:38:16 +0100 (CET)", "by mx.zohomail.com with SMTPS id 1768214291086141.38652604087088; \n\tMon, 12 Jan 2026 02:38:11 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"Y1kW852y\"; \n\tdkim-atps=neutral", "ARC-Seal": "i=1; a=rsa-sha256; t=1768214293; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=Jz0rnxXFabxJsO92Hnjll6ZioteBMDfQq4Ey7oWvU3H+6ZMU3nJrjxVg08EgBSRMekt0PmWQzUsyP/VDMObuiFCs3m6wiiICXiu3igPJWUoiYCt0JmNFJbFg22BxKV2TKue04VN0c5dhTopRus68De5BwaUWdyBqHIo4jehgAek=", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1768214293;\n\th=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;\n\tbh=j0dL+Sw7ngrHqKTsS1Igtoix9MzkwJDzje+T1BxJAmc=; \n\tb=DWsZrZrM8MCC/wy3qsuEy+z2r+Ccb5oLoxb1NdOb4rStwgQIrw8DvDhH0gG52Rh97kizCdInDXylNSDHmwa1OyldWCoJS9SVg/jfo4jaBxd7lujWvQtY2JQY44thhQm3uAOPH9d+KYG6nERqqBhZHNj9u4aBZrCm3IKaOg48NgM=", "ARC-Authentication-Results": "i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=<robert.mader@collabora.com>", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1768214293;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To;\n\tbh=j0dL+Sw7ngrHqKTsS1Igtoix9MzkwJDzje+T1BxJAmc=;\n\tb=Y1kW852ytbs3Djk/T69/DuS/mja7+Iy/3YLIhtoMo+wJ2M01qN6SqfXYDnZY8ZfF\n\tBn1j3c9IeTmVzgbTNnn8pi6y71cXG/Q9V4K9aohhjL2ZQ6gEzqOTJahSHEba8OGzqqy\n\toMjp1Acxajxilo87vi8aER7ICF0tOHslj+Xpxcgo=", "From": "Robert Mader <robert.mader@collabora.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Robert Mader <robert.mader@collabora.com>,\n\tHans de Goede <johannes.goede@oss.qualcomm.com>", "Subject": "[PATCH v2 2/4] egl: Remove bpp variable", "Date": "Mon, 12 Jan 2026 11:37:38 +0100", "Message-ID": "<20260112103740.18360-3-robert.mader@collabora.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260112103740.18360-1-robert.mader@collabora.com>", "References": "<20260112103740.18360-1-robert.mader@collabora.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "It's unused and, in one case, was set wrongly.\n\nSigned-off-by: Robert Mader <robert.mader@collabora.com>\nReviewed-by: Hans de Goede <johannes.goede@oss.qualcomm.com>\n---\n include/libcamera/internal/egl.h | 6 ++----\n src/libcamera/software_isp/debayer_egl.cpp | 4 ++--\n 2 files changed, 4 insertions(+), 6 deletions(-)", "diff": "diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h\nindex 7b810773c..21e2aa9df 100644\n--- a/include/libcamera/internal/egl.h\n+++ b/include/libcamera/internal/egl.h\n@@ -49,14 +49,13 @@ public:\n \t * \\brief Construct an eGLImage with explicit stride\n \t * \\param[in] width Image width in pixels\n \t * \\param[in] height Image height in pixels\n-\t * \\param[in] bpp Bytes per pixel\n \t * \\param[in] stride Row stride in bytes\n \t * \\param[in] texture_unit OpenGL texture unit\n \t * \\param[in] texture_unit_uniform_id Shader uniform ID\n \t */\n-\teGLImage(uint32_t width, uint32_t height, uint32_t bpp, uint32_t stride, GLenum texture_unit, uint32_t texture_unit_uniform_id)\n+\teGLImage(uint32_t width, uint32_t height, uint32_t stride, GLenum texture_unit, uint32_t texture_unit_uniform_id)\n \t\t: width_(width), height_(height), stride_(stride),\n-\t\t framesize_(stride * height), bpp_(bpp),\n+\t\t framesize_(stride * height),\n \t\t texture_unit_uniform_id_(texture_unit_uniform_id),\n \t\t texture_unit_(texture_unit)\n \t{\n@@ -81,7 +80,6 @@ public:\n \tuint32_t stride_; /**< Row stride in bytes */\n \tuint32_t offset_; /**< Buffer offset (reserved for future use) */\n \tuint32_t framesize_; /**< Total frame size in bytes (stride * height) */\n-\tuint32_t bpp_; /**< Bytes per pixel */\n \tuint32_t texture_unit_uniform_id_; /**< Shader uniform id for texture unit */\n \tGLenum texture_unit_; /**< Texture unit associated with this image eg (GL_TEXTURE0) */\n \tGLuint texture_; /**< OpenGL texture object ID */\ndiff --git a/src/libcamera/software_isp/debayer_egl.cpp b/src/libcamera/software_isp/debayer_egl.cpp\nindex 1c13b72a5..9693d7252 100644\n--- a/src/libcamera/software_isp/debayer_egl.cpp\n+++ b/src/libcamera/software_isp/debayer_egl.cpp\n@@ -597,10 +597,10 @@ int DebayerEGL::start()\n \tLOG(Debayer, Debug) << \"Available fragment shader texture units \" << maxTextureImageUnits;\n \n \t/* Raw bayer input as texture */\n-\teglImageBayerIn_ = std::make_unique<eGLImage>(width_, height_, 32, inputConfig_.stride, GL_TEXTURE0, 0);\n+\teglImageBayerIn_ = std::make_unique<eGLImage>(width_, height_, inputConfig_.stride, GL_TEXTURE0, 0);\n \n \t/* Texture we will render to */\n-\teglImageBayerOut_ = std::make_unique<eGLImage>(outputSize_.width, outputSize_.height, 31, outputConfig_.stride, GL_TEXTURE1, 1);\n+\teglImageBayerOut_ = std::make_unique<eGLImage>(outputSize_.width, outputSize_.height, outputConfig_.stride, GL_TEXTURE1, 1);\n \n \tif (initBayerShaders(inputPixelFormat_, outputPixelFormat_))\n \t\treturn -EINVAL;\n", "prefixes": [ "v2", "2/4" ] }