Patch Detail
Show a patch.
GET /api/1.1/patches/25710/?format=api
{ "id": 25710, "url": "https://patchwork.libcamera.org/api/1.1/patches/25710/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25710/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260110170927.79918-5-robert.mader@collabora.com>", "date": "2026-01-10T17:09:27", "name": "[4/4] egl: Detect and print GLES version", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "4593641aef6c3892bcd24c9e520af3d610aa51da", "submitter": { "id": 140, "url": "https://patchwork.libcamera.org/api/1.1/people/140/?format=api", "name": "Robert Mader", "email": "robert.mader@collabora.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25710/mbox/", "series": [ { "id": 5698, "url": "https://patchwork.libcamera.org/api/1.1/series/5698/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5698", "date": "2026-01-10T17:09:23", "name": "GPUISP cleanups", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5698/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25710/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25710/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 68CAFBE08B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 10 Jan 2026 17:10:29 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2C1AA61FBB;\n\tSat, 10 Jan 2026 18:10:29 +0100 (CET)", "from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com\n\t[136.143.188.112])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 23F7361A35\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 10 Jan 2026 18:10:27 +0100 (CET)", "by mx.zohomail.com with SMTPS id 17680650226261006.9399851149269; \n\tSat, 10 Jan 2026 09:10:22 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=collabora.com\n\theader.i=robert.mader@collabora.com header.b=\"YvfLMXfJ\"; \n\tdkim-atps=neutral", "ARC-Seal": "i=1; a=rsa-sha256; t=1768065023; cv=none; \n\td=zohomail.com; s=zohoarc; \n\tb=CsmlddkAdB/kDyslrYTDHMar1e9+J3DpLfKWMl3TpOR6Z4Nk6oPOGWF1lbbdlEBL2tUE3o1NTSqRzZyXYyHmx69FZzC6d9SQfmWHR3ZWwB7blIyGcP/6482FWxzi2wtOIRs8ALAza8caeTbLdGFW1DDIyZWpzy2vI7kYYjRT1NU=", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; \n\ts=zohoarc; t=1768065023;\n\th=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;\n\tbh=v4Q+COl19zIZoqgfqqiXglwzoziFh++Fcz/pfsjQiJk=; \n\tb=L54nU4EyveK9oztddYanAfxJCW7LDx9RrL7ccf0UpIB1u85JnYYjN/eD+Kpe0uPrDXW2Xxt5/hon2zWXKzF0gE0VzjsCk3Z+JSbMK6YYrwYD2VIad2XVacA9DrwkevA+lcaBlVFX1atqGzAaC+tC/3YqpzkENa3In1x5YB8uc7o=", "ARC-Authentication-Results": "i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=robert.mader@collabora.com;\n\tdmarc=pass header.from=<robert.mader@collabora.com>", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1768065023;\n\ts=zohomail; d=collabora.com; i=robert.mader@collabora.com;\n\th=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Message-Id:Reply-To;\n\tbh=v4Q+COl19zIZoqgfqqiXglwzoziFh++Fcz/pfsjQiJk=;\n\tb=YvfLMXfJtc7958eCedh9dI//j8HHltnUagtLrV0V4P7KxF+recal3zoVfE7QSPqU\n\tfMEEscOvwJesmifW9CQo6Zz8BLyE7OdbMf/IKIMq19QjnZ87uUTjnaI73wVFrHCAGOy\n\tgfel/1/heHImdeHCoS0Gw2CgdD+K6apGPcxnI8e8=", "From": "Robert Mader <robert.mader@collabora.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Robert Mader <robert.mader@collabora.com>", "Subject": "[PATCH 4/4] egl: Detect and print GLES version", "Date": "Sat, 10 Jan 2026 18:09:27 +0100", "Message-ID": "<20260110170927.79918-5-robert.mader@collabora.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260110170927.79918-1-robert.mader@collabora.com>", "References": "<20260110170927.79918-1-robert.mader@collabora.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "It might come in handy to know whether 2.0 or e.g. 3.2 is used.\n\nSigned-off-by: Robert Mader <robert.mader@collabora.com>\n---\n include/libcamera/internal/egl.h | 1 +\n src/libcamera/egl.cpp | 17 +++++++++++++++++\n 2 files changed, 18 insertions(+)", "diff": "diff --git a/include/libcamera/internal/egl.h b/include/libcamera/internal/egl.h\nindex 21e2aa9df..f007f448a 100644\n--- a/include/libcamera/internal/egl.h\n+++ b/include/libcamera/internal/egl.h\n@@ -136,5 +136,6 @@ private:\n \tPFNGLEGLIMAGETARGETTEXTURE2DOESPROC glEGLImageTargetTexture2DOES;\n \tPFNEGLCREATEIMAGEKHRPROC eglCreateImageKHR;\n \tPFNEGLDESTROYIMAGEKHRPROC eglDestroyImageKHR;\n+\tPFNGLGETSTRINGPROC glGetString;\n };\n } //namespace libcamera\ndiff --git a/src/libcamera/egl.cpp b/src/libcamera/egl.cpp\nindex 0bd9a83be..0ffd008c7 100644\n--- a/src/libcamera/egl.cpp\n+++ b/src/libcamera/egl.cpp\n@@ -288,6 +288,10 @@ int eGL::initEGLContext(GBM *gbmContext)\n \tEGLint major;\n \tEGLint minor;\n \n+\tconst char *glVersion;\n+\tEGLint glMajor;\n+\tEGLint glMinor;\n+\n \tif (!eglBindAPI(EGL_OPENGL_ES_API)) {\n \t\tLOG(eGL, Error) << \"API bind fail\";\n \t\tgoto fail;\n@@ -327,6 +331,12 @@ int eGL::initEGLContext(GBM *gbmContext)\n \t\tgoto fail;\n \t}\n \n+\tglGetString = (PFNGLGETSTRINGPROC)eglGetProcAddress(\"glGetString\");\n+\tif (!glGetString) {\n+\t\tLOG(eGL, Error) << \"glGetString not found\";\n+\t\tgoto fail;\n+\t}\n+\n \tif (eglChooseConfig(display_, configAttribs, &config, 1, &numConfigs) != EGL_TRUE) {\n \t\tLOG(eGL, Error) << \"eglChooseConfig fail\";\n \t\tgoto fail;\n@@ -342,6 +352,13 @@ int eGL::initEGLContext(GBM *gbmContext)\n \n \tmakeCurrent();\n \n+\tglVersion = (const char *)glGetString(GL_VERSION);\n+\tif (glVersion &&\n+\t sscanf(glVersion, \"OpenGL ES %d.%d\", &glMajor, &glMinor) == 2 &&\n+\t glMajor > 0 && glMinor >= 0) {\n+\t\tLOG(eGL, Info) << \"GLES: version: \" << glMajor << \".\" << glMinor;\n+\t}\n+\n \treturn 0;\n fail:\n \n", "prefixes": [ "4/4" ] }