Patch Detail
Show a patch.
GET /api/1.1/patches/25702/?format=api
{ "id": 25702, "url": "https://patchwork.libcamera.org/api/1.1/patches/25702/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25702/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260108-sklug-lsc-resampling-v2-dev-v2-12-e682ec4b9893@ideasonboard.com>", "date": "2026-01-08T16:05:55", "name": "[v2,12/15] ipa: rkisp1: lsc: Pass crop rectangle as parameter", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "3b099fc394166d1c48420b48f5e6893950045b50", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25702/mbox/", "series": [ { "id": 5697, "url": "https://patchwork.libcamera.org/api/1.1/series/5697/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5697", "date": "2026-01-08T16:05:43", "name": "Add resampling support for polynomial LSC data", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5697/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25702/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25702/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B2F56BE08B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 8 Jan 2026 16:07:03 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7AD3E61FC7;\n\tThu, 8 Jan 2026 17:07:03 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4DE7561FC5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 8 Jan 2026 17:07:01 +0100 (CET)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:90af:8957:b721:10d4])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 9BE6F1E2F; \n\tThu, 8 Jan 2026 17:06:38 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RvrBngdi\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1767888398;\n\tbh=6DcFU41nFTZ+ryNzV+MHGZvgRGDJ2yf8ftNYclk/8WQ=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=RvrBngdiWxv4kP/NZauZ8ZyeZw8K9GJfiw9VOcEK0kSxEVZbejPymV08TmXcnbXyX\n\tOKaBE4o1WtGH/2COb+x0jv9xVTZ7zWAeEa6WUgwpaVrZZUe3S9Uc7mlJcrLhuWJrNf\n\t6+egPmPV5mbuC9WY7cN9OTFMUNl1bCTvZg6PRF/U=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "Date": "Thu, 08 Jan 2026 17:05:55 +0100", "Subject": "[PATCH v2 12/15] ipa: rkisp1: lsc: Pass crop rectangle as parameter", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260108-sklug-lsc-resampling-v2-dev-v2-12-e682ec4b9893@ideasonboard.com>", "References": "<20260108-sklug-lsc-resampling-v2-dev-v2-0-e682ec4b9893@ideasonboard.com>", "In-Reply-To": "<20260108-sklug-lsc-resampling-v2-dev-v2-0-e682ec4b9893@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>, =?utf-8?q?Barnab=C3=A1s_P?=\n\t=?utf-8?b?xZFjemU=?= <barnabas.pocze@ideasonboard.com>,\n\tRui Wang <rui.wang@ideasonboard.com>", "X-Mailer": "b4 0.14.2", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In preparation for the upcoming rework, pass the crop rectangle as\nparameter to samplePolynomial(). This patch contains no functional\nchange.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nReviewed-by: Rui Wang <rui.wang@ideasonboard.com>\n\n---\n\nChanges in v2:\n- Collected tags\n---\n src/ipa/rkisp1/algorithms/lsc.cpp | 22 ++++++++++++----------\n 1 file changed, 12 insertions(+), 10 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\nindex 7505307bfbaa02710b36b47d00d88a582886c1c0..a5855f8a0a67a6b5ad95635454f3716d07c86e6f 100644\n--- a/src/ipa/rkisp1/algorithms/lsc.cpp\n+++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n@@ -93,7 +93,8 @@ private:\n \tstd::vector<double> sizesListToPositions(const std::vector<double> &sizes);\n \tstd::vector<uint16_t> samplePolynomial(const LscPolynomial &poly,\n \t\t\t\t\t Span<const double> xPositions,\n-\t\t\t\t\t Span<const double> yPositions);\n+\t\t\t\t\t Span<const double> yPositions,\n+\t\t\t\t\t const Rectangle &cropRectangle);\n \n \tSize sensorSize_;\n \tRectangle cropRectangle_;\n@@ -136,10 +137,10 @@ int LscPolynomialLoader::parseLscData(const YamlObject &yamlSets,\n \n \t\tstd::vector<double> xPos = sizesListToPositions(xSizes_);\n \t\tstd::vector<double> yPos = sizesListToPositions(ySizes_);\n-\t\tset.r = samplePolynomial(*pr, xPos, yPos);\n-\t\tset.gr = samplePolynomial(*pgr, xPos, yPos);\n-\t\tset.gb = samplePolynomial(*pgb, xPos, yPos);\n-\t\tset.b = samplePolynomial(*pb, xPos, yPos);\n+\t\tset.r = samplePolynomial(*pr, xPos, yPos, cropRectangle_);\n+\t\tset.gr = samplePolynomial(*pgr, xPos, yPos, cropRectangle_);\n+\t\tset.gb = samplePolynomial(*pgb, xPos, yPos, cropRectangle_);\n+\t\tset.b = samplePolynomial(*pb, xPos, yPos, cropRectangle_);\n \t}\n \n \tif (lscData.empty()) {\n@@ -178,13 +179,14 @@ std::vector<double> LscPolynomialLoader::sizesListToPositions(const std::vector<\n \n std::vector<uint16_t> LscPolynomialLoader::samplePolynomial(const LscPolynomial &poly,\n \t\t\t\t\t\t\t Span<const double> xPositions,\n-\t\t\t\t\t\t\t Span<const double> yPositions)\n+\t\t\t\t\t\t\t Span<const double> yPositions,\n+\t\t\t\t\t\t\t const Rectangle &cropRectangle)\n {\n \tdouble m = poly.getM();\n-\tdouble x0 = cropRectangle_.x / m;\n-\tdouble y0 = cropRectangle_.y / m;\n-\tdouble w = cropRectangle_.width / m;\n-\tdouble h = cropRectangle_.height / m;\n+\tdouble x0 = cropRectangle.x / m;\n+\tdouble y0 = cropRectangle.y / m;\n+\tdouble w = cropRectangle.width / m;\n+\tdouble h = cropRectangle.height / m;\n \tstd::vector<uint16_t> samples;\n \n \tsamples.reserve(xPositions.size() * yPositions.size());\n", "prefixes": [ "v2", "12/15" ] }