Patch Detail
Show a patch.
GET /api/1.1/patches/25696/?format=api
{ "id": 25696, "url": "https://patchwork.libcamera.org/api/1.1/patches/25696/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25696/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260108-sklug-lsc-resampling-v2-dev-v2-6-e682ec4b9893@ideasonboard.com>", "date": "2026-01-08T16:05:49", "name": "[v2,06/15] ipa: rkisp1: lsc: Rename res to samples", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "7d680e9facf116abc0cb0f0374c98d165b8b7f24", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25696/mbox/", "series": [ { "id": 5697, "url": "https://patchwork.libcamera.org/api/1.1/series/5697/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5697", "date": "2026-01-08T16:05:43", "name": "Add resampling support for polynomial LSC data", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5697/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25696/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25696/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D4B0BBE08B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 8 Jan 2026 16:06:45 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8D41F61FC8;\n\tThu, 8 Jan 2026 17:06:45 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EBC0D61FA0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 8 Jan 2026 17:06:43 +0100 (CET)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:90af:8957:b721:10d4])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 7CE0819D0; \n\tThu, 8 Jan 2026 17:06:21 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lLFmgPtO\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1767888381;\n\tbh=jpVW171WvOTT4/C/X32xZQLYDdf8/dod1BqJw5h2R6g=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=lLFmgPtOrsEJC259GeX1A85IxmMQWaIxN+x1EmF7pPmpXiET355bDJYfNDwMsH+DN\n\tQlWIbF69W5f4HYyR0fHp1afGm9s2gxehPohYVLH/N28gdAxxa1e6HIevBYRoWZWmE3\n\tSMm4ffWt3/Po7woHNIoiOlXsFrYBEwAF5UnQwAk0=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "Date": "Thu, 08 Jan 2026 17:05:49 +0100", "Subject": "[PATCH v2 06/15] ipa: rkisp1: lsc: Rename res to samples", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "8bit", "Message-Id": "<20260108-sklug-lsc-resampling-v2-dev-v2-6-e682ec4b9893@ideasonboard.com>", "References": "<20260108-sklug-lsc-resampling-v2-dev-v2-0-e682ec4b9893@ideasonboard.com>", "In-Reply-To": "<20260108-sklug-lsc-resampling-v2-dev-v2-0-e682ec4b9893@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>, =?utf-8?q?Barnab=C3=A1s_P?=\n\t=?utf-8?b?xZFjemU=?= <barnabas.pocze@ideasonboard.com>,\n\tRui Wang <rui.wang@ideasonboard.com>", "X-Mailer": "b4 0.14.2", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Rename res to samples to better describe the intent. This was noted in\nreview after the series was merged.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nReviewed-by: Rui Wang <rui.wang@ideasonboard.com>\n\n---\n\nChanges in v2:\n- Collected tags\n---\n src/ipa/rkisp1/algorithms/lsc.cpp | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\nindex 68e262a2b057d12a9019a6a92c1b300272b04c4d..1b15c11093cfd63bf740558da9450ac836b12004 100644\n--- a/src/ipa/rkisp1/algorithms/lsc.cpp\n+++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n@@ -166,12 +166,12 @@ private:\n \t\tdouble y0 = cropRectangle_.y / m;\n \t\tdouble w = cropRectangle_.width / m;\n \t\tdouble h = cropRectangle_.height / m;\n-\t\tstd::vector<uint16_t> res;\n+\t\tstd::vector<uint16_t> samples;\n \n \t\tASSERT(xSizes_.size() * 2 + 1 == k);\n \t\tASSERT(ySizes_.size() * 2 + 1 == k);\n \n-\t\tres.reserve(k * k);\n+\t\tsamples.reserve(k * k);\n \n \t\tstd::vector<double> xPos(sizesListToPositions(xSizes_));\n \t\tstd::vector<double> yPos(sizesListToPositions(ySizes_));\n@@ -189,10 +189,10 @@ private:\n \t\t\t\t\tpoly.sampleAtNormalizedPixelPos(xp, yp) *\n \t\t\t\t\t1024);\n \t\t\t\tv = std::min(std::max(v, 1024), 4095);\n-\t\t\t\tres.push_back(v);\n+\t\t\t\tsamples.push_back(v);\n \t\t\t}\n \t\t}\n-\t\treturn res;\n+\t\treturn samples;\n \t}\n \n \tSize sensorSize_;\n", "prefixes": [ "v2", "06/15" ] }