Patch Detail
Show a patch.
GET /api/1.1/patches/25685/?format=api
{ "id": 25685, "url": "https://patchwork.libcamera.org/api/1.1/patches/25685/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25685/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260107193607.2168539-4-barnabas.pocze@ideasonboard.com>", "date": "2026-01-07T19:36:05", "name": "[RFC,v1,3/5] libcamera: base: log: Ignore deprecations", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "b985c93927940800a314ee15bb08c899c91b3c3d", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/1.1/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25685/mbox/", "series": [ { "id": 5694, "url": "https://patchwork.libcamera.org/api/1.1/series/5694/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5694", "date": "2026-01-07T19:36:02", "name": "C++20 migration", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5694/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25685/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25685/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8D4D8BDCBF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 7 Jan 2026 19:36:20 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8C33C61FC7;\n\tWed, 7 Jan 2026 20:36:17 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D1AD061FBB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 7 Jan 2026 20:36:13 +0100 (CET)", "from pb-laptop.local (185.221.143.114.nat.pool.zt.hu\n\t[185.221.143.114])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 06D5A180F;\n\tWed, 7 Jan 2026 20:35:52 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MOS3ZdUv\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1767814552;\n\tbh=vvfwxztFIEYLUbdWq+BvDLroLOUqJalhjOohUNL/AzQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=MOS3ZdUvb4kJOX1uQTccHckfKnskwCSdOSRMqvLuk7DxbPL6KdXES3FuNxg5wc6MG\n\t2WvLAovkD0WiayYQ4cL7lmS8NLaVxWYrZ4YaumEBv4Vx9uBivZ0aTZKRM11uKux7YK\n\tz4YKNtTLV3RBNTUcexzLG63WnF/xJQQVm1h8ApK0=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Naushir Patuck <naush@raspberrypi.com>", "Subject": "[RFC PATCH v1 3/5] libcamera: base: log: Ignore deprecations", "Date": "Wed, 7 Jan 2026 20:36:05 +0100", "Message-ID": "<20260107193607.2168539-4-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260107193607.2168539-1-barnabas.pocze@ideasonboard.com>", "References": "<20260107193607.2168539-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "`std::atomic_{load,store}()` with `std::shared_ptr` has been deprecated\nin C++20 in favour of `std::atomic<std::shared_ptr<>>`. However, it is\nnot available on all supported platforms. So ignore the deprecation warnings.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/libcamera/base/log.cpp | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/src/libcamera/base/log.cpp b/src/libcamera/base/log.cpp\nindex 6e6d2887c..b28217750 100644\n--- a/src/libcamera/base/log.cpp\n+++ b/src/libcamera/base/log.cpp\n@@ -326,6 +326,11 @@ private:\n \tstd::vector<std::unique_ptr<LogCategory>> categories_ LIBCAMERA_TSA_GUARDED_BY(mutex_);\n \tstd::list<std::pair<std::string, LogSeverity>> levels_;\n \n+\t/*\n+\t * \\todo Use `std::atomic<std::shared_ptr<>>` and drop the pragma\n+\t * once it works on all supported platforms.\n+\t */\n+#pragma GCC diagnostic ignored \"-Wdeprecated-declarations\"\n \tstd::shared_ptr<LogOutput> output_;\n };\n \n", "prefixes": [ "RFC", "v1", "3/5" ] }