Patch Detail
Show a patch.
GET /api/1.1/patches/25676/?format=api
{ "id": 25676, "url": "https://patchwork.libcamera.org/api/1.1/patches/25676/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25676/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260106170059.56193-25-bryan.odonoghue@linaro.org>", "date": "2026-01-06T17:00:59", "name": "[v11,24/24] libcamera: software_isp: Add a gpuisp todo list", "commit_ref": "aaa48bb276ef88fa488f3c08f16ee1b74b3bfb6d", "pull_url": null, "state": "accepted", "archived": false, "hash": "f584a86e37620d24e72c6ff944a774ef3511cf7d", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25676/mbox/", "series": [ { "id": 5689, "url": "https://patchwork.libcamera.org/api/1.1/series/5689/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5689", "date": "2026-01-06T17:00:35", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 10, "mbox": "https://patchwork.libcamera.org/series/5689/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25676/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25676/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 286FEBDCC0\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 6 Jan 2026 17:01:36 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D4EF86200B;\n\tTue, 6 Jan 2026 18:01:35 +0100 (CET)", "from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com\n\t[IPv6:2a00:1450:4864:20::42e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A345A6203E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 6 Jan 2026 18:01:32 +0100 (CET)", "by mail-wr1-x42e.google.com with SMTP id\n\tffacd0b85a97d-42fb0fc5aa4so890953f8f.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 06 Jan 2026 09:01:32 -0800 (PST)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-432bd0dadcfsm5515322f8f.3.2026.01.06.09.01.30\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 06 Jan 2026 09:01:31 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"eVV+aaPG\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1767718892; x=1768323692;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=cR80ZvDKl1PnsXEsbuYPf4NeCxqkK7YbeqET+brIs1A=;\n\tb=eVV+aaPG+ROWY8zLHnUBFwTxA6exq/vWQfie7z6bnYbthKcTxZXRqK+lRpm6IrY9jp\n\tmWKrjrR6SCDadbKteqMrl0sHPvOtSKZb7lyTmav7AuaANreDYbsksUZ3k4L64uFaUcSm\n\tpTMTReF5bbMgZhw5lOvrWgi9mnMwkZuXOxmpbkWEltxkDpws9q6Mw4RzdBnn7Hi600x2\n\tuOLospVVeGKRBDv1Klgv6b0lTJFiNC5MrxZ1qP8VQG1ETUHYwNqkELJrBD5WqNjQS/73\n\tVy6Z+dO+xdyb7S8frziLPPIklvkREPUIhZvwcLb/AJejW4kpPfe0f9vpFqHqDgD0BXXR\n\t1zIw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1767718892; x=1768323692;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=cR80ZvDKl1PnsXEsbuYPf4NeCxqkK7YbeqET+brIs1A=;\n\tb=GJJINv70PS9ajCi90X64TtRfS8lFAzG6uZKtq2zuX+VMOOSdaS8qCenWczlk20qUk0\n\tGdUdVjIGt8pnn51rYxTTbA2fD2CELAbsXOq5vwiHDtYSwKFKrIMjy5Pyp4BxwmGz3xlu\n\tisY0kQIqfXMaM/hePfdwUTPDflq7NuA5z6xYFNIgdSwtkHm8zrnphL7ER3BnQhrl9cGQ\n\tsHcorfg6nO/i7GzsnAzaEUEUWAjH/G8+ABA3HNAPfm5WP9w6eNtELee4UajIj7ZrCO+g\n\txg6nYUb8hcLXj5aixBb0S3e3Wc2xrsSjulZ5wwrnkNCyVVcH6UVE3FSv4WYady/KrJ0f\n\tqyMg==", "X-Gm-Message-State": "AOJu0YzE+NEd6rnxATE5yLuhnKRleNC8OQ3uj5Mn8x7xaBqrUIfeoMS2\n\t3B8LdlYBRBar3O1RZVwIlPMtdRINw2AQKlGWhtyyj7LDhgkbVdhVuoAZ3QxXgFoVzoCHu2+EuxW\n\t7BAxEOwg=", "X-Gm-Gg": "AY/fxX55xoomkeNgA6sxYqoswKbDP5BPPFSsOd4DtKxTdJ/yVXO83utWbrd2+VtrfF8\n\tjEP4HJxOk3MCg+5DWygYC+wRpTbY6PU2N9eH09Sos8MAX16rEN2sivmnb/7jex3wE5Zd1g1/WHR\n\tLM6Z5jNvCKs+h/jDOtcr/p7bK4s7q7QJTPPwVFBIIpmnAssSFq1oVGNQPUr92uH9gAOjT35AN7C\n\tIJ/1RJGaHpJjzXhMJ7gaIV9OIrBiPAZhhQHtAKXLpMudVq0B2Xj9cIKR2plOVIq0Actesz8iu4/\n\t74A2P17PPteMeuBQXtnbbEtueiaMaGReH7JvsWIny2v9nktRrpduaawn1qH5Q21WqizIQZR/pNs\n\tDS+LABCBNHa6OteAZGBV80OKTcSxM207johmO+SF5xATrSPVJNmaBjfSGilPdsZRopNx83XMQAg\n\tq1Vov6FWGzrHoVjYfvWv4UmDz2pVhW8BeK5RE+yDNEXLoojpmQP1jHgKNzKiYloCPHULhmR+3eh\n\t+GBeg==", "X-Google-Smtp-Source": "AGHT+IHwdASHVjNpkuodtp/BXtCraHYEsO1pEvCW3Rbt+3iQiifG8aN7jLHfkpX35nCc/PsVPRDihw==", "X-Received": "by 2002:a05:6000:18a6:b0:431:104:6dd5 with SMTP id\n\tffacd0b85a97d-432bc9fd1c4mr4954807f8f.58.1767718891699; \n\tTue, 06 Jan 2026 09:01:31 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tMilan Zamazal <mzamazal@redhat.com>", "Subject": "[PATCH v11 24/24] libcamera: software_isp: Add a gpuisp todo list", "Date": "Tue, 6 Jan 2026 17:00:59 +0000", "Message-ID": "<20260106170059.56193-25-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260106170059.56193-1-bryan.odonoghue@linaro.org>", "References": "<20260106170059.56193-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "List the series of things to do in GPU ISP in perceived order of\ndifficulty.\n\nAcked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/gpuisp-todo.txt | 40 ++++++++++++++++++++++\n 1 file changed, 40 insertions(+)\n create mode 100644 src/libcamera/software_isp/gpuisp-todo.txt", "diff": "diff --git a/src/libcamera/software_isp/gpuisp-todo.txt b/src/libcamera/software_isp/gpuisp-todo.txt\nnew file mode 100644\nindex 000000000..8930da120\n--- /dev/null\n+++ b/src/libcamera/software_isp/gpuisp-todo.txt\n@@ -0,0 +1,40 @@\n+List the TODOs in perceived order of ease.\n+\n+\n+Denoising:\n+\t- WIP\n+\n+Dead pixel correction:\n+\t- WIP\n+\n+Lense shading correction:\n+\t- WIP\n+\n+Use dma-buf handle to generate upload texture:\n+\t- eglCreateImageKHR can be used to generate the upload texture i.e.\n+\t to feed the bayer data into the GPU.\n+\n+processFrame() to run in its own thread:\n+\t- processFrame() runs in the context of the Debayer::process()\n+\t thread. Robert Mader suggested and it seems like a good\n+\t suggestion too to run processFrame() in its own thread.\n+\n+Multi-pass shaders:\n+\t- This needs some rewiring the idea is to have a list\n+\t of algorithms as is done in cpuisp iterating through the\n+\t list in a for() loop.\n+\t- The logic managing the loop has an initial input buffer\n+\t and the final output buffer.\n+\t- The higher level logic must then inform each of the\n+\t algorithms either to generate an internal working buffer\n+\t or pass the final output buffer to the last shader\n+\t in the list\n+\t- This will allow for multi-pass shaders with the final\n+\t algorithm presenting data not to its internal buffer\n+\t but to the final output buffer\n+\n+24 bit output support:\n+\t- Need to implement compute shader to do this.\n+\n+Lense flare correction:\n+\t- Not WIP still TBD\n", "prefixes": [ "v11", "24/24" ] }