Patch Detail
Show a patch.
GET /api/1.1/patches/25671/?format=api
{ "id": 25671, "url": "https://patchwork.libcamera.org/api/1.1/patches/25671/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25671/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260106170059.56193-20-bryan.odonoghue@linaro.org>", "date": "2026-01-06T17:00:54", "name": "[v11,19/24] ipa: simple: Add a flag to indicate gpuIspEnabled", "commit_ref": "fe9e143702af9458c8c9c5189ad860299b70f163", "pull_url": null, "state": "accepted", "archived": false, "hash": "106159529ab768069045fda42af0d9e421013c56", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25671/mbox/", "series": [ { "id": 5689, "url": "https://patchwork.libcamera.org/api/1.1/series/5689/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5689", "date": "2026-01-06T17:00:35", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 10, "mbox": "https://patchwork.libcamera.org/series/5689/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25671/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25671/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 791ECBDCC0\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 6 Jan 2026 17:01:30 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 283596202B;\n\tTue, 6 Jan 2026 18:01:30 +0100 (CET)", "from mail-wr1-x436.google.com (mail-wr1-x436.google.com\n\t[IPv6:2a00:1450:4864:20::436])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4CD346201B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 6 Jan 2026 18:01:27 +0100 (CET)", "by mail-wr1-x436.google.com with SMTP id\n\tffacd0b85a97d-42fb2314f52so580905f8f.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 06 Jan 2026 09:01:27 -0800 (PST)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-432bd0dadcfsm5515322f8f.3.2026.01.06.09.01.25\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 06 Jan 2026 09:01:25 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"OQqI5vIS\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1767718886; x=1768323686;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=obbRpAVZjcoxO7/iHqw+nRA0ImMCqi2GHIb0BnjqJe8=;\n\tb=OQqI5vISHPn1XG88qnL24FTu7QisQ7HuloHNpdQqnl1QLTbR5P7FVRTGb4Qu9eYQPD\n\trkL7+8KY6jtTYCDUOyktgsYwxIg1rXkDRlF96W/1vMhLRAtLvw1IJ5FQ3/Sh4yF9lPNt\n\tUaxx9jtx2OkFmwiiYZk2hXIj7bNyWMGrs14ut5IoDyArJFMzf1BN+8WpRQv+TKCePebR\n\tNgUjjFa7OYJxQfa9pyWsEDd1GftfGPIcasKX4u1K/LODFvOs39CYiMGl+uEYBKIdvkXK\n\tLu5v9XAEFYXylmExFB9fAL1duIHZ8dVDOpgGLCPBsJQLSIQxY+LYqGTJSswPoJN8lDPG\n\tmyIg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1767718886; x=1768323686;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=obbRpAVZjcoxO7/iHqw+nRA0ImMCqi2GHIb0BnjqJe8=;\n\tb=NDqj1AWDz6xWGrqMMFt493HnqO0ZBb9Ln7n28cjVjdklgZE12Bm8fQXO2+qby4Wjvc\n\taWz9UCptH8ZV6cct8JsfIqgHgZgKHWha4epkCTE/DFOuyUineW8yOo6RomNOSjoGbHxR\n\tcLbaWnpHGAy02072yFcj60eRVXw3zrHSqqy2Ny7+B9vBrqqBcyJTKaBMLoJ4pFKrUnJF\n\tnoBTdr8Kc2aT0r9e6e8+SKfgsiEJkaGqa4fnM3/MH66skxm4leeGdL3B9JQG2rpybez6\n\tn9xOrgJqzFzLij3ZF7rJCXAemOruDCLbx2PgI0/Mqvg56PbBnD7nB1AQv5bjyA3siHVE\n\tK+Cw==", "X-Gm-Message-State": "AOJu0YxjFJvF48IEFqhcpBxChZDXYlAWYo7/0hJq8r3uBjYayJUAEgCm\n\tZdGMeXYIQ92hvGLefmCZ91T6ja2WLRqY+eXcfqVaBwqJRJHDtAHg6/SvLi9YIgVwZgqnUv/XM/l\n\t7P+1/K74=", "X-Gm-Gg": "AY/fxX4wVlejL0eJGReUblVfux9yJRDAO51E14Jy99rRq9/rhgEWR+yr6wBKrQYkEgO\n\tCD60qjMz8YnyACm48ceJwdgYS3kjmLVzSuIgD+us7mWrnYOq+gZn+wPYL1VoOAkmxy3Q7sAlwP8\n\tN/wqrg5ClCTRBdAEIsr2z6rRi0EBeeFvv0zWmhyfuMsIl4jn48XA9KmcGMPgLal0i5keqwqCvio\n\typmqC5AkZorduwrQurDPJUZgFvchKy/1OimzOa8Rm11Exw10oifBs9BQJDXR8rlkXThqnTeMED5\n\tS118VWWA2RcuooAnYTqoFDj0PdJ1vZ4WIdLikqFx61CjjEW9YaH8TFnBh2ofS6ioBGxs7uij/A9\n\tHOtVjJOBgVFS4oiw5UxAy4bZ6bPcqojPSkT3oxLY7IqSXh89Wq7jQGUECrccMMERz63KIMCwq26\n\twqmYekG/NtEa0+SqTirqM9sh3nGuQwNYc4nY6Ms2VO1WImOhQHoXYQ5b9PTfKfPyIafRA=", "X-Google-Smtp-Source": "AGHT+IGEVnZnrOVFylNVBK5+GhMY1mrE44j1PP/HesrtiFTxXbOJLBuQWQhfJp7lPC1ZKRx1tcqb2Q==", "X-Received": "by 2002:a05:6000:288b:b0:430:fb6d:1442 with SMTP id\n\tffacd0b85a97d-432bca52322mr5037484f8f.62.1767718886418; \n\tTue, 06 Jan 2026 09:01:26 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tMilan Zamazal <mzamazal@redhat.com>", "Subject": "[PATCH v11 19/24] ipa: simple: Add a flag to indicate gpuIspEnabled", "Date": "Tue, 6 Jan 2026 17:00:54 +0000", "Message-ID": "<20260106170059.56193-20-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20260106170059.56193-1-bryan.odonoghue@linaro.org>", "References": "<20260106170059.56193-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Flag gpuIspEnabled in the simple IPA context. This flag will allow to\nselectively avoid some calculations or to generate a default CCM.\n\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n include/libcamera/ipa/soft.mojom | 3 ++-\n src/ipa/simple/ipa_context.h | 1 +\n src/ipa/simple/soft_simple.cpp | 3 +++\n src/libcamera/software_isp/software_isp.cpp | 11 +++++++++--\n 4 files changed, 15 insertions(+), 3 deletions(-)", "diff": "diff --git a/include/libcamera/ipa/soft.mojom b/include/libcamera/ipa/soft.mojom\nindex 77328c5fd..aff8fcbd3 100644\n--- a/include/libcamera/ipa/soft.mojom\n+++ b/include/libcamera/ipa/soft.mojom\n@@ -17,7 +17,8 @@ interface IPASoftInterface {\n \t libcamera.SharedFD fdStats,\n \t libcamera.SharedFD fdParams,\n \t libcamera.IPACameraSensorInfo sensorInfo,\n-\t libcamera.ControlInfoMap sensorControls)\n+\t libcamera.ControlInfoMap sensorControls,\n+\t bool gpuIspEnabled)\n \t\t=> (int32 ret, libcamera.ControlInfoMap ipaControls, bool ccmEnabled);\n \tstart() => (int32 ret);\n \tstop();\ndiff --git a/src/ipa/simple/ipa_context.h b/src/ipa/simple/ipa_context.h\nindex 7837bb4dd..26db92e93 100644\n--- a/src/ipa/simple/ipa_context.h\n+++ b/src/ipa/simple/ipa_context.h\n@@ -105,6 +105,7 @@ struct IPAContext {\n \tFCQueue<IPAFrameContext> frameContexts;\n \tControlInfoMap::Map ctrlMap;\n \tbool ccmEnabled = false;\n+\tbool gpuIspEnabled = false;\n };\n \n } /* namespace ipa::soft */\ndiff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\nindex dde116661..57836c73c 100644\n--- a/src/ipa/simple/soft_simple.cpp\n+++ b/src/ipa/simple/soft_simple.cpp\n@@ -55,6 +55,7 @@ public:\n \t\t const SharedFD &fdParams,\n \t\t const IPACameraSensorInfo &sensorInfo,\n \t\t const ControlInfoMap &sensorControls,\n+\t\t bool gpuIspEnabled,\n \t\t ControlInfoMap *ipaControls,\n \t\t bool *ccmEnabled) override;\n \tint configure(const IPAConfigInfo &configInfo) override;\n@@ -95,6 +96,7 @@ int IPASoftSimple::init(const IPASettings &settings,\n \t\t\tconst SharedFD &fdParams,\n \t\t\tconst IPACameraSensorInfo &sensorInfo,\n \t\t\tconst ControlInfoMap &sensorControls,\n+\t\t\tbool gpuIspEnabled,\n \t\t\tControlInfoMap *ipaControls,\n \t\t\tbool *ccmEnabled)\n {\n@@ -106,6 +108,7 @@ int IPASoftSimple::init(const IPASettings &settings,\n \t}\n \n \tcontext_.sensorInfo = sensorInfo;\n+\tcontext_.gpuIspEnabled = gpuIspEnabled;\n \n \t/* Load the tuning data file */\n \tFile file(settings.configurationFile);\ndiff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex 5e837af4c..5a93442f8 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -121,14 +121,20 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n \t}\n \tstats->statsReady.connect(this, &SoftwareIsp::statsReady);\n \n+\tbool gpuIspEnabled;\n+\n #if HAVE_DEBAYER_EGL\n \tstd::optional<std::string> softISPMode = configuration.envOption(\"LIBCAMERA_SOFTISP_MODE\", { \"software_isp\", \"mode\" });\n \n-\tif (softISPMode && softISPMode == \"gpu\")\n+\tif (softISPMode && softISPMode == \"gpu\") {\n \t\tdebayer_ = std::make_unique<DebayerEGL>(std::move(stats), configuration);\n+\t\tgpuIspEnabled = true;\n+\t}\n #endif\n-\tif (!debayer_)\n+\tif (!debayer_) {\n \t\tdebayer_ = std::make_unique<DebayerCpu>(std::move(stats), configuration);\n+\t\tgpuIspEnabled = false;\n+\t}\n \n \tdebayer_->inputBufferReady.connect(this, &SoftwareIsp::inputReady);\n \tdebayer_->outputBufferReady.connect(this, &SoftwareIsp::outputReady);\n@@ -160,6 +166,7 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n \t\t\t sharedParams_.fd(),\n \t\t\t sensorInfo,\n \t\t\t sensor->controls(),\n+\t\t\t gpuIspEnabled,\n \t\t\t ipaControls,\n \t\t\t &ccmEnabled_);\n \tif (ret) {\n", "prefixes": [ "v11", "19/24" ] }