Patch Detail
Show a patch.
GET /api/1.1/patches/25595/?format=api
{ "id": 25595, "url": "https://patchwork.libcamera.org/api/1.1/patches/25595/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25595/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251217100138.82525-23-bryan.odonoghue@linaro.org>", "date": "2025-12-17T10:01:34", "name": "[v9,22/26] ipa: simple: Add a flag to indicate gpuIspEnabled", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "0c1bc586255c058c177ce219a907c9dbc875d561", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25595/mbox/", "series": [ { "id": 5669, "url": "https://patchwork.libcamera.org/api/1.1/series/5669/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5669", "date": "2025-12-17T10:01:12", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 9, "mbox": "https://patchwork.libcamera.org/series/5669/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25595/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25595/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8B6E2C3257\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 17 Dec 2025 10:02:26 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 24E9161F63;\n\tWed, 17 Dec 2025 11:02:26 +0100 (CET)", "from mail-wm1-x333.google.com (mail-wm1-x333.google.com\n\t[IPv6:2a00:1450:4864:20::333])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7DB7161A4B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 17 Dec 2025 11:02:10 +0100 (CET)", "by mail-wm1-x333.google.com with SMTP id\n\t5b1f17b1804b1-477aa218f20so37299185e9.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 17 Dec 2025 02:02:10 -0800 (PST)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-47bdc1583fbsm32292585e9.0.2025.12.17.02.02.08\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 17 Dec 2025 02:02:09 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"blwBRU2r\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1765965730; x=1766570530;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=vdieV2jp4Gung7/4hWVYp0Lav9rda27DBFfiiAcRIr4=;\n\tb=blwBRU2r7XJATb8u1M6QgZc+b9WalB40SwMqoj8T/LAWm+fnyFxzEXTBewaXVUqV4L\n\t62KWr08w3Pji/TOBVYqFhBiaP7BqPr1LLL1u0oNyS0O8TCaWD9vdHIMsqIy7XPfM4pHN\n\tqQ+6b/4QTt8iSjIti21SPCBXe5HBhpP3NhTAhWC8FPvh619VNgnt8LPdFGoWnqxFL5aD\n\trb0izc67QGuuGPkMGtF7AGduwK2tv8hCl1G8uy+vZOIbbf72a3pw2iegYT1Uqmu5UJmZ\n\tITzgVTkr7buNzieRogo96kVRV5STCjACLAS0KT++lDUAaabih7TcteRNIkesE2R+G/LE\n\tDuSA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765965730; x=1766570530;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=vdieV2jp4Gung7/4hWVYp0Lav9rda27DBFfiiAcRIr4=;\n\tb=NQfwpb1/F5GhDSYdKfVAQagxf4zqpiK6AHkathOWxVZ1eIkVsiWy7rOtDRW6wUk22j\n\t/rpkzMpU1Daj+6bMz8E7Ly9agOr8dFd3Z52kr5LnbkUGWgUWmdy8P0SuhGoqUwkK0NUu\n\trcK7RxthOr8e5idQsHcHSM7lIkfwVynB1yV/I25cjhOlUB9YFHw7uyG0MWu8O2GjDp+3\n\t6gIpIdaehaDSJ6pfzaE+c/2ttSEER8WNjmoeDZo+94oF3b39pBz+1z9rwDNIS+8+ExZ4\n\tukmT+U1hjT/fGzYGAAjvsNOkxXsOPpyIAexZTx6thA59EmXn/GzA6MpfqGm6IIHgFzvc\n\tOUvw==", "X-Gm-Message-State": "AOJu0Ywm0XI6nzFSI5wEJ9Sx9dpOvRUe2dO/lONetWjJgdLwnGO9zqNz\n\tVFeflM3akGrzf6aKTEn71bXpu694UmGnWrDsRMQFGNG2xeVzgL81AOAmhczIMAiIGJcLHqG+IAJ\n\txEIsN", "X-Gm-Gg": "AY/fxX6WM7Ns5Qk4Zgc/w8vraL+w7EzRi5XYDHYxExcZNsVFoJpQWlx8V18f7VW1JWL\n\t8b+gPJ3N1pzdc0CTxnKzcAqRnBCdft4lIsP1iCWRicQ8bFMsKOF0MQFIgLPY2erRFvgu+bc2o6w\n\tQ2UPvApD2u0utRRo8OaLBT4ojvi82wTrMfVNOWxGC1PGSYINByPeWKNHXfvkWId60DholCHix0y\n\tDI6W/klEtTx9vFtWZNLeLWiZpUhrU0+t78onBAX6WimjLGSPXp+N9Eo2t2kM++1B9YuLOOl7VNO\n\tQzJ7eo/VqU1dKxd5R+WqoWMnoYh4YFX56wtrrwPz55feurgDTgNkUvxUMdjdkjFuKK9bodbjFgU\n\t3Z+4SsxfZSimAzRu626MrsGMSUI8DA/Mav7pVAuQMS3URzzT+9Ymkl1fwKYYip0Z409LXQV87qO\n\tVwOwwbO9RPHEwKrmYnrlBEtpv9ooFrCn1bZ2gGhxf96jtyj0cJj2UD2ZoDa9ueaf1ws3bq5iaEI\n\tKs88A==", "X-Google-Smtp-Source": "AGHT+IEaVqNhnq8D117Qfkm3+apb0IZjEoM3nrxsjtOLpNIOZzK5kKo9L9LoSsDmbhqpL7wRX0bYKQ==", "X-Received": "by 2002:a05:600c:524b:b0:477:bb0:751b with SMTP id\n\t5b1f17b1804b1-47a8f90d716mr184082475e9.27.1765965729593; \n\tWed, 17 Dec 2025 02:02:09 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tMilan Zamazal <mzamazal@redhat.com>", "Subject": "[PATCH v9 22/26] ipa: simple: Add a flag to indicate gpuIspEnabled", "Date": "Wed, 17 Dec 2025 10:01:34 +0000", "Message-ID": "<20251217100138.82525-23-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20251217100138.82525-1-bryan.odonoghue@linaro.org>", "References": "<20251217100138.82525-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Flag gpuIspEnabled in the simple IPA context. This flag will allow to\nselectively avoid some calculations or to generate a default CCM.\n\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n include/libcamera/ipa/soft.mojom | 3 ++-\n src/ipa/simple/ipa_context.h | 1 +\n src/ipa/simple/soft_simple.cpp | 3 +++\n src/libcamera/software_isp/software_isp.cpp | 8 +++++++-\n 4 files changed, 13 insertions(+), 2 deletions(-)", "diff": "diff --git a/include/libcamera/ipa/soft.mojom b/include/libcamera/ipa/soft.mojom\nindex 77328c5fd..aff8fcbd3 100644\n--- a/include/libcamera/ipa/soft.mojom\n+++ b/include/libcamera/ipa/soft.mojom\n@@ -17,7 +17,8 @@ interface IPASoftInterface {\n \t libcamera.SharedFD fdStats,\n \t libcamera.SharedFD fdParams,\n \t libcamera.IPACameraSensorInfo sensorInfo,\n-\t libcamera.ControlInfoMap sensorControls)\n+\t libcamera.ControlInfoMap sensorControls,\n+\t bool gpuIspEnabled)\n \t\t=> (int32 ret, libcamera.ControlInfoMap ipaControls, bool ccmEnabled);\n \tstart() => (int32 ret);\n \tstop();\ndiff --git a/src/ipa/simple/ipa_context.h b/src/ipa/simple/ipa_context.h\nindex 03d8007ea..20c75de4e 100644\n--- a/src/ipa/simple/ipa_context.h\n+++ b/src/ipa/simple/ipa_context.h\n@@ -104,6 +104,7 @@ struct IPAContext {\n \tControlInfoMap::Map ctrlMap;\n \tbool ccmEnabled = false;\n \tbool selfInitialising = false;\n+\tbool gpuIspEnabled = false;\n };\n \n } /* namespace ipa::soft */\ndiff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\nindex b147aca2e..2bbe271d9 100644\n--- a/src/ipa/simple/soft_simple.cpp\n+++ b/src/ipa/simple/soft_simple.cpp\n@@ -55,6 +55,7 @@ public:\n \t\t const SharedFD &fdParams,\n \t\t const IPACameraSensorInfo &sensorInfo,\n \t\t const ControlInfoMap &sensorControls,\n+\t\t bool gpuIspEnabled,\n \t\t ControlInfoMap *ipaControls,\n \t\t bool *ccmEnabled) override;\n \tint configure(const IPAConfigInfo &configInfo) override;\n@@ -95,6 +96,7 @@ int IPASoftSimple::init(const IPASettings &settings,\n \t\t\tconst SharedFD &fdParams,\n \t\t\tconst IPACameraSensorInfo &sensorInfo,\n \t\t\tconst ControlInfoMap &sensorControls,\n+\t\t\tbool gpuIspEnabled,\n \t\t\tControlInfoMap *ipaControls,\n \t\t\tbool *ccmEnabled)\n {\n@@ -106,6 +108,7 @@ int IPASoftSimple::init(const IPASettings &settings,\n \t}\n \n \tcontext_.sensorInfo = sensorInfo;\n+\tcontext_.gpuIspEnabled = gpuIspEnabled;\n \n \t/* Load the tuning data file */\n \tFile file(settings.configurationFile);\ndiff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex 7fde57aec..5dbb0e3d6 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -121,6 +121,8 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n \t}\n \tstats->statsReady.connect(this, &SoftwareIsp::statsReady);\n \n+\tbool gpuIspEnabled;\n+\n #if HAVE_DEBAYER_EGL\n \tstd::optional<std::string> softISPMode = configuration.envOption(\"LIBCAMERA_SOFTISP_MODE\", { \"software_isp\", \"mode\" });\n \tif (softISPMode) {\n@@ -137,10 +139,13 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n \t\t\tLOG(SoftwareIsp, Error) << \"Failed to instantiate GPUISP\";\n \t\t\treturn;\n \t\t}\n+\t\tgpuIspEnabled = true;\n \t}\n #endif\n-\tif (!debayer_)\n+\tif (!debayer_) {\n \t\tdebayer_ = std::make_unique<DebayerCpu>(std::move(stats), configuration);\n+\t\tgpuIspEnabled = false;\n+\t}\n \n \tif (!debayer_) {\n \t\tLOG(SoftwareIsp, Error) << \"Failed to create Debayer object\";\n@@ -177,6 +182,7 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n \t\t\t sharedParams_.fd(),\n \t\t\t sensorInfo,\n \t\t\t sensor->controls(),\n+\t\t\t gpuIspEnabled,\n \t\t\t ipaControls,\n \t\t\t &ccmEnabled_);\n \tif (ret) {\n", "prefixes": [ "v9", "22/26" ] }