Patch Detail
Show a patch.
GET /api/1.1/patches/25591/?format=api
{ "id": 25591, "url": "https://patchwork.libcamera.org/api/1.1/patches/25591/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25591/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251217100138.82525-19-bryan.odonoghue@linaro.org>", "date": "2025-12-17T10:01:30", "name": "[v9,18/26] libcamera: software_isp: debayer_egl: Make gpuisp default softisp mode", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "4b3deb8e9a8a61532a512b6411bf0be2eb7e6938", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25591/mbox/", "series": [ { "id": 5669, "url": "https://patchwork.libcamera.org/api/1.1/series/5669/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5669", "date": "2025-12-17T10:01:12", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 9, "mbox": "https://patchwork.libcamera.org/series/5669/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25591/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25591/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0060EC3274\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 17 Dec 2025 10:02:20 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8AE3561E53;\n\tWed, 17 Dec 2025 11:02:20 +0100 (CET)", "from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com\n\t[IPv6:2a00:1450:4864:20::32d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 68FAD61D25\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 17 Dec 2025 11:02:05 +0100 (CET)", "by mail-wm1-x32d.google.com with SMTP id\n\t5b1f17b1804b1-47775fb6c56so43866705e9.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 17 Dec 2025 02:02:05 -0800 (PST)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-47bdc1583fbsm32292585e9.0.2025.12.17.02.02.03\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 17 Dec 2025 02:02:04 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"SmZJR3xo\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1765965725; x=1766570525;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=enuSJNXFUuoTYs1Tq2LkRLCCtdszeCb+2wiWiBmGXZE=;\n\tb=SmZJR3xoP1ShFvmRMRhOrovj7zQtpz7iZEn/JQM2gXuM7jc9hkIHK2NEzM9OR9h6Gp\n\tHLJkA4yBPfEaGEmLFILd8d6blPUmQhiH84aD2j96Oa228bKpPGcMpio84IJjLDI4HzqN\n\tmNpTOem0+oMO0gASFQHCLlxfFnb0VI9k0ye5S+YTxbaVkp18UQjM0XnHB6XCtwv63FDN\n\tu9iGR4fSSKTVWHvWYxA5E9bwStvaJVpLi3WRib+gjEqWqfB0aflGYpYS6zg5I9J0Xm5C\n\tx8PjX4PyYl7nhbI/hY6htuRLJg+CVF5tXFdq/KJuRvH+lsXInlsiVPvE66QsxQyoJjUA\n\tdXUw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765965725; x=1766570525;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=enuSJNXFUuoTYs1Tq2LkRLCCtdszeCb+2wiWiBmGXZE=;\n\tb=edAMR/mpYbxpOmkSzM4X3Cza/OyWlv1oNU9LR+TFl40s31xvowfS/mTJ4oJvMZuPnq\n\tL+dMhZlK3r1Rt2anGXGizWBlMFB4diNNvzKfrdjpj7gaSVIV9aBIbW2PGxX2LjokAEmB\n\tbf31AS+Y7wEuV8DQJ8yG9BHjymO4oVHvAm74uY4WrLok4lBkoSDLFCfrbJbRwZ6/BhqF\n\t6xs6C2VNyk7N53k6TjyX/LAz/gu6jO1bWR9kI5TLBb9hSqVW6bHcTAa0Tbb+0hke9qIw\n\tsAING9eoJeWofHh9+RGlDLAauAFHKiWrXO3pBuCCubtX/TVhXbNINGtNlxI+YoEdS07S\n\tJA0g==", "X-Gm-Message-State": "AOJu0YyhsdLDSWVVbV+v3zAhVzdFzc4oLVbwbkAPNk2EoCoSIBFyb6Kw\n\tcmn0nTb7GZB/lfUiRqfC3DVxur7gPxlpmI6xyj1K6RtllMpFth1n1UJuazpN+ORimJHPtj95N+v\n\tODcli", "X-Gm-Gg": "AY/fxX7m5qiQ183/5/Lznag8/NBO7OL8eSu5WmhPARy4mcnoaZdF5RSOgmbKT5SyZ4e\n\tUjkt15cnpY2EFXWFpQekqNBcSfukG2xHRbJ1ilgOsFWrHz6jvLE+tES7O1tJh5oAGpyC2Z+grgg\n\tW6EDifU8/Xskyebk89VrFsKWk5H28K+isrvr8CBmZtdx5zXRUj95QQ389UHyf+PP+5+An1Za1me\n\t2Bx8H7sYGvQ4sxDxf95c7r8QoGepE992dqmlXPa/dTyDKglERZMYiSnZnULzNQ8Ry6oaZE01N/L\n\tyUYX523CfNs9EtxUgGsHC+4j9u1mB7lciGR9SFv4jOIOBO01DBbku67/A4/MQgkRnLkaWlxrdmN\n\tjwjWoAm8aFbgSJ0USRRppmSptb6uc+GMjGeu9o+jhUwXLssrpm8jntpJu8RU3m0DO4cA8Pfa0/Z\n\tklRjc26x2mK3ro8FebM1BF0SKL8lVAnWZxYBneoabVS/G4dcsWM1WXXCgRWqg7OcoJH1sEGimus\n\tPPyxw==", "X-Google-Smtp-Source": "AGHT+IGIl6zDPcaMabha87p4zxnchXK2Md3KfugTXh6klJNVTsZH2VgWQOQ+SZkoU8GD8kuAlnM5mQ==", "X-Received": "by 2002:a05:600c:4e56:b0:477:569c:34e9 with SMTP id\n\t5b1f17b1804b1-47a8f906ddemr168578565e9.23.1765965724563; \n\tWed, 17 Dec 2025 02:02:04 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tMilan Zamazal <mzamazal@redhat.com>", "Subject": "[PATCH v9 18/26] libcamera: software_isp: debayer_egl: Make gpuisp\n\tdefault softisp mode", "Date": "Wed, 17 Dec 2025 10:01:30 +0000", "Message-ID": "<20251217100138.82525-19-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20251217100138.82525-1-bryan.odonoghue@linaro.org>", "References": "<20251217100138.82525-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In some cases the GPU can deliver 15x performance in Debayer with the\nCCM on, reference hardware Qualcomm RB5 with IMX512 sensor.\n\nGiven this large performance difference it makes sense to make GPUISP\nthe default for the Software ISP.\n\nIf LIBCAMERA_SOFTISP_MODE is omitted gpu will be the default. If\nlibcamera is compiled without gpuisp support, CPU Debayer will be used.\n\nIt is still possible to select CPU mode with LIBCAMERA_SOFISP_MODE=cpu.\n\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/software_isp.cpp | 9 ++++++++-\n 1 file changed, 8 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex efe44e393..7fde57aec 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -123,8 +123,15 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n \n #if HAVE_DEBAYER_EGL\n \tstd::optional<std::string> softISPMode = configuration.envOption(\"LIBCAMERA_SOFTISP_MODE\", { \"software_isp\", \"mode\" });\n+\tif (softISPMode) {\n+\t\tif (softISPMode != \"gpu\" && softISPMode != \"cpu\") {\n+\t\t\tLOG(SoftwareIsp, Error) << \"LIBCAMERA_SOFISP_MODE \" << softISPMode.value() << \" invalid \"\n+\t\t\t\t\t\t<< \"must be \\\"cpu\\\" or \\\"gpu\\\"\";\n+\t\t\treturn;\n+\t\t}\n+\t}\n \n-\tif (softISPMode && softISPMode == \"gpu\") {\n+\tif (!softISPMode || softISPMode == \"gpu\") {\n \t\tdebayer_ = std::make_unique<DebayerEGL>(std::move(stats), configuration);\n \t\tif (!debayer_) {\n \t\t\tLOG(SoftwareIsp, Error) << \"Failed to instantiate GPUISP\";\n", "prefixes": [ "v9", "18/26" ] }