Patch Detail
Show a patch.
GET /api/1.1/patches/25585/?format=api
{ "id": 25585, "url": "https://patchwork.libcamera.org/api/1.1/patches/25585/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25585/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251217100138.82525-13-bryan.odonoghue@linaro.org>", "date": "2025-12-17T10:01:24", "name": "[v9,12/26] libcamera: software_isp: Add member variables to track selected input/output pixelFormat", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "9106c70efb4f03583672baa81867a12f133e20d4", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25585/mbox/", "series": [ { "id": 5669, "url": "https://patchwork.libcamera.org/api/1.1/series/5669/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5669", "date": "2025-12-17T10:01:12", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 9, "mbox": "https://patchwork.libcamera.org/series/5669/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25585/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25585/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 27B16C326C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 17 Dec 2025 10:02:12 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6102661F2F;\n\tWed, 17 Dec 2025 11:02:11 +0100 (CET)", "from mail-wm1-x334.google.com (mail-wm1-x334.google.com\n\t[IPv6:2a00:1450:4864:20::334])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1C08361A54\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 17 Dec 2025 11:01:57 +0100 (CET)", "by mail-wm1-x334.google.com with SMTP id\n\t5b1f17b1804b1-477770019e4so51940615e9.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 17 Dec 2025 02:01:57 -0800 (PST)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-47bdc1583fbsm32292585e9.0.2025.12.17.02.01.55\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 17 Dec 2025 02:01:55 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"bhaxPWGX\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1765965716; x=1766570516;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=AkHDdjGVPAipGQD5NCfZ9IhKGBJlwJpwDuA7iC3dtE0=;\n\tb=bhaxPWGXx51WS96SOb0NzKb1KgKjU+lqRz/zAYuisG3TCqqrfa/fGh2V8Hso+XyxvW\n\t3HQ8DcZsCTKDEYVCmcd6G5Zqe6SLwMHjB35jz9trS3qnnzd8yon1Ze1+BKMc6nLW//i+\n\tZ2n5mmya3byNNcaRb7oGwVNhEhDbqnfydlOVHAUHXbCbV3arE6Nj31ljAD8SoOr3J+Ky\n\trHR9kNFAO2ZZhpUg4vSezXy2O/FukJa6HmEPXpPegQQJo9YMYlsuWAFAqyZwsKxHbBEs\n\t52ZXHQFhdYyTuWNYvUKDiGQZHKBH6cLSk4VBxCAtRRkmDWUkq7Gxjut3KAInZqfQuWWP\n\t/VEg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765965716; x=1766570516;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=AkHDdjGVPAipGQD5NCfZ9IhKGBJlwJpwDuA7iC3dtE0=;\n\tb=jkov0gSkBYam/kEmkGl3p2rP6jeh2EWJb7h9NmRaW8gT+i401IJG4CEsmP6qvBozdi\n\tPPn5z9qChCqZFL9VN4KTegRbU8xipBVktTlJ390VO19TCVVSxOVbc+cPQle/10PNWUMk\n\tUsIbxFNFf0MUf8tARh1IIG63S8tSTcm4X4LjkoHouhY+hqmYBoq0IAOzwZJvXRdLYwyO\n\tthGAE8+LkSl7HxmuSadInXRFdhJ0HmoQBJu5KUftwJcDWkJxHOTOhgFAaXOQre6Bc/Or\n\t0St2Dj1U+9P2hbpOgnBbLTwTQvXSXSl02Jt/SbGutITbUoGqfQSt2HDfgt0zM8LeS2Zb\n\t36Cg==", "X-Gm-Message-State": "AOJu0YyDNfxwnnb/iNKCbg613KRlfIVgWYHh1Q6EHPe4a1hbx+izh1CV\n\tmO2EaATuUfTOiqNh8slHGY06SfVjdaNF6rvIPHKEVHjN+eyn6WETKKZbU3A1AxL9s3XPYPWW+4F\n\tIJ/w2", "X-Gm-Gg": "AY/fxX4BaODmVnJDmWqCi7/Ojd+5o1PkLB3IWJyeEX5b9kMuCoqbzVt4NJHZy211tKz\n\thUxnaaR676QQDjEzD6sMyS6BtMr10W+RppDXswqcxQ4aiwDFUqLnnxcd2wAmJL76LZNS6rFAq5c\n\txqtuiPFxVdZkp4DHxwWIoHBA/A46GAsBB0/DGCJt0xndWo5COt6Nbq/GPmDHr+s0fqP8zmXpvVA\n\t6I8puZbA2jGaEqPpT5MkzHYmzpRE3egLd9pT6l5Ddyko0Np3IVQovG9y51ld9EhURJAEeKypLMj\n\tS756D5pz3cgTQWYdpMsJ3ii+A9vRj9WBtmUH+oq0657yjbJOiog8Cbo4kwugZc60ATL9Y2dksYS\n\tN+JTTR99j6GvUwLYKN6sT67hvi+V4e5v3MpcyczBOvUprHjEQ6WqEg979x/PvUiQb2AnA3RIgrc\n\tvZgOwDm8U9vbn5dKYRvYzD1rC1aTxBGSFIHr7uX5miDpzcKBqcMuU+OOLXXrWrNWZCR2I=", "X-Google-Smtp-Source": "AGHT+IET7iFn7+qGYixQava9cJ1Oxff86MzCUZa5y3Azn07CzsyUquv6IUkCmGxOo95XRsyLySLe3g==", "X-Received": "by 2002:a05:600c:6290:b0:477:76bf:e1fb with SMTP id\n\t5b1f17b1804b1-47a8f8cdfd1mr230766945e9.16.1765965716350; \n\tWed, 17 Dec 2025 02:01:56 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tMilan Zamazal <mzamazal@redhat.com>", "Subject": "[PATCH v9 12/26] libcamera: software_isp: Add member variables to\n\ttrack selected input/output pixelFormat", "Date": "Wed, 17 Dec 2025 10:01:24 +0000", "Message-ID": "<20251217100138.82525-13-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20251217100138.82525-1-bryan.odonoghue@linaro.org>", "References": "<20251217100138.82525-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In order to have Debayer::start() tell the eGL shader compilation routine what\nthe input and output pixel format is, we need to have a copy of the\nselected format available. Add variables to the inputConfig and\noutputConfig structures to allow tracking of this data for later use.\n\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/debayer.cpp | 10 ++++++++++\n src/libcamera/software_isp/debayer.h | 2 ++\n 2 files changed, 12 insertions(+)", "diff": "diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp\nindex b33f818a7..4645b6a1b 100644\n--- a/src/libcamera/software_isp/debayer.cpp\n+++ b/src/libcamera/software_isp/debayer.cpp\n@@ -290,6 +290,16 @@ Debayer::~Debayer()\n * output image buffer. Set during stream configuration.\n */\n \n+/**\n+ * \\var Debayer::inputPixelFormat_\n+ * \\brief The incoming pixel format\n+ */\n+\n+/**\n+ * \\var Debayer::outputPixelFormat_\n+ * \\brief The output pixel format\n+ */\n+\n /**\n * \\var Debayer::red_\n * \\brief Lookup table for red channel gain and correction values\ndiff --git a/src/libcamera/software_isp/debayer.h b/src/libcamera/software_isp/debayer.h\nindex b8287166e..d716ad080 100644\n--- a/src/libcamera/software_isp/debayer.h\n+++ b/src/libcamera/software_isp/debayer.h\n@@ -75,6 +75,8 @@ public:\n \n \tDebayerInputConfig inputConfig_;\n \tDebayerOutputConfig outputConfig_;\n+\tPixelFormat inputPixelFormat_;\n+\tPixelFormat outputPixelFormat_;\n \tDebayerParams::LookupTable red_;\n \tDebayerParams::LookupTable green_;\n \tDebayerParams::LookupTable blue_;\n", "prefixes": [ "v9", "12/26" ] }