Patch Detail
Show a patch.
GET /api/1.1/patches/25566/?format=api
{ "id": 25566, "url": "https://patchwork.libcamera.org/api/1.1/patches/25566/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25566/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251215200614.41329-1-kieran.bingham@ideasonboard.com>", "date": "2025-12-15T20:06:14", "name": "ipa: simple: awb: Fix ColourGains reported", "commit_ref": "e4a4eb0a94a14c2fb5c96d707ed39220f4be9ceb", "pull_url": null, "state": "accepted", "archived": false, "hash": "54ccff71488a9d7f3692bb67e407dd5e623a057d", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25566/mbox/", "series": [ { "id": 5666, "url": "https://patchwork.libcamera.org/api/1.1/series/5666/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5666", "date": "2025-12-15T20:06:14", "name": "ipa: simple: awb: Fix ColourGains reported", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5666/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25566/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25566/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F22D0BD7D8\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 15 Dec 2025 20:06:23 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 05617619D0;\n\tMon, 15 Dec 2025 21:06:23 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C8B15615B2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 15 Dec 2025 21:06:21 +0100 (CET)", "from charm.hippo-penny.ts.net\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 48C644F1;\n\tMon, 15 Dec 2025 21:06:16 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BjOy1QJb\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1765829176;\n\tbh=GLfRIK+ZLs0vAO3S4yDdm6MKTBj7VlruDi2GmoT/oPM=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=BjOy1QJbK+Ri/krpwKB3hECVbsnuBIDMcUnvsnNXR+ksXUxjZP1REhw+Qor0eQxHI\n\tGeLdTuKnQvHOu9hBCtk1UVmbGjNesCWsh8Z9En2/xX8Kv3YbpvY07a4/Pinkj93s8+\n\tyJvqBfjUT81DUPdJAMvJ50EZnvu9283vi1bFoPN8=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Cc": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH] ipa: simple: awb: Fix ColourGains reported", "Date": "Mon, 15 Dec 2025 20:06:14 +0000", "Message-ID": "<20251215200614.41329-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.52.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The AWB gains reported in the metadata are currently scaled against the\nmaximum gain, but in fact the gain itself is already stored as a\nfloating point gain value.\n\nRemove the incorrect scaling and report the gains directly.\n\nFixes: a0b97475b1c0 (\"ipa: simple: Report the ColourGains in metadata\")\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/simple/algorithms/awb.cpp | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/ipa/simple/algorithms/awb.cpp b/src/ipa/simple/algorithms/awb.cpp\nindex cf78e980098b..0080865aa34d 100644\n--- a/src/ipa/simple/algorithms/awb.cpp\n+++ b/src/ipa/simple/algorithms/awb.cpp\n@@ -55,10 +55,9 @@ void Awb::process(IPAContext &context,\n \tconst SwIspStats::Histogram &histogram = stats->yHistogram;\n \tconst uint8_t blackLevel = context.activeState.blc.level;\n \n-\tconst float maxGain = 1024.0;\n \tconst float mdGains[] = {\n-\t\tstatic_cast<float>(frameContext.gains.red / maxGain),\n-\t\tstatic_cast<float>(frameContext.gains.blue / maxGain)\n+\t\tstatic_cast<float>(frameContext.gains.red),\n+\t\tstatic_cast<float>(frameContext.gains.blue)\n \t};\n \tmetadata.set(controls::ColourGains, mdGains);\n \n", "prefixes": [] }