Patch Detail
Show a patch.
GET /api/1.1/patches/25556/?format=api
{ "id": 25556, "url": "https://patchwork.libcamera.org/api/1.1/patches/25556/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25556/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251215093719.574058-1-barnabas.pocze@ideasonboard.com>", "date": "2025-12-15T09:37:19", "name": "[libcamera-ci,v1] Add job to build libcamera as subproject", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "0710107f94f5200c912ef58dae1f1d16aa116919", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/1.1/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25556/mbox/", "series": [ { "id": 5662, "url": "https://patchwork.libcamera.org/api/1.1/series/5662/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5662", "date": "2025-12-15T09:37:19", "name": "[libcamera-ci,v1] Add job to build libcamera as subproject", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5662/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25556/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25556/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CFAF3C3257\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 15 Dec 2025 09:37:24 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 79F1761960;\n\tMon, 15 Dec 2025 10:37:24 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4F965606D5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 15 Dec 2025 10:37:22 +0100 (CET)", "from pb-laptop.local (185.221.143.114.nat.pool.zt.hu\n\t[185.221.143.114])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8FF05EB4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 15 Dec 2025 10:37:17 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OzsuJN4T\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1765791437;\n\tbh=PzYvW5tEs/MQQF/Q70nnlDn2rqKwanipZNyN1gvyorI=;\n\th=From:To:Subject:Date:From;\n\tb=OzsuJN4TeuGDXHcKkHr3TxmpnhKazc9RemiIgWg0BOvNrEcFEhYrobP6W47uN1dac\n\t6jD3kmMuLkSUiHzMCptNuSeZ7SO8edxVQuW29oXLNSy+W/4KIq+psHjb3vwaNP2hk+\n\tcipiQN/a5f1c3RyiwXQQkrjxwOGp69F+J9JyPoxY=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[libcamera-ci] [PATCH v1] Add job to build libcamera as subproject", "Date": "Mon, 15 Dec 2025 10:37:19 +0100", "Message-ID": "<20251215093719.574058-1-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.52.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Building libcamera as a meson subproject is currently not well tested,\nand it is a good way to confirm that no improper assumptions are made\nabout where and how commands run, and to test any kind of path\nmanipulation happening during the build.\n\nSo add a job that builds libcamera as a subproject.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n .gitlab-ci/build-libcamera-subproject.sh | 59 ++++++++++++++++++++++++\n gitlab-ci.yml | 24 ++++++++++\n 2 files changed, 83 insertions(+)\n create mode 100755 .gitlab-ci/build-libcamera-subproject.sh\n\n--\n2.52.0", "diff": "diff --git a/.gitlab-ci/build-libcamera-subproject.sh b/.gitlab-ci/build-libcamera-subproject.sh\nnew file mode 100755\nindex 0000000..ae59ac3\n--- /dev/null\n+++ b/.gitlab-ci/build-libcamera-subproject.sh\n@@ -0,0 +1,59 @@\n+#!/bin/bash\n+\n+# SPDX-License-Identifier: GPL-2.0-or-later\n+# SPDX-FileCopyrightText: © 2025 Ideas on Board Oy\n+#\n+# Build libcamera as a meson subproject\n+\n+set -e\n+\n+source \"$(dirname \"$0\")/lib.sh\"\n+source \"$(dirname \"$0\")/build-libcamera-common.sh\"\n+\n+PROJECT_ROOT=$(mktemp -d ./subproject-test.XXXXXX)\n+\n+libcamera_setup_as_subproject() {\n+\techo \"Setting up libcamera build with meson options $MESON_OPTIONS\"\n+\n+\tmkdir -p \"$PROJECT_ROOT/subprojects\"\n+\tln -s ../../ \"$PROJECT_ROOT/subprojects/libcamera\"\n+\n+\t# Convert options suitable for the `default_options` parameter of `subproject()`\n+\techo \"$MESON_OPTIONS\" \\\n+\t\t| sed 's/-D[[:space:]]*//g' \\\n+\t\t| tr ' ' '\\n' \\\n+\t\t| sed \"s/'/\\\"/g\" \\\n+\t\t| sed \"s/^\\(.*\\)$/\\t\\t'\\1',/\" \\\n+\t\t> \"$PROJECT_ROOT/meson-options\"\n+\n+\tcat > \"$PROJECT_ROOT/meson.build\" <<EOF\n+project('libcamera-as-subproject-test')\n+subproject(\n+\t'libcamera',\n+\tdefault_options : [\n+EOF\n+\tcat \"$PROJECT_ROOT/meson-options\" >> \"$PROJECT_ROOT/meson.build\"\n+\tcat >> \"$PROJECT_ROOT/meson.build\" <<EOF\n+\t],\n+)\n+EOF\n+\n+\tcat \"$PROJECT_ROOT/meson.build\"\n+\n+\tmeson setup build \"$PROJECT_ROOT\" \\\n+\t\t--wrap-mode=nofallback \\\n+\t\t-D buildtype=$BUILD_TYPE\n+}\n+\n+libcamera_build_as_subproject() {\n+\techo \"Building libcamera as subproject\"\n+\n+\tmeson compile \\\n+\t\t-C build \\\n+\t\t-j$BUILD_CONCURRENT_JOBS \\\n+\t\t--ninja-args=\"-k0\"\n+}\n+\n+run libcamera_install_pkgs\n+run libcamera_setup_as_subproject\n+run libcamera_build_as_subproject collapsed\ndiff --git a/gitlab-ci.yml b/gitlab-ci.yml\nindex c751973..fd837f5 100644\n--- a/gitlab-ci.yml\n+++ b/gitlab-ci.yml\n@@ -212,6 +212,30 @@ build-full:debian:12:\n - ARCH: armhf\n - ARCH: arm64\n\n+build-full:debian:12:as-subproject:\n+ extends:\n+ - .fdo.distribution-image@debian\n+ - .libcamera-ci.debian:12\n+ - .libcamera-ci.scripts\n+ variables:\n+ BUILD_TYPE: debug\n+ MESON_OPTIONS: >-\n+ ${MESON_ALL_OPTIONS}\n+ -D documentation=enabled\n+ needs:\n+ - job: container-debian:12\n+ artifacts: false\n+ stage: build\n+ script:\n+ - $CI_PROJECT_DIR/.gitlab-ci/build-libcamera-subproject.sh\n+ artifacts:\n+ when: always\n+ expire_in: 1 week\n+ paths:\n+ - build/meson-logs/\n+ - build/meson-intro/\n+ - build/build.ninja\n+\n build-full:debian:13:\n extends:\n - .libcamera-ci.debian:13\n", "prefixes": [ "libcamera-ci", "v1" ] }