Patch Detail
Show a patch.
GET /api/1.1/patches/25522/?format=api
{ "id": 25522, "url": "https://patchwork.libcamera.org/api/1.1/patches/25522/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25522/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251212002937.3118-8-bryan.odonoghue@linaro.org>", "date": "2025-12-12T00:29:18", "name": "[v8,07/26] libcamera: shaders: Extend bayer shaders to support swapping R and B on output", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "c8fe7f0d90359367374670fccaad26c63fe1bcac", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25522/mbox/", "series": [ { "id": 5657, "url": "https://patchwork.libcamera.org/api/1.1/series/5657/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5657", "date": "2025-12-12T00:29:11", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 8, "mbox": "https://patchwork.libcamera.org/series/5657/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25522/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25522/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D757DBD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 12 Dec 2025 00:33:47 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8F4FD61661;\n\tFri, 12 Dec 2025 01:33:47 +0100 (CET)", "from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com\n\t[IPv6:2607:f8b0:4864:20::42e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9E8776165B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 12 Dec 2025 01:33:45 +0100 (CET)", "by mail-pf1-x42e.google.com with SMTP id\n\td2e1a72fcca58-7aad4823079so642682b3a.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 11 Dec 2025 16:33:45 -0800 (PST)", "from inspiron14p-linux (p99250-ipoefx.ipoe.ocn.ne.jp.\n\t[153.246.134.249]) by smtp.gmail.com with ESMTPSA id\n\t41be03b00d2f7-c0c26eb0f6bsm3317282a12.14.2025.12.11.16.33.40\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 11 Dec 2025 16:33:43 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"qKIsKf+i\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1765499624; x=1766104424;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=nAlpCB4iJopL0Pn768w20N/UlmcrQmnghUNHBy8yJOY=;\n\tb=qKIsKf+i+6t98BJGQ9XM324UX7KPA9IMCHU2ugfZnVxoNAoKWACOu2eYC5mkxhkF0i\n\tG0SWwXq/E5Y9WVU1aPqvfICjnaKNeijczSgipk/40KFnNW2ESSlkzsIbyNGjZpZSPiaW\n\tqS37lYhBMKcvV6U9TLry/BJx0eRWLPNd2NeDgOBy3ZNk1Ekt/YyqtxUp3PmEQs9ERcqZ\n\tB2vzHt7evW2aL9Vr5gvdPnHd6xLkRiG2IZmDfi4TRvOJEhtar+g+9mmCqkLnsRFySQY+\n\tLGYPSmy3wkOd8c28QzXlgZCl/7xeKY8GNi09oNTIZOgr9N7SLPLM+YIDnkhPizgo9oA9\n\tdj0Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765499624; x=1766104424;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=nAlpCB4iJopL0Pn768w20N/UlmcrQmnghUNHBy8yJOY=;\n\tb=laxaLOmzHHvcnbSF3doSV064FmtrSyVeBIYtsmgo4wwgQwE9cW4iAWz4qVBFcZEyg2\n\tIZmU6eKMvA02Qcmv/jydiCxTrzHZXO9g5IpK9pLwuECLQC0BFl6Q/g7ckPbnNW3byyYq\n\t41jVTdgjrzpVU/2XkY0MXwQM+G0hiB1SR0+ojPnOURTt/E0ji4x486jku3dFRB7n5Aud\n\tJPfmZJHm6WZC8uCzpOEErZN12UXo7/nHkwH/6l7NbpctYGh3dwCXb2snz7++jtxUpf96\n\tixSOwKkCvQNbEAi4yDdMzKylksrI8rgNpv61luRqzsQSxVds5ztuykXjk0vZrkJi3UjN\n\tSMNg==", "X-Gm-Message-State": "AOJu0YyUBkHKoOlhMOX/ZI/1z+RhAqmME4CUnUE1D7w0ssrIZZPACWNi\n\tSR8QxbfD8O4g+7akr/lt5QSOv4U46xLM9VHMV01bUYybBQkKnAkJOlpGioJPv31RQum4k/+971f\n\tkdeJY", "X-Gm-Gg": "AY/fxX5q3d7zP7a06yDPfdQ6nzYpZ7KfT7Rv7+OB6c0tqgq0iLjK7yx48V9cOzNm4tS\n\t6iOs3dsKAc7hubT1hxAP4rVw3tAm5SMoW7TeL7z1BjYE4b2+4kfLX2+ZBkd2eAR+M2fjvkCr070\n\t5goDiUFy3T5r6I4kvoDy9L3NWvtzWAJ8jps/MJ0Qe8Z2WobdTUAvigZ5sHZB+0u6zAL67lybHYw\n\ts2/tBv94ssDfi4YvGrVMvS+87W1UNStWojQ7u9x5WJfa1lbUZY4vIpJES0kvZNz1cmfWehqXjjZ\n\tN1DzDrDWPecllgbdC28xA68mPwmAsvPwiz6EQCgR9Ov23Fc5B8QcFnijcAWTfbqKIU5qfbEIkYB\n\tWV9YVjhyMfCOVgnvkrH+qpo8NihXaM2xJxjDonJf/NImnff5d83qqVMNfnVFEKST+B/jKPY+4ui\n\t6593vFp+kFMCWDb4H+xtliR7EQ2VP/efcezNhUPYXNMDCecBO0afN4i73HwHlMtyv7aQunOQ==", "X-Google-Smtp-Source": "AGHT+IFc8ID1slBJEexswPI4ub811riWu1VP8BCHRvkdXDoJ4+4I+uKCLTazKZe3pADWjjXzxtW5Vw==", "X-Received": "by 2002:a05:6a21:339f:b0:366:5c4a:c49c with SMTP id\n\tadf61e73a8af0-369af33590fmr300568637.41.1765499623922; \n\tThu, 11 Dec 2025 16:33:43 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tMilan Zamazal <mzamazal@redhat.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v8 07/26] libcamera: shaders: Extend bayer shaders to support\n\tswapping R and B on output", "Date": "Fri, 12 Dec 2025 00:29:18 +0000", "Message-ID": "<20251212002937.3118-8-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20251212002937.3118-1-bryan.odonoghue@linaro.org>", "References": "<20251212002937.3118-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "We can easily facilitate swapping R and B on output. Pivot on an\nenvironment define for this purpose.\n\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nAcked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/shaders/bayer_1x_packed.frag | 4 ++++\n src/libcamera/shaders/bayer_unpacked.frag | 6 +++++-\n 2 files changed, 9 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/shaders/bayer_1x_packed.frag b/src/libcamera/shaders/bayer_1x_packed.frag\nindex 171a928c2..db8c2a0b3 100644\n--- a/src/libcamera/shaders/bayer_1x_packed.frag\n+++ b/src/libcamera/shaders/bayer_1x_packed.frag\n@@ -257,5 +257,9 @@ void main(void)\n \trgb.g = (rin * ccm[1][0]) + (gin * ccm[1][1]) + (bin * ccm[1][2]);\n \trgb.b = (rin * ccm[2][0]) + (gin * ccm[2][1]) + (bin * ccm[2][2]);\n \n+#if defined (SWAP_BLUE)\n+\tgl_FragColor = vec4(rgb.bgr, 1.0);\n+#else\n \tgl_FragColor = vec4(rgb, 1.0);\n+#endif\n }\ndiff --git a/src/libcamera/shaders/bayer_unpacked.frag b/src/libcamera/shaders/bayer_unpacked.frag\nindex c41d72f4f..06d80f3dd 100644\n--- a/src/libcamera/shaders/bayer_unpacked.frag\n+++ b/src/libcamera/shaders/bayer_unpacked.frag\n@@ -152,5 +152,9 @@ void main(void) {\n rgb.g = (rin * ccm[1][0]) + (gin * ccm[1][1]) + (bin * ccm[1][2]);\n rgb.b = (rin * ccm[2][0]) + (gin * ccm[2][1]) + (bin * ccm[2][2]);\n \n- gl_FragColor.rgb = rgb;\n+#if defined (SWAP_BLUE)\n+ gl_FragColor = vec4(rgb.bgr, 1.0);\n+#else\n+ gl_FragColor = vec4(rgb, 1.0);\n+#endif\n }\n", "prefixes": [ "v8", "07/26" ] }