Patch Detail
Show a patch.
GET /api/1.1/patches/25514/?format=api
{ "id": 25514, "url": "https://patchwork.libcamera.org/api/1.1/patches/25514/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25514/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251211232246.31330-21-bryan.odonoghue@linaro.org>", "date": "2025-12-11T23:22:45", "name": "[v5,20/20] libcamera: software_isp: lut: Make contrast available in debayer params", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "83993195e06b0449ff8570fc403c27b5cf696655", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25514/mbox/", "series": [ { "id": 5656, "url": "https://patchwork.libcamera.org/api/1.1/series/5656/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5656", "date": "2025-12-11T23:22:25", "name": "GPUISP precursor series", "version": 5, "mbox": "https://patchwork.libcamera.org/series/5656/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25514/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25514/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BF996C3257\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 11 Dec 2025 23:24:21 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7BE6C616AB;\n\tFri, 12 Dec 2025 00:24:21 +0100 (CET)", "from mail-pf1-x433.google.com (mail-pf1-x433.google.com\n\t[IPv6:2607:f8b0:4864:20::433])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6511861623\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 12 Dec 2025 00:24:19 +0100 (CET)", "by mail-pf1-x433.google.com with SMTP id\n\td2e1a72fcca58-7aa2170adf9so564782b3a.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 11 Dec 2025 15:24:19 -0800 (PST)", "from inspiron14p-linux (M106185144161.v4.enabler.ne.jp.\n\t[106.185.144.161]) by smtp.gmail.com with ESMTPSA id\n\td2e1a72fcca58-7f4c4ab52aasm3399933b3a.38.2025.12.11.15.24.15\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 11 Dec 2025 15:24:17 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"HEYDkPdS\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1765495458; x=1766100258;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=rcK4g8w70ZrNIJtUf3jJQYX0oOGoIStom0aO1MEkaxk=;\n\tb=HEYDkPdS3oFWzY6eVtASaWmEV6/86HiYeIfhAkWgajzJGKCoeFP6NFl/LeHVsJLQQv\n\tBBdh3ussAI443plOpgdQaanrwyw0st0/nxLOJT3eigG4JOxpCIlY3baj++8F/+KIiMT7\n\tQF2ZwOArc2BKnud59TeuXbK8gT7mKCbaRgvunZx8EfxrQSXz5Lc3syqppSDc447nqXH1\n\tbj4APDGiwQa/k3P6mu/o8ymfUIJsPpf+9yB2pF0LWhPF0O+GBWsvXZfl6Svl5M68b50X\n\tFrDzsBFTlz4UfZ/DCOFUJT4aDOqxVPcKbMv+3mgi+HmfzLKsfFZtlnCfcr5j0KNjX/HK\n\tCEUA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765495458; x=1766100258;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=rcK4g8w70ZrNIJtUf3jJQYX0oOGoIStom0aO1MEkaxk=;\n\tb=a0sxG3uBMiMqfnId93EV8ET22AwJFabQkqiMpwWf85jgYH+PANBNaJsoJJVnQcALd3\n\to8+Y1Vm1FS0qztsDZaJgWj7tNdhzlpo+sazZRZH+Jo9Fzyzncjd9UmqgDAyOkOj1L6j9\n\tN9ZN9hofbE16LPh+lbayLT4C4Mw/aQsI3ENGQW3ZNEYRFve8tEHO0r+OB/r+02OKMGIM\n\tzDrmOHII+5wbw+BcUE/Br8JMtwImUXrXIUi8mawbFbRu28aGSun0VN02HpkMiFhI6afE\n\tmyXBtED36M+lSglQ/6kEAKVDvDEgnbANJVzQlu5GV1JKhanec4rIgBA+OhLhba3Nr4q4\n\t5g7w==", "X-Gm-Message-State": "AOJu0Yz/myop2+X0ar2nufENBPK9aLDUzMu0nqJxTunb6sUbciVxBm6n\n\tkmZuuwicQ6/W0Ke5jBRM5HDSQmE+Q/soCbgCG527xjV7ky7UPYBN13TqG86Jkbl9IGNGz7m/Ikp\n\tTBRkt", "X-Gm-Gg": "AY/fxX4VTi2WCBGTsETc42FTjl2GR2J+m67qKjJbBUCgT5uOXJu19dkYSdq3NCe7cw7\n\tQWHwUYDsQnJ04gPf41KSNjNazhBrx2tt35pCtmHEoMy37s5H9mULSLwAxiYkFnd500oTnwJPo4y\n\tmUHfDrAWRsWkp9WQHq50CnOVGv2PrgX5qjXaQ2txYW9++QEDhveQTssr9bJ/OxQfYKbPfvl4Fi7\n\t+MKL55AM4tdijpfF3L/szxyMffhm3vLRTjUxxbWX7NGt2TmDixcPw1eLWt4bc5BIUIgw0a4vFMX\n\tmhVlNbgoYlQlmH3oeLBpgP7noBTy2PbkShS4oefklB1xEGsiFWMvaasu6v7Ub3KfPv4iFMv0Yle\n\t2efpSGAD7X2DirY4RE1PczPpVFTw6Xp6X1H4W+BSW9tOupDFpT2knOSHQ+eFQkt7oXvs+daSa3w\n\tPDpIZpXkaeOPzs3jBXJFXxytkyB00x+kR4VHSlYLSs3JcY6dpum7rbBKRhpFaOAA==", "X-Google-Smtp-Source": "AGHT+IEgYOM/qqkIbnrVqlL4hRP4YxhD3ycJ03XZJgc1WaVZDRloWeQI7UUtflkrfMzCS0zmpl0sdg==", "X-Received": "by 2002:a05:6a00:368c:b0:7e8:43f5:bd36 with SMTP id\n\td2e1a72fcca58-7f6692aaca9mr203827b3a.34.1765495457774; \n\tThu, 11 Dec 2025 15:24:17 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tMilan Zamazal <mzamazal@redhat.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v5 20/20] libcamera: software_isp: lut: Make contrast\n\tavailable in debayer params", "Date": "Thu, 11 Dec 2025 23:22:45 +0000", "Message-ID": "<20251211232246.31330-21-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20251211232246.31330-1-bryan.odonoghue@linaro.org>", "References": "<20251211232246.31330-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Provide the contrast used in IPA to Bayer parameters. Similar to the\ncalculated Gamma value we will pass this value into the debayer fragment\nshader for further consumption.\n\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n include/libcamera/internal/software_isp/debayer_params.h | 1 +\n src/ipa/simple/algorithms/lut.cpp | 1 +\n src/libcamera/software_isp/debayer.cpp | 5 +++++\n 3 files changed, 7 insertions(+)", "diff": "diff --git a/include/libcamera/internal/software_isp/debayer_params.h b/include/libcamera/internal/software_isp/debayer_params.h\nindex d5dad1a98..8033f7d5b 100644\n--- a/include/libcamera/internal/software_isp/debayer_params.h\n+++ b/include/libcamera/internal/software_isp/debayer_params.h\n@@ -59,6 +59,7 @@ struct DebayerParams {\n \tMatrix<float, 3, 3> ccm;\n \tRGB<float> blackLevel;\n \tfloat gamma;\n+\tfloat contrast;\n };\n \n } /* namespace libcamera */\ndiff --git a/src/ipa/simple/algorithms/lut.cpp b/src/ipa/simple/algorithms/lut.cpp\nindex ea5a86b20..9aaab54f1 100644\n--- a/src/ipa/simple/algorithms/lut.cpp\n+++ b/src/ipa/simple/algorithms/lut.cpp\n@@ -149,6 +149,7 @@ void Lut::prepare(IPAContext &context,\n \t}\n \n \tparams->gamma = context.configuration.gamma;\n+\tparams->contrast = context.activeState.gamma.contrast;\n }\n \n void Lut::process([[maybe_unused]] IPAContext &context,\ndiff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp\nindex b3615b32b..b5b99d390 100644\n--- a/src/libcamera/software_isp/debayer.cpp\n+++ b/src/libcamera/software_isp/debayer.cpp\n@@ -115,6 +115,11 @@ namespace libcamera {\n * \\brief Gamma value for the GPUISP\n */\n \n+/**\n+ * \\var DebayerParams::contrast\n+ * \\brief Contrast value for GPUISP\n+ */\n+\n /**\n * \\class Debayer\n * \\brief Base debayering class\n", "prefixes": [ "v5", "20/20" ] }