Patch Detail
Show a patch.
GET /api/1.1/patches/25496/?format=api
{ "id": 25496, "url": "https://patchwork.libcamera.org/api/1.1/patches/25496/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25496/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251211232246.31330-3-bryan.odonoghue@linaro.org>", "date": "2025-12-11T23:22:27", "name": "[v5,02/20] utils: gen-shader-headers: Add a utility to generate headers from shaders", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "533646a11e53043036bbed1cead848a006bbb244", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25496/mbox/", "series": [ { "id": 5656, "url": "https://patchwork.libcamera.org/api/1.1/series/5656/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5656", "date": "2025-12-11T23:22:25", "name": "GPUISP precursor series", "version": 5, "mbox": "https://patchwork.libcamera.org/series/5656/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25496/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25496/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 00345C3257\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 11 Dec 2025 23:23:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AF3E661624;\n\tFri, 12 Dec 2025 00:23:17 +0100 (CET)", "from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com\n\t[IPv6:2607:f8b0:4864:20::42d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 92CA461613\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 12 Dec 2025 00:23:16 +0100 (CET)", "by mail-pf1-x42d.google.com with SMTP id\n\td2e1a72fcca58-7b9215e55e6so446153b3a.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 11 Dec 2025 15:23:16 -0800 (PST)", "from inspiron14p-linux (M106185144161.v4.enabler.ne.jp.\n\t[106.185.144.161]) by smtp.gmail.com with ESMTPSA id\n\td2e1a72fcca58-7f4c4ab52aasm3399933b3a.38.2025.12.11.15.23.09\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 11 Dec 2025 15:23:14 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"A/9hcjI+\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1765495395; x=1766100195;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=tzLWYj/4uneBvx5zEyrPndszFCBrsmGlpqApy0qMaaw=;\n\tb=A/9hcjI+Y/Ogo9xTir6FysON635A6+QxSHabtX5Ftgo8Ft60TmDO5qv2scCzeXYPxW\n\t4HoipYBYHtpBPcRCCNyCpKTkRMQgKJ1Ltw6Zd4hSgdIzHIOvuSUEdaxbFt9RJQ//NUFv\n\tZFnrQ9JCFqOrJvIUM5IIimygbQSa7Yr4lXmINWkk6aBqz9fh2LANKWG0cdnVf1+dJt+0\n\tYqP+PwjTkUCiuD+xo15NfKi2iIClsphoIXt0ckUeg+uxwXmehydKJthAVTKPfUcPodoc\n\tVHSbqg8JtsJvhWmrC+GayK4i5X1dC+arjnoAbu9Tig5lE7BfiFyKfJip+sy7ry+DHw63\n\tOtAQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765495395; x=1766100195;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=tzLWYj/4uneBvx5zEyrPndszFCBrsmGlpqApy0qMaaw=;\n\tb=HpUu4LAK6L2SVquWAaEqXVvr/gYPYd09u1iUXvMVK5k2CpMszAX1ogV4p5oBqQvtTa\n\tO5ZYCkZhQy93RmpdvVfOpq92TO57LiTa17i4bzx+4y4P8f+7uE/NB+ZaKecvfHYIeZKI\n\taa/Yde5jDnVX1KUc4X6AjeId8DY8ufC4fXx4ZslAvBNS2CXEsKsGO+irwq2s1qMK1LGq\n\t/hYWge4j+By7TKdIy7vgtBKK1vaQE9kBK31kvO++FffYez0nOB5hDQPAdy/RiXMl6+tN\n\tEidPV2VZgS19w3d7MVuZj60fTYQY45hdwWoxvO0pWZ8WdHCLbBeZcd6ebOUSl3zPT+4f\n\t1i5g==", "X-Gm-Message-State": "AOJu0YyWIAUiR8hsaoC2HM0yySFZMx5HiCrKQmeUS6igugC2347ffVm7\n\trrgTLMxbe8TMSMHI2j3wKkfhA45Ht5IAw/VImCgPzTsqxQDRwrPrhu01/yQQFMrOUGEvK9Ju1o/\n\tgyxwZ", "X-Gm-Gg": "AY/fxX71vDeNINQsp4QgSNN90ODG3wnHxJCxifNT2wbc7CmkLVDzjckwYYRTbXwVL+i\n\tW4Qrw8BCTotQQd4Zi36qbIvgve9mvHSD6OUFeRnjP7fmeXHEWLmOJ6uh5gnuvr4xR+Qvg0uNdTb\n\t3uUn/vVyo53wC1Edy7BvCrNDyWb//BvKdiqum7OwCsEl06HljslhgG7Zj6hZk3vBCpfnSeQTpSD\n\tNLR1bchYFdoL4na+3TOL0blKxhr2ginPNOzjSYpuxANsg9IilqIc0qM2YLTkrep2EZlEnjAAx8a\n\tK1aCptKfNSuRFd6S35c3vv709fluNtASC8j9tYC+J9tf5xGdtSzRsEdHNxTiOAzup1DyFd6GHxn\n\tKFlxYw0jji8fENcwmX82gPAOcarQOq+3eJSQGLL+2RiJ6zKhIbD7Mh5crjt2cOp7J0lvmshIQet\n\t7NEaHvDkDC3hNm27tGRMSDVBnXW476EQlanUYwtiac8u2iT5k/qtodj4FFtuoa5DKSliK6Ahae", "X-Google-Smtp-Source": "AGHT+IEHRz9YkcQVv7M1I0Pn9+jJ/V5LMOQf2MWUdT2p0QYgnOIQRGq3AXE9K+gXJBHE3KyRwQQsOA==", "X-Received": "by 2002:a05:6a00:4c19:b0:7e8:4587:e8bb with SMTP id\n\td2e1a72fcca58-7f66988e600mr170594b3a.46.1765495394944; \n\tThu, 11 Dec 2025 15:23:14 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tMilan Zamazal <mzamazal@redhat.com>", "Subject": "[PATCH v5 02/20] utils: gen-shader-headers: Add a utility to\n\tgenerate headers from shaders", "Date": "Thu, 11 Dec 2025 23:22:27 +0000", "Message-ID": "<20251211232246.31330-3-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20251211232246.31330-1-bryan.odonoghue@linaro.org>", "References": "<20251211232246.31330-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Two simple script to generate a header that contains GLSL shaders translated\nto C arrays.\n\nAcked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n utils/gen-shader-header.py | 37 +++++++++++++++++++++++++\n utils/gen-shader-headers.sh | 55 +++++++++++++++++++++++++++++++++++++\n 2 files changed, 92 insertions(+)\n create mode 100755 utils/gen-shader-header.py\n create mode 100755 utils/gen-shader-headers.sh", "diff": "diff --git a/utils/gen-shader-header.py b/utils/gen-shader-header.py\nnew file mode 100755\nindex 000000000..745852b4c\n--- /dev/null\n+++ b/utils/gen-shader-header.py\n@@ -0,0 +1,37 @@\n+#!/usr/bin/env python3\n+# SPDX-License-Identifier: GPL-2.0-or-later\n+# Copyright (C) 2025, Bryan O'Donoghue.\n+#\n+# Author: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n+#\n+# A Python script which takes a list of shader files and converts each of them\n+# into a C header.\n+#\n+import sys\n+\n+try:\n+ with open(sys.argv[2], \"rb\") as file:\n+ data = file.read()\n+ data_len = len(data)\n+\n+ name = sys.argv[1].replace(\".\", \"_\")\n+ name_len = name + \"_len\"\n+\n+ j = 0\n+ print(\"unsigned char const\", name, \"[] = {\")\n+ for ch in data:\n+ print(f\"0x{ch:02x}, \", end=\"\")\n+ j = (j + 1) % 16\n+ if j == 0:\n+ print()\n+ if j != 0:\n+ print()\n+ print(\"};\")\n+\n+ print()\n+ print(f\"const unsigned int {name_len}={data_len};\")\n+\n+except FileNotFoundError:\n+ print(f\"File {sys.argv[2]} not found\", file=sys.stderr)\n+except IOError:\n+ print(f\"Unable to read {sys.argv[2]}\", file=sys.stderr)\ndiff --git a/utils/gen-shader-headers.sh b/utils/gen-shader-headers.sh\nnew file mode 100755\nindex 000000000..81bf1584c\n--- /dev/null\n+++ b/utils/gen-shader-headers.sh\n@@ -0,0 +1,55 @@\n+#!/bin/sh\n+\n+set -e\n+\n+usage() {\n+\techo \"Usage: $0 <src_dir> <build_dir> <output_header_name> <shader_file1> [shader_file2 ...]\"\n+\techo\n+\techo \"Generates a C header file containing hex-encoded shader data.\"\n+\techo\n+\techo \"Arguments:\"\n+\techo \" src_dir Path to the base of the source directory\"\n+\techo \" build_dir Directory where shader files are located and header will be written\"\n+\techo \" output_header_name Name of the generated header file (relative to build_dir)\"\n+\techo \" shader_file(s) One or more shader files to embed in the header\"\n+\texit 1\n+}\n+\n+if [ $# -lt 4 ]; then\n+\techo \"Error: Invalid argument count.\"\n+\tusage\n+fi\n+\n+src_dir=\"$1\"; shift\n+build_dir=\"$1\"; shift\n+build_path=$build_dir/\"$1\"; shift\n+\n+cat <<EOF > \"$build_path\"\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/* This file is auto-generated, do not edit! */\n+\n+#pragma once\n+\n+EOF\n+\n+cat <<EOF >> \"$build_path\"\n+/*\n+ * List the names of the shaders at the top of\n+ * header for readability's sake\n+ *\n+EOF\n+\n+for file in \"$@\"; do\n+\tname=$(basename \"$build_dir/$file\" | tr '.' '_')\n+\techo \"[SHADER-GEN] $name\"\n+\techo \" * unsigned char $name;\" >> \"$build_path\"\n+done\n+\n+echo \"*/\" >> \"$build_path\"\n+\n+echo \"/* Hex encoded shader data */\" >> \"$build_path\"\n+for file in \"$@\"; do\n+\tname=$(basename \"$build_dir/$file\")\n+\t\"$src_dir/utils/gen-shader-header.py\" \"$name\" \"$build_dir/$file\" >> \"$build_path\"\n+\techo >> \"$build_path\"\n+done\n", "prefixes": [ "v5", "02/20" ] }