Patch Detail
Show a patch.
GET /api/1.1/patches/25473/?format=api
{ "id": 25473, "url": "https://patchwork.libcamera.org/api/1.1/patches/25473/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25473/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251210164055.17856-9-david.plowman@raspberrypi.com>", "date": "2025-12-10T16:15:23", "name": "[08/11] libcamera: Don't wait for input streams to complete", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "4b7fcf920a1902bfc8de991c29104c18ac0fd8f9", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/1.1/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25473/mbox/", "series": [ { "id": 5650, "url": "https://patchwork.libcamera.org/api/1.1/series/5650/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5650", "date": "2025-12-10T16:15:15", "name": "Bayer re-processing", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5650/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25473/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25473/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D69DFC32AF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 10 Dec 2025 16:41:12 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BC016614B6;\n\tWed, 10 Dec 2025 17:41:11 +0100 (CET)", "from mail-wm1-x336.google.com (mail-wm1-x336.google.com\n\t[IPv6:2a00:1450:4864:20::336])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A96A86149B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 10 Dec 2025 17:41:05 +0100 (CET)", "by mail-wm1-x336.google.com with SMTP id\n\t5b1f17b1804b1-477b1cc8fb4so49470485e9.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 10 Dec 2025 08:41:05 -0800 (PST)", "from davidp-pi5.pitowers.org\n\t([2a00:1098:3142:1f:88ea:c658:5b20:5e46])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-47a88371e13sm1270415e9.11.2025.12.10.08.41.04\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 10 Dec 2025 08:41:04 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"O6c3/Cks\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1765384865; x=1765989665;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=agjDQf+CjyYZrdgafhj0qeb/BZpvrZ5zUAV15xS2+/M=;\n\tb=O6c3/CksFqloV4FNJ8UOXpxt1g4znewLGkT99JAwohWyZQQIcAtaXYjZV0gvQD8m/Q\n\tD4FWi9BCg4vnV3qxYg4neSgJZYLwcmgYhqKXmHPyksDhNbtaaxp5PP7EtMqWpOKYU3Py\n\tSylGEKGzvk/MW3IY4IhoaxjiOaVaiGcfBxi/1xNhBIMrFV8E+2vpCtDmOIHAeYY48mMn\n\txAUW5D4xj+us5g76AxuCfilqmLC/9asr8x2xR8JG0elDQskjz6SpYayitF79/K0DfENG\n\tPlcvBlLe8fwkJs0DGlcVr7NKWInCGCg+YKoFV+6LXPAz9zp66XUC65NnSykho9jeQfO9\n\tQqhw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765384865; x=1765989665;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=agjDQf+CjyYZrdgafhj0qeb/BZpvrZ5zUAV15xS2+/M=;\n\tb=GOPu/8fiJvgGVidDu8362Lco1MwSf6EX4AU1dqhblW6AL23DpnAZMvE9g8mZB6QaSj\n\td4izsGGr+yZ5WkC6yxcgqamt00j7mvvSo/W9kfbTJ47U371cFwoeIxby+5wdPmvDntvs\n\tBx4fGWMZPn/esHE9zV+9G1ToyWafHo/VLbTMwyCS8xPtMrg/us55H5kTdWK9//ngJ9Qo\n\tZdjdBRUeUaJz2BAzSS5/0fN0rizGLwOMYExPQkohuI8qV1PGfunkxY4dBZt9Yueule2p\n\tCJfA2S67oCO509nIJ+pQq0yK5K77HpupFNSPqA0CFwEi9bZsIywRJ58ZM45/rN7M20Cd\n\tgYHA==", "X-Gm-Message-State": "AOJu0Yz01Uc9NTnxFz8qtY7mv+xAPkBOTyfuIlG1+FWIo3c0t1b6oDHc\n\tDahZK39iqW7Po1PudwzRkhuUN7Zn69lAooMwFYZXRc1WTbTtnDMKafhm4SPbA4dLhFPz2mWX9NA\n\tbkb3r", "X-Gm-Gg": "ASbGncv9+f9OJS6QHS8rq4Qe7vUMUH+sEUMyqKOlASvY4+axCd6A6YBTGQsI5uaxMGj\n\t9cQU6whmYgjg70ri+OKEzMLLEFGbpafcIielPKTeR1zKqR14Q5UrxxwsnMCMPg+smjAqG04P+Dx\n\ttKts6H9sMAIrfSBIyI55vOPrBWRIrOPuITKEvC6fUxXefIoy0Bu1IWx1BpdmiSMlJ0h8/HR7PAn\n\tDG/bjEGj3obmi/69YTPrOEpficQFyjwIZnhNxzKhNr/FEArUuPvgZ5gU7JdUr4UPaFQ1REBC73j\n\tGH+cndLPuiAT94wovcOZtK7ZTAsxHNE4bjIAA0OVNa9OJWPKpqBgxkTJjZE9EMUaFjvXPrvqmOr\n\tzjZ0Zc3Nomnmv+6C03POQHRQDo04AIfoaDSic2Lnan+ss/8Bj/C9VDiSrBfvxs1IlaMBnwBArH9\n\tfYD9aV6yRZZryB31/mgsxfQFuD/3TM5WvNuac6CmcBtcDTd+Gb21y/KQWvMelqaXXqvu9qQHKYh\n\t/0i3dYZynw4Od+meIdO/qa0mUbePA==", "X-Google-Smtp-Source": "AGHT+IFdSRfIGBalCd1rdXJsa07qMN353a3ywIHtezOogRedeGao4EWdB0dV6aNQQyW6NJ3+kE0U3w==", "X-Received": "by 2002:a05:600c:1c93:b0:471:d2f:7987 with SMTP id\n\t5b1f17b1804b1-47a837b9a4cmr32309655e9.26.1765384864887; \n\tWed, 10 Dec 2025 08:41:04 -0800 (PST)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "David Plowman <david.plowman@raspberrypi.com>", "Subject": "[PATCH 08/11] libcamera: Don't wait for input streams to complete", "Date": "Wed, 10 Dec 2025 16:15:23 +0000", "Message-ID": "<20251210164055.17856-9-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.47.3", "In-Reply-To": "<20251210164055.17856-1-david.plowman@raspberrypi.com>", "References": "<20251210164055.17856-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Don't add buffers corresponding to input streams to the \"pending\"\nlist. These buffers don't \"complete\" in the normal way, which would\nstop a request from ever completing.\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/libcamera/request.cpp | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex 60565f59..1be5e6e5 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -493,7 +493,9 @@ int Request::addBuffer(const Stream *stream, FrameBuffer *buffer,\n \t}\n \n \tbuffer->_d()->setRequest(this);\n-\t_d()->pending_.insert(buffer);\n+\t/* Don't want to wait for input buffers as they don't \"complete\". */\n+\tif (!stream->configuration().isInput())\n+\t\t_d()->pending_.insert(buffer);\n \n \tif (fence && fence->isValid())\n \t\tbuffer->_d()->setFence(std::move(fence));\n", "prefixes": [ "08/11" ] }