Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 2543,
    "url": "https://patchwork.libcamera.org/api/1.1/patches/2543/?format=api",
    "web_url": "https://patchwork.libcamera.org/patch/2543/",
    "project": {
        "id": 1,
        "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api",
        "name": "libcamera",
        "link_name": "libcamera",
        "list_id": "libcamera_core",
        "list_email": "libcamera-devel@lists.libcamera.org",
        "web_url": "",
        "scm_url": "",
        "webscm_url": ""
    },
    "msgid": "<20200108231518.1852151-1-niklas.soderlund@ragnatech.se>",
    "date": "2020-01-08T23:15:18",
    "name": "[libcamera-devel] v4l2: camera_proxy: Fix compilation error use of undeclared identifier 'ret'",
    "commit_ref": "96eaad1238131721207c6a9bde077f7f1aad5f60",
    "pull_url": null,
    "state": "accepted",
    "archived": false,
    "hash": "c08ce94ce7e9699c6d8e5a5bc4a1c5d9408b3634",
    "submitter": {
        "id": 5,
        "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api",
        "name": "Niklas Söderlund",
        "email": "niklas.soderlund@ragnatech.se"
    },
    "delegate": null,
    "mbox": "https://patchwork.libcamera.org/patch/2543/mbox/",
    "series": [
        {
            "id": 611,
            "url": "https://patchwork.libcamera.org/api/1.1/series/611/?format=api",
            "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=611",
            "date": "2020-01-08T23:15:18",
            "name": "[libcamera-devel] v4l2: camera_proxy: Fix compilation error use of undeclared identifier 'ret'",
            "version": 1,
            "mbox": "https://patchwork.libcamera.org/series/611/mbox/"
        }
    ],
    "comments": "https://patchwork.libcamera.org/api/patches/2543/comments/",
    "check": "pending",
    "checks": "https://patchwork.libcamera.org/api/patches/2543/checks/",
    "tags": {},
    "headers": {
        "Return-Path": "<niklas.soderlund@ragnatech.se>",
        "Received": [
            "from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 845C36045D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu,  9 Jan 2020 00:15:25 +0100 (CET)",
            "from bismarck.berto.se (p54ac5d7b.dip0.t-ipconnect.de\n\t[84.172.93.123]) by bin-vsp-out-01.atm.binero.net (Halon) with ESMTPA\n\tid bdc228b9-326c-11ea-a00b-005056917a89;\n\tThu, 09 Jan 2020 00:15:24 +0100 (CET)"
        ],
        "X-Halon-ID": "bdc228b9-326c-11ea-a00b-005056917a89",
        "Authorized-sender": "niklas@soderlund.pp.se",
        "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>",
        "To": "libcamera-devel@lists.libcamera.org",
        "Date": "Thu,  9 Jan 2020 00:15:18 +0100",
        "Message-Id": "<20200108231518.1852151-1-niklas.soderlund@ragnatech.se>",
        "X-Mailer": "git-send-email 2.24.1",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain; charset=UTF-8",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[libcamera-devel] [PATCH] v4l2: camera_proxy: Fix compilation error\n\tuse of undeclared identifier 'ret'",
        "X-BeenThere": "libcamera-devel@lists.libcamera.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "<libcamera-devel.lists.libcamera.org>",
        "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>",
        "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>",
        "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>",
        "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>",
        "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>",
        "X-List-Received-Date": "Wed, 08 Jan 2020 23:15:25 -0000"
    },
    "content": "Refactoring of the camera_proxy have left the 'ret' variable undeclared,\ndeclare it.\n\n../../src/v4l2/v4l2_camera_proxy.cpp:273:2: error: use of undeclared identifier 'ret'\n        ret = vcam_->invokeMethod(&V4L2Camera::configure,\n        ^\n../../src/v4l2/v4l2_camera_proxy.cpp:278:6: error: use of undeclared identifier 'ret'\n        if (ret < 0)\n\nFixes: fce110c6d961c3bb (\"v4l2: camera_proxy: Break out try_fmt\")\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/v4l2/v4l2_camera_proxy.cpp | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)",
    "diff": "diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\nindex 89dd7166ca527bad..00d0d57172022138 100644\n--- a/src/v4l2/v4l2_camera_proxy.cpp\n+++ b/src/v4l2/v4l2_camera_proxy.cpp\n@@ -270,11 +270,11 @@ int V4L2CameraProxy::vidioc_s_fmt(struct v4l2_format *arg)\n \ttryFormat(arg);\n \n \tSize size(arg->fmt.pix.width, arg->fmt.pix.height);\n-\tret = vcam_->invokeMethod(&V4L2Camera::configure,\n-\t\t\t\t  ConnectionTypeBlocking,\n-\t\t\t\t  &streamConfig_, size,\n-\t\t\t\t  v4l2ToDrm(arg->fmt.pix.pixelformat),\n-\t\t\t\t  bufferCount_);\n+\tint ret = vcam_->invokeMethod(&V4L2Camera::configure,\n+\t\t\t\t      ConnectionTypeBlocking,\n+\t\t\t\t      &streamConfig_, size,\n+\t\t\t\t      v4l2ToDrm(arg->fmt.pix.pixelformat),\n+\t\t\t\t      bufferCount_);\n \tif (ret < 0)\n \t\treturn -EINVAL;\n \n",
    "prefixes": [
        "libcamera-devel"
    ]
}