Patch Detail
Show a patch.
GET /api/1.1/patches/25422/?format=api
{ "id": 25422, "url": "https://patchwork.libcamera.org/api/1.1/patches/25422/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25422/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251210005354.44726-6-bryan.odonoghue@linaro.org>", "date": "2025-12-10T00:53:33", "name": "[v7,05/26] libcamera: shaders: Use highp not mediump for float precision", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "6c6d01298168b7fdda1e1bf9b659e20aec8e0b4b", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25422/mbox/", "series": [ { "id": 5645, "url": "https://patchwork.libcamera.org/api/1.1/series/5645/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5645", "date": "2025-12-10T00:53:28", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 7, "mbox": "https://patchwork.libcamera.org/series/5645/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25422/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25422/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A6AD6C3257\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 10 Dec 2025 00:54:34 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6E17C61442;\n\tWed, 10 Dec 2025 01:54:34 +0100 (CET)", "from mail-pf1-x433.google.com (mail-pf1-x433.google.com\n\t[IPv6:2607:f8b0:4864:20::433])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DAFA36142A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 10 Dec 2025 01:54:32 +0100 (CET)", "by mail-pf1-x433.google.com with SMTP id\n\td2e1a72fcca58-7b9215e55e6so4135553b3a.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 09 Dec 2025 16:54:32 -0800 (PST)", "from inspiron14p-linux (p96936b06.osaknt01.ap.so-net.ne.jp.\n\t[150.147.107.6]) by smtp.gmail.com with ESMTPSA id\n\t41be03b00d2f7-bf6875cc8eesm16057762a12.16.2025.12.09.16.54.26\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 09 Dec 2025 16:54:30 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"r/Ww6sbi\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1765328071; x=1765932871;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=FdyTcK0Xun67yTvAExHcO9DNNAcWNw/aYg3LzuhT/Zc=;\n\tb=r/Ww6sbiRIgoidaWP8XGknzoRKqgJI+pEL/2cM1E7EOP37GDbbImdSMQLAmG/9Snid\n\tmBCFwsqYWl5fhdOGq0vS5OWsKcwneHGfi+1/PIS7G+oUD+exDVASXU8haG8uf8i+zCVi\n\tTncVFvXfaSO3dBVKD+8Bbrmpq+9TLyzE6q1oRG5VGa9bmEz8Fpszg+NgH7KNy5FbcAix\n\tE33H2LnkIIrf1RpijrHFwdQYjHUlMwuNWT7gBvkHQtGQf42zslKjsLUsmmdx7XXN5dp5\n\tBd/VIUB5tFy5HBcWZlcQDLRMJDGnPkqwvVJDlpR6FdCqWTtXv4SHcOhfqWhqY7PjhIfo\n\tePAA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765328071; x=1765932871;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=FdyTcK0Xun67yTvAExHcO9DNNAcWNw/aYg3LzuhT/Zc=;\n\tb=LBPkoXYEEClqi+yU70/C9Wfwq/uitpsnoNAS5SGC8ZAzPkRybIqODAVGnI84zjqZsd\n\tunUXYcR1kcpeD9bdirlm0LZGJj06Gj2Yfavp+QgNwYBA+DgvZJac3nr7zgEsFqYZz8M1\n\t6VuDhNxPFNfFvDYcNZZnMimScTQf+sU/9gvLqUaSZvKdFzIVM5Bf9Eocf1IxVTM6wIaQ\n\tiUGFJhRMOmDiJurcVd0qp9U0m/7F7ejxxbkKUw/P45GnYUjHv95j9yLi9bQIcCHHMrmF\n\t/scQ4gqzNZH+4JplGUwsN/8hEHKAqWDq6qdNKoNeA+JHb/YHxd3yP9mdHhJj0ovLl47f\n\t0Yyw==", "X-Gm-Message-State": "AOJu0YzVDowwyxsW/UZ7qJ1RtSgkicHcXygI2vaFYYzhzm64i5uo3VJf\n\tNXx4ME7L/WKSsp6EF3tuvjls21G2USg9WaJQLubf8qLhV35EQO65ruLBYgkZmxOfIsBV66EvwNA\n\tVfI3V", "X-Gm-Gg": "ASbGncvhChvSa3LclYfuvu0s2/96w5jKXaT09J0JfnzuM0zLoyHwqLcZRbHdLYXGWJz\n\toKCkewNzAbcBrDxsVaz6gNV0aQLXYc9TBfxeZFh+R+GjraxrAkLHMl41wD9gwdl8l5kaVfK1atO\n\tqAGHit3x+JLdH4iy+yDohnXrwqAYiz0B1jRjxlQo8uyHeoM+NTWZTjEvGuV1TEgmtnRfPU5e5mV\n\tJ29NjAva/i/H/sLPA/kVHCI8XjAnsLuc2Jq5QXm3SyrtyrIj/hWWBJAbklvX62BUjYwjlbnU2li\n\tvzvOdvK6/FtSOeubPEkyhBFMUvZ+ZC7gDyK2j+oa0x1wj4R6kChE6kY0zdmF6LQKETCy7J/86uP\n\tzJ9FtTkOlG3z3fSeWhYfPVwYXAH82QAGeRDIj8BRvoMP9d+rMshbppPxHfDv32UPNqVNpJ2M4zR\n\tDN7gqbVNv6hkPHTPfVhJTgTr2I+pPxAX40Smzt9wXSdLpIHDKlsHd925SXKFSvV7Tl", "X-Google-Smtp-Source": "AGHT+IGe2E1ivJtJvkM4EQRKSHR77a9ZuPj+GN0vmrHFo8KwUR2bR9MQ+hcYnPIHhYuVcO/o3pd1ow==", "X-Received": "by 2002:a05:6a20:3c90:b0:35d:8c8:8ab4 with SMTP id\n\tadf61e73a8af0-366e2999d7cmr538889637.44.1765328071123; \n\tTue, 09 Dec 2025 16:54:31 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tMilan Zamazal <mzamazal@redhat.com>", "Subject": "[PATCH v7 05/26] libcamera: shaders: Use highp not mediump for float\n\tprecision", "Date": "Wed, 10 Dec 2025 00:53:33 +0000", "Message-ID": "<20251210005354.44726-6-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20251210005354.44726-1-bryan.odonoghue@linaro.org>", "References": "<20251210005354.44726-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "mediump gives 10 bits of mantissa as the resolution. At higher resolutions\n10 bits of accuracy is insufficient - for example at a width of 1928 bytes\nwe need log2(1928) = ~11 bit resolution.\n\nSwitching to highp gives us 23 bits of mantissa giving a sample width\nprecision of about 2^23 ~ 8,388,608.\n\nAcked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/shaders/RGB.frag | 2 +-\n src/libcamera/shaders/YUV_2_planes.frag | 2 +-\n src/libcamera/shaders/YUV_3_planes.frag | 2 +-\n src/libcamera/shaders/YUV_packed.frag | 2 +-\n src/libcamera/shaders/bayer_1x_packed.frag | 2 +-\n src/libcamera/shaders/bayer_unpacked.frag | 2 +-\n 6 files changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/libcamera/shaders/RGB.frag b/src/libcamera/shaders/RGB.frag\nindex 4c374ac98..724395894 100644\n--- a/src/libcamera/shaders/RGB.frag\n+++ b/src/libcamera/shaders/RGB.frag\n@@ -6,7 +6,7 @@\n */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n varying vec2 textureOut;\ndiff --git a/src/libcamera/shaders/YUV_2_planes.frag b/src/libcamera/shaders/YUV_2_planes.frag\nindex 1d5d12062..d286f1179 100644\n--- a/src/libcamera/shaders/YUV_2_planes.frag\n+++ b/src/libcamera/shaders/YUV_2_planes.frag\n@@ -6,7 +6,7 @@\n */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n varying vec2 textureOut;\ndiff --git a/src/libcamera/shaders/YUV_3_planes.frag b/src/libcamera/shaders/YUV_3_planes.frag\nindex 8f788e90a..8e3e0b4a5 100644\n--- a/src/libcamera/shaders/YUV_3_planes.frag\n+++ b/src/libcamera/shaders/YUV_3_planes.frag\n@@ -6,7 +6,7 @@\n */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n varying vec2 textureOut;\ndiff --git a/src/libcamera/shaders/YUV_packed.frag b/src/libcamera/shaders/YUV_packed.frag\nindex b9ef9d41b..3c9e3e397 100644\n--- a/src/libcamera/shaders/YUV_packed.frag\n+++ b/src/libcamera/shaders/YUV_packed.frag\n@@ -6,7 +6,7 @@\n */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n varying vec2 textureOut;\ndiff --git a/src/libcamera/shaders/bayer_1x_packed.frag b/src/libcamera/shaders/bayer_1x_packed.frag\nindex f53f55758..19b13ad08 100644\n--- a/src/libcamera/shaders/bayer_1x_packed.frag\n+++ b/src/libcamera/shaders/bayer_1x_packed.frag\n@@ -20,7 +20,7 @@\n */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n /*\ndiff --git a/src/libcamera/shaders/bayer_unpacked.frag b/src/libcamera/shaders/bayer_unpacked.frag\nindex 7e35ca88e..aa7a1b004 100644\n--- a/src/libcamera/shaders/bayer_unpacked.frag\n+++ b/src/libcamera/shaders/bayer_unpacked.frag\n@@ -16,7 +16,7 @@ Copyright (C) 2021, Linaro\n \n //Pixel Shader\n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n /** Monochrome RGBA or GL_LUMINANCE Bayer encoded texture.*/\n", "prefixes": [ "v7", "05/26" ] }