Patch Detail
Show a patch.
GET /api/1.1/patches/25421/?format=api
{ "id": 25421, "url": "https://patchwork.libcamera.org/api/1.1/patches/25421/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25421/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251210005354.44726-5-bryan.odonoghue@linaro.org>", "date": "2025-12-10T00:53:32", "name": "[v7,04/26] libcamera: shaders: Rename bayer_8 to bayer_unpacked", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "35a6d78fdb97510d821282384ecb89af3e2b1926", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25421/mbox/", "series": [ { "id": 5645, "url": "https://patchwork.libcamera.org/api/1.1/series/5645/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5645", "date": "2025-12-10T00:53:28", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 7, "mbox": "https://patchwork.libcamera.org/series/5645/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25421/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25421/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 37204C3257\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 10 Dec 2025 00:54:30 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E745D61438;\n\tWed, 10 Dec 2025 01:54:29 +0100 (CET)", "from mail-pf1-x429.google.com (mail-pf1-x429.google.com\n\t[IPv6:2607:f8b0:4864:20::429])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 244486142A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 10 Dec 2025 01:54:28 +0100 (CET)", "by mail-pf1-x429.google.com with SMTP id\n\td2e1a72fcca58-7b22ffa2a88so6325164b3a.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 09 Dec 2025 16:54:28 -0800 (PST)", "from inspiron14p-linux (p96936b06.osaknt01.ap.so-net.ne.jp.\n\t[150.147.107.6]) by smtp.gmail.com with ESMTPSA id\n\t41be03b00d2f7-bf6875cc8eesm16057762a12.16.2025.12.09.16.54.23\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 09 Dec 2025 16:54:26 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"KcfVW8Cr\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1765328066; x=1765932866;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=lV+JLx0+P4aigKpifcEHa5VvxL7Qodjjb3+3JXtFVoo=;\n\tb=KcfVW8Cr9UwoPV+/tSjMEEl+oghMGsa1mYh4MT6wp5ETKUN+0nc7DD5GLCHzJu9gXa\n\t9iVhHMY12ZqyBAXDvIn6VaLmjgfEd57KdVLn/ZqNADpIz474lyyAdJCK4Tg8zdCHe/ad\n\tyic5IuMwnq4Jwl90oaFVOTSNdNh58VOemyqwLGgPrz1pAyBCQ64m4N64cVneAwLYl5Xh\n\tUYr5XBdhTrA/gNgw3fHJ2PdhAiQGePVx+b+wWfCoVjthlQNOdVCheM2Zt5DYDtHhhY76\n\t8d2KN1hNpRMba4aKbNWrlignpS9dJy/5fQStYSNjOvDEyMY653TC/d7DMli0RZ9E4CvP\n\tMhfg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765328066; x=1765932866;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=lV+JLx0+P4aigKpifcEHa5VvxL7Qodjjb3+3JXtFVoo=;\n\tb=R1ol3augjwsPaMLKJ1OSEQE3qIfeWcRxdk+QorvjCNspkQOPy3BalPz/Bk0u7UaJSU\n\t1YHhYbx8T25Acrvr8Sdg0tMF79/aTZnayC9SLGQUle/Cft1yN3A0WX7cmNLCXZJHlZg2\n\tNAiqmhoXSo+rCE1PXw6ge2YlWrHvimVGXExpTnIBwOXzr2qNOP6B3iA7oMfqsCPeJuBk\n\tJk1ItTO0tGiE7R+Wm8g+t9KFXZQLt/4UMMgLEXr5vPaaGv9c/4ZsKbtoflixLl1zeSaB\n\t+ZhPK/Bjho9jZuWThdWrH+QfwY9kKPOPWdv12aZuNljsk+43o4GrwHUuTxf/EAN+onA0\n\tmveg==", "X-Gm-Message-State": "AOJu0YxlXlRb97N9YumKpOgpST2OEeHDDgsfkvMoLTQX1XC4OlCMWwkt\n\tRQVp4prF85LELZXXXJ4tL7r2O0G5WDh81euMU0eFNvw7X1Bwg773Z/Mh+o9rmo7wAzj7v7JwqBV\n\t7Dd15", "X-Gm-Gg": "ASbGncukLrF4maFU8Pe5nvlg6r3LJU59JzSPD0vlTRhY4HOdMAmmzxFBI7qS2S/iCct\n\tr5DXJ9ejWgblXkRU0gUc9/K3vo3oTX1XJQ7EtMSHiUFXeE0JfD+sETTgIYJD0kmsfOROyfeWKXC\n\tpg+t9VFmKvZplhqGEQkzLYaZv4krr8hyTafWGbhO8vEiqYTyEic8PkA5x3SaZ+S069w3T8hPzZg\n\tdbt2ZNgwm4zeJChlF/Jq9Goa5sAa7Ywp0a3eExMFDj0QkcMNuBUh6GKu17XoSwN+wLsoBo4Z8w+\n\tSj/3ywIctvKj5oWFOflYGC3WGe/AIIAO0YOnBGfd1/RQAiAXLwWMB+2+l5Ae25Iek29jSPtqkGq\n\tK8/mwUhDhGCYUxLXSpF0ii+RO9w8MI2eEQ8TnPHGx3fwCsiYWUZKwsGwVpAOEdcPBosykmCLIM8\n\tWZEL19JLLoHOMlymIlcU5akUchdYOZn/5NAThndGHCcrp6XKV6FXBi4Q8clhEVYYwf", "X-Google-Smtp-Source": "AGHT+IEa+ThqQkEne0bq4bINYcuOZi8k6mk5ZdK3wn+AxSfy2oHT/hMChGX7KSXEXw5T33F6/C6ZIQ==", "X-Received": "by 2002:a05:6a20:748e:b0:366:14ac:8c76 with SMTP id\n\tadf61e73a8af0-366e288a36fmr583660637.76.1765328066455; \n\tTue, 09 Dec 2025 16:54:26 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Milan Zamazal <mzamazal@redhat.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tBryan O'Donoghue <bryan.odonoghue@linaro.org>", "Subject": "[PATCH v7 04/26] libcamera: shaders: Rename bayer_8 to\n\tbayer_unpacked", "Date": "Wed, 10 Dec 2025 00:53:32 +0000", "Message-ID": "<20251210005354.44726-5-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20251210005354.44726-1-bryan.odonoghue@linaro.org>", "References": "<20251210005354.44726-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Milan Zamazal <mzamazal@redhat.com>\n\nbayer_8.* shaders are now used for all unpacked sensor data formats,\nregardless of the pixel bit width. Let's rename the \"8-bit\" shaders to\navoid confusion.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/apps/qcam/assets/shader/shaders.qrc | 4 ++--\n src/apps/qcam/viewfinder_gl.cpp | 16 ++++++++--------\n .../{bayer_8.frag => bayer_unpacked.frag} | 0\n .../{bayer_8.vert => bayer_unpacked.vert} | 0\n src/libcamera/shaders/meson.build | 4 ++--\n 5 files changed, 12 insertions(+), 12 deletions(-)\n rename src/libcamera/shaders/{bayer_8.frag => bayer_unpacked.frag} (100%)\n rename src/libcamera/shaders/{bayer_8.vert => bayer_unpacked.vert} (100%)", "diff": "diff --git a/src/apps/qcam/assets/shader/shaders.qrc b/src/apps/qcam/assets/shader/shaders.qrc\nindex 7369cdbe8..f11a68ef2 100644\n--- a/src/apps/qcam/assets/shader/shaders.qrc\n+++ b/src/apps/qcam/assets/shader/shaders.qrc\n@@ -6,8 +6,8 @@\n \t<file>../../../../../src/libcamera/shaders/YUV_3_planes.frag</file>\n \t<file>../../../../../src/libcamera/shaders/YUV_packed.frag</file>\n \t<file>../../../../../src/libcamera/shaders/bayer_1x_packed.frag</file>\n-\t<file>../../../../../src/libcamera/shaders/bayer_8.frag</file>\n-\t<file>../../../../../src/libcamera/shaders/bayer_8.vert</file>\n+\t<file>../../../../../src/libcamera/shaders/bayer_unpacked.frag</file>\n+\t<file>../../../../../src/libcamera/shaders/bayer_unpacked.vert</file>\n \t<file>../../../../../src/libcamera/shaders/identity.vert</file>\n </qresource>\n </RCC>\ndiff --git a/src/apps/qcam/viewfinder_gl.cpp b/src/apps/qcam/viewfinder_gl.cpp\nindex 69b7c6e59..ea957dc65 100644\n--- a/src/apps/qcam/viewfinder_gl.cpp\n+++ b/src/apps/qcam/viewfinder_gl.cpp\n@@ -235,29 +235,29 @@ bool ViewFinderGL::selectFormat(const libcamera::PixelFormat &format)\n \tcase libcamera::formats::SBGGR8:\n \t\tfirstRed_.setX(1.0);\n \t\tfirstRed_.setY(1.0);\n-\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_8.vert\";\n-\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_8.frag\";\n+\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.vert\";\n+\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.frag\";\n \t\ttextureMinMagFilters_ = GL_NEAREST;\n \t\tbreak;\n \tcase libcamera::formats::SGBRG8:\n \t\tfirstRed_.setX(0.0);\n \t\tfirstRed_.setY(1.0);\n-\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_8.vert\";\n-\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_8.frag\";\n+\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.vert\";\n+\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.frag\";\n \t\ttextureMinMagFilters_ = GL_NEAREST;\n \t\tbreak;\n \tcase libcamera::formats::SGRBG8:\n \t\tfirstRed_.setX(1.0);\n \t\tfirstRed_.setY(0.0);\n-\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_8.vert\";\n-\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_8.frag\";\n+\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.vert\";\n+\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.frag\";\n \t\ttextureMinMagFilters_ = GL_NEAREST;\n \t\tbreak;\n \tcase libcamera::formats::SRGGB8:\n \t\tfirstRed_.setX(0.0);\n \t\tfirstRed_.setY(0.0);\n-\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_8.vert\";\n-\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_8.frag\";\n+\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.vert\";\n+\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.frag\";\n \t\ttextureMinMagFilters_ = GL_NEAREST;\n \t\tbreak;\n \tcase libcamera::formats::SBGGR10_CSI2P:\ndiff --git a/src/libcamera/shaders/bayer_8.frag b/src/libcamera/shaders/bayer_unpacked.frag\nsimilarity index 100%\nrename from src/libcamera/shaders/bayer_8.frag\nrename to src/libcamera/shaders/bayer_unpacked.frag\ndiff --git a/src/libcamera/shaders/bayer_8.vert b/src/libcamera/shaders/bayer_unpacked.vert\nsimilarity index 100%\nrename from src/libcamera/shaders/bayer_8.vert\nrename to src/libcamera/shaders/bayer_unpacked.vert\ndiff --git a/src/libcamera/shaders/meson.build b/src/libcamera/shaders/meson.build\nindex 386b342d0..dd441a577 100644\n--- a/src/libcamera/shaders/meson.build\n+++ b/src/libcamera/shaders/meson.build\n@@ -4,7 +4,7 @@\n # for the purposes of inclusion in OpenGL debayering\n shader_files = files([\n 'bayer_1x_packed.frag',\n- 'bayer_8.frag',\n- 'bayer_8.vert',\n+ 'bayer_unpacked.frag',\n+ 'bayer_unpacked.vert',\n 'identity.vert',\n ])\n", "prefixes": [ "v7", "04/26" ] }