Patch Detail
Show a patch.
GET /api/1.1/patches/25401/?format=api
{ "id": 25401, "url": "https://patchwork.libcamera.org/api/1.1/patches/25401/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25401/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251210003139.43606-6-bryan.odonoghue@linaro.org>", "date": "2025-12-10T00:31:22", "name": "[v4,05/20] libcamera: swstats_cpu: Drop patternSize_ documentation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "59741e75c523b0031de9169f512623c1b3987ba1", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25401/mbox/", "series": [ { "id": 5644, "url": "https://patchwork.libcamera.org/api/1.1/series/5644/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5644", "date": "2025-12-10T00:31:17", "name": "GPUISP precursor series", "version": 4, "mbox": "https://patchwork.libcamera.org/series/5644/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25401/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25401/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6BBAFBD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 10 Dec 2025 00:32:12 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1D9506142A;\n\tWed, 10 Dec 2025 01:32:12 +0100 (CET)", "from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com\n\t[IPv6:2607:f8b0:4864:20::1035])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 45B156141A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 10 Dec 2025 01:32:10 +0100 (CET)", "by mail-pj1-x1035.google.com with SMTP id\n\t98e67ed59e1d1-34372216275so6276704a91.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 09 Dec 2025 16:32:10 -0800 (PST)", "from inspiron14p-linux (p96936b06.osaknt01.ap.so-net.ne.jp.\n\t[150.147.107.6]) by smtp.gmail.com with ESMTPSA id\n\t98e67ed59e1d1-34a70427ea6sm566580a91.3.2025.12.09.16.32.06\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 09 Dec 2025 16:32:08 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"XYPFq7/T\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1765326729; x=1765931529;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=KNhdXYMCXvgUlmVf+twHe8rkAmqCTfmIboT5GgzpZy8=;\n\tb=XYPFq7/TKt6oXUyD+KJ+i1YTnMHirbQ84z8aWQt/ToLPr13hG2tgaauGnmpK9xunOo\n\t73U4FL06sUklQ7VPuz99n0SqkAo2IU8F5j+9PiA0GZgWG9axjmYwTUegEC1MYwfYfjHo\n\tUD97I5CmWvUMA8m3sKddOzAJVRBtB5G0ZdS5sGoOkTEt2x7oOifWYP9oRe2ooDrWOl+E\n\tS7x/O/2KfYL35KLO9dG+luo13Wgqccz3HVF8cwlTr98kMYFVRsfU6+xjh8V+a1tHYd7h\n\t15ZMA4vF8JycgAjFJdNZ74i2vQzRHmSYQ81jFLGhBPdZ/GYcqtpmHc2El5GBCTfFh5qz\n\tyuCw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765326729; x=1765931529;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=KNhdXYMCXvgUlmVf+twHe8rkAmqCTfmIboT5GgzpZy8=;\n\tb=Eua9sTuy+ZLvokxOVv3ymKI4BG3O86cYtKUCFSeAuXlEQG043razz+LtkVsCxfCja8\n\tuV2lnZbfXFH4wb5RE1h+ZipE7p6xbiiAT1DIKxVbk77J2FUnZKVh+YPjEbRvK9ZBsAlW\n\tTj4q+Wl7/70jzGLZBkK6yTfVsI43zJ77iFOd+Q20jnLfx4nFMK0c/1E2rvMsHaZlNXjY\n\tqJckq+UYXy+7c1MFYevOd8SkQMtWnyCSlroKQq/Q9s1bCuRi7j+K/Q4gdpVHYEeUn1lo\n\tsYIYOIu8nNEGY08+sRpAmZJfkWEurccj5lprBBeu5caog5qF3i72+C5nnKA5VWjVOF0+\n\tNN3Q==", "X-Gm-Message-State": "AOJu0Yx6lF1cK2VCwDXCfmkgo1wpmbfaBJecb9Zykd72HZcpippiA/Ni\n\tpS2gGZZzs7JXw29WSaEUo36r8WywzgPs1E+A5mh004++5A6OTw/CGrgGpCi8zInvMNkzLvhBa7v\n\t3fVfD", "X-Gm-Gg": "AY/fxX61wc0MSUXruRuOys2omBHgX4KqAtStA3U8qmH0Y2foxDjuFif0wcfE/Ue/Quu\n\tirBFNysXf2YM5fbc7O2c203zW6SbdidB1eE7xc9kTrvZ9MxywBLHIx8r2Q1WXbXKfEbkCuHz7Cc\n\tRXpwskJj4Zyuj+ZmXpDR2H9p4Oe7ywHaLtVhZXurte2h/ejap9lmB9IIAw/XkF94yvmPeA7TJBz\n\t2Q15z8oXckD7o0sz41PJyL0sbv0X5YveClXwUSHC6RNvod9vLvrej5seog3XMMcny8Gy4YNLsDE\n\tMsDrnm3DpwlJEasXA6OTIc+uZETzg1YLAuYOvAg6RTEuN4HSxOtNTfLBufgJQVpisA01SbR978s\n\tPil1f3ShhZ8W0qGn8BmtQc2If1iJ6bqduTL6sFpPNIOYB6GgIROKGdiqqViIEkh0bvmTfTA7C1H\n\t2SDUQNGpyyyD6TmW5x4odJ4FxxH7wMq3M1nU83p8aSWav7KGNDFa5NvGEe3s8BBQ+8", "X-Google-Smtp-Source": "AGHT+IFxis0e8OYaWjXTar8q2nm8yyQkhWAI8+KsuHvFTK7Qw2pkUOMLWC71CU+Uskp1ViEpLtybSA==", "X-Received": "by 2002:a17:90b:1d8e:b0:343:c3d1:8bb1 with SMTP id\n\t98e67ed59e1d1-34a7284b8d7mr490153a91.28.1765326728564; \n\tTue, 09 Dec 2025 16:32:08 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Hans de Goede <hdegoede@redhat.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tMilan Zamazal <mzamazal@redhat.com>,\n\tBryan O'Donoghue <bryan.odonoghue@linaro.org>", "Subject": "[PATCH v4 05/20] libcamera: swstats_cpu: Drop patternSize_\n\tdocumentation", "Date": "Wed, 10 Dec 2025 00:31:22 +0000", "Message-ID": "<20251210003139.43606-6-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20251210003139.43606-1-bryan.odonoghue@linaro.org>", "References": "<20251210003139.43606-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Hans de Goede <hdegoede@redhat.com>\n\npatternSize_ is a private variable and its meaning is already documented\nin the patternSize() getter documentation.\n\nMove the list of valid sizes to the patternSize() getter documentation\nand drop the patternSize_ documentation.\n\nWhile at it also add 1x1 as valid size for use with future support\nof single plane non Bayer input data.\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Hans de Goede <hdegoede@redhat.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/swstats_cpu.cpp | 9 ++-------\n 1 file changed, 2 insertions(+), 7 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp\nindex 9c03338a0..1b33ffa71 100644\n--- a/src/libcamera/software_isp/swstats_cpu.cpp\n+++ b/src/libcamera/software_isp/swstats_cpu.cpp\n@@ -58,6 +58,8 @@ namespace libcamera {\n * also indicates if processLine2() should be called or not.\n * This may only be called after a successful configure() call.\n *\n+ * Valid sizes are: 1x1, 2x2, 4x2 or 4x4.\n+ *\n * \\return The pattern size\n */\n \n@@ -133,13 +135,6 @@ namespace libcamera {\n * \\brief Statistics window, set by setWindow(), used every line\n */\n \n-/**\n- * \\var Size SwStatsCpu::patternSize_\n- * \\brief The size of the bayer pattern\n- *\n- * Valid sizes are: 2x2, 4x2 or 4x4.\n- */\n-\n /**\n * \\var unsigned int SwStatsCpu::xShift_\n * \\brief The offset of x, applied to window_.x for bayer variants\n", "prefixes": [ "v4", "05/20" ] }