Patch Detail
Show a patch.
GET /api/1.1/patches/25386/?format=api
{ "id": 25386, "url": "https://patchwork.libcamera.org/api/1.1/patches/25386/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25386/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251208110035.248881-1-barnabas.pocze@ideasonboard.com>", "date": "2025-12-08T11:00:33", "name": "[RFC,v2,1/3] libcamera: device_enumerator_udev: Add `override`", "commit_ref": null, "pull_url": null, "state": "deferred", "archived": false, "hash": "45b1749c20ee05463d9aab22274265dc50c0fad4", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/1.1/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25386/mbox/", "series": [ { "id": 5642, "url": "https://patchwork.libcamera.org/api/1.1/series/5642/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5642", "date": "2025-12-08T11:00:33", "name": "[RFC,v2,1/3] libcamera: device_enumerator_udev: Add `override`", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5642/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25386/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25386/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 11B2BBDDFC\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 8 Dec 2025 11:00:42 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AFCAC613FC;\n\tMon, 8 Dec 2025 12:00:41 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C75F0613CB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 8 Dec 2025 12:00:39 +0100 (CET)", "from pb-laptop.local (185.221.142.68.nat.pool.zt.hu\n\t[185.221.142.68])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A0B4C2E0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 8 Dec 2025 11:58:20 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GwnwGsnS\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1765191500;\n\tbh=KA37pH/L0X5utgwtXP+ttwNBkxWQO9S5WtE6yCh9Enc=;\n\th=From:To:Subject:Date:From;\n\tb=GwnwGsnSxTCOC9it80+ao4IQTL0cQ3jWJ18bfjGVHY9GosBAu3+oa59UfYtE+BB3X\n\tBHASraQFG57pSrWpl3aSBc7HjXqE3yN7pccVD0KJVmyjL9HVYc+CQKog+rpI0u4qP2\n\t1MdRg0ceUqY5L0Zm6DAOtikxRJibhEM7FVevsd6U=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[RFC PATCH v2 1/3] libcamera: device_enumerator_udev: Add `override`", "Date": "Mon, 8 Dec 2025 12:00:33 +0100", "Message-ID": "<20251208110035.248881-1-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.52.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Mark the overridden virtual functions as \"override\".\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n include/libcamera/internal/device_enumerator_udev.h | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/include/libcamera/internal/device_enumerator_udev.h b/include/libcamera/internal/device_enumerator_udev.h\nindex 1378c1906d..fb0005921a 100644\n--- a/include/libcamera/internal/device_enumerator_udev.h\n+++ b/include/libcamera/internal/device_enumerator_udev.h\n@@ -32,8 +32,8 @@ public:\n \tDeviceEnumeratorUdev();\n \t~DeviceEnumeratorUdev();\n \n-\tint init();\n-\tint enumerate();\n+\tint init() override;\n+\tint enumerate() override;\n \n private:\n \tusing DependencyMap = std::map<dev_t, std::list<MediaEntity *>>;\n", "prefixes": [ "RFC", "v2", "1/3" ] }