Patch Detail
Show a patch.
GET /api/1.1/patches/25380/?format=api
{ "id": 25380, "url": "https://patchwork.libcamera.org/api/1.1/patches/25380/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25380/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251208004808.1274417-3-rui.wang@ideasonboard.com>", "date": "2025-12-08T00:48:03", "name": "[v4,2/7] ipa: rkisp1: algorithms: dpf: Implement noise reduction mode switching", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "853c576d8120c94877479715348f34e141edf4df", "submitter": { "id": 241, "url": "https://patchwork.libcamera.org/api/1.1/people/241/?format=api", "name": "Rui Wang", "email": "rui.wang@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25380/mbox/", "series": [ { "id": 5641, "url": "https://patchwork.libcamera.org/api/1.1/series/5641/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5641", "date": "2025-12-08T00:48:01", "name": "rebase_dpf_refactory_patch_v4", "version": 4, "mbox": "https://patchwork.libcamera.org/series/5641/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25380/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25380/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7ABB1C3257\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 8 Dec 2025 00:48:42 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 33CD9613EB;\n\tMon, 8 Dec 2025 01:48:42 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 73B43611BA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 8 Dec 2025 01:48:40 +0100 (CET)", "from localhost.localdomain (unknown [209.216.103.65])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EAFD11E29;\n\tMon, 8 Dec 2025 01:46:21 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"s3YZmAl7\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1765154782;\n\tbh=XAh7xLbe/PVjNDq6z2lc7ofo54bT7w+cSFt8kaCSfy8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=s3YZmAl7+cfWTy1F4fQpxK1DbzNsmZKz3dKxKLEBH1iVzT5tTZ/7GufqOt73KBOXn\n\tcnSe7nSmuFn0dyNBDCsQsTCnBGr2v8IhmZ++MYBbhoxtihr1IS8nxhCK0Kw05Vsyda\n\t/LU/6DeAZhfXJRACIcNkyMIwp+OSUwi3QbEtJesI=", "From": "Rui Wang <rui.wang@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Rui Wang <rui.wang@ideasonboard.com>", "Subject": "[PATCH v4 2/7] ipa: rkisp1: algorithms: dpf: Implement noise\n\treduction mode switching", "Date": "Sun, 7 Dec 2025 19:48:03 -0500", "Message-ID": "<20251208004808.1274417-3-rui.wang@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20251208004808.1274417-1-rui.wang@ideasonboard.com>", "References": "<20251208004808.1274417-1-rui.wang@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "-Add support for switching between different noise reduction modes.\n-Introduce `noiseReductionModes_` to store mode-specific configs.\n-loadReductionConfig() select specific config from configs\n\nIntroduce `noiseReductionModes_` to store current configs.\n\nSigned-off-by: Rui Wang <rui.wang@ideasonboard.com>\n---\n\nchangelog:\n - Add blank line \n - Move V3 first patch's loadReductionConfig and reduction mode helper \n into this patch\n \n src/ipa/rkisp1/algorithms/dpf.cpp | 81 ++++++++++++++++++++++++++++++-\n src/ipa/rkisp1/algorithms/dpf.h | 11 +++++\n 2 files changed, 90 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/dpf.cpp b/src/ipa/rkisp1/algorithms/dpf.cpp\nindex cd0a7d9d..18f2a158 100644\n--- a/src/ipa/rkisp1/algorithms/dpf.cpp\n+++ b/src/ipa/rkisp1/algorithms/dpf.cpp\n@@ -37,7 +37,9 @@ namespace ipa::rkisp1::algorithms {\n LOG_DEFINE_CATEGORY(RkISP1Dpf)\n \n Dpf::Dpf()\n-\t: config_({}), strengthConfig_({})\n+\t: config_({}), strengthConfig_({}),\n+\t noiseReductionModes_({}),\n+\t runningMode_(controls::draft::NoiseReductionModeOff)\n {\n }\n \n@@ -61,6 +63,53 @@ bool Dpf::parseConfig(const YamlObject &tuningData)\n \tif (!parseSingleConfig(tuningData, config_, strengthConfig_)) {\n \t\treturn false;\n \t}\n+\n+\t/* Parse modes. */\n+\tif (!parseModes(tuningData)) {\n+\t\treturn false;\n+\t}\n+\n+\treturn true;\n+}\n+\n+bool Dpf::parseModes(const YamlObject &tuningData)\n+{\n+\t/* Parse noise reduction modes. */\n+\tif (!tuningData.contains(\"modes\")) {\n+\t\treturn true;\n+\t}\n+\n+\tnoiseReductionModes_.clear();\n+\tfor (const auto &entry : tuningData[\"modes\"].asList()) {\n+\t\tstd::optional<std::string> typeOpt =\n+\t\t\tentry[\"type\"].get<std::string>();\n+\t\tif (!typeOpt) {\n+\t\t\tLOG(RkISP1Dpf, Error) << \"Modes entry missing type\";\n+\t\t\treturn false;\n+\t\t}\n+\n+\t\tint32_t modeValue = controls::draft::NoiseReductionModeOff;\n+\t\tif (*typeOpt == \"minimal\") {\n+\t\t\tmodeValue = controls::draft::NoiseReductionModeMinimal;\n+\t\t} else if (*typeOpt == \"fast\") {\n+\t\t\tmodeValue = controls::draft::NoiseReductionModeFast;\n+\t\t} else if (*typeOpt == \"highquality\") {\n+\t\t\tmodeValue = controls::draft::NoiseReductionModeHighQuality;\n+\t\t} else if (*typeOpt == \"zsl\") {\n+\t\t\tmodeValue = controls::draft::NoiseReductionModeZSL;\n+\t\t} else {\n+\t\t\tLOG(RkISP1Dpf, Error) << \"Unknown mode type: \" << *typeOpt;\n+\t\t\treturn false;\n+\t\t}\n+\n+\t\tModeConfig mode{};\n+\t\tmode.modeValue = modeValue;\n+\t\tif (!parseSingleConfig(entry, mode.dpf, mode.strength)) {\n+\t\t\treturn false;\n+\t\t}\n+\t\tnoiseReductionModes_.push_back(mode);\n+\t}\n+\n \treturn true;\n }\n \n@@ -192,6 +241,29 @@ bool Dpf::parseSingleConfig(const YamlObject &tuningData,\n \treturn true;\n }\n \n+bool Dpf::loadReductionConfig(int32_t mode)\n+{\n+\tauto it = std::find_if(noiseReductionModes_.begin(), noiseReductionModes_.end(),\n+\t\t\t [mode](const ModeConfig &m) {\n+\t\t\t\t return m.modeValue == mode;\n+\t\t\t });\n+\tif (it == noiseReductionModes_.end()) {\n+\t\tLOG(RkISP1Dpf, Warning)\n+\t\t\t<< \"No DPF config for reduction mode \"\n+\t\t\t<< static_cast<int>(mode);\n+\t\treturn false;\n+\t}\n+\n+\tconfig_ = it->dpf;\n+\tstrengthConfig_ = it->strength;\n+\n+\tLOG(RkISP1Dpf, Info)\n+\t\t<< \"DPF mode=Reduction (config loaded)\"\n+\t\t<< \" mode=\" << static_cast<int>(mode);\n+\n+\treturn true;\n+}\n+\n /**\n * \\copydoc libcamera::ipa::Algorithm::queueRequest\n */\n@@ -207,6 +279,7 @@ void Dpf::queueRequest(IPAContext &context,\n \tif (denoise) {\n \t\tLOG(RkISP1Dpf, Debug) << \"Set denoise to \" << *denoise;\n \n+\t\trunningMode_ = *denoise;\n \t\tswitch (*denoise) {\n \t\tcase controls::draft::NoiseReductionModeOff:\n \t\t\tif (dpf.denoise) {\n@@ -217,8 +290,12 @@ void Dpf::queueRequest(IPAContext &context,\n \t\tcase controls::draft::NoiseReductionModeMinimal:\n \t\tcase controls::draft::NoiseReductionModeHighQuality:\n \t\tcase controls::draft::NoiseReductionModeFast:\n-\t\t\tif (!dpf.denoise) {\n+\t\tcase controls::draft::NoiseReductionModeZSL:\n+\t\t\tif (loadReductionConfig(runningMode_)) {\n+\t\t\t\tupdate = true;\n \t\t\t\tdpf.denoise = true;\n+\t\t\t} else {\n+\t\t\t\tdpf.denoise = false;\n \t\t\t\tupdate = true;\n \t\t\t}\n \t\t\tbreak;\ndiff --git a/src/ipa/rkisp1/algorithms/dpf.h b/src/ipa/rkisp1/algorithms/dpf.h\nindex bee6fc9b..30cbaa57 100644\n--- a/src/ipa/rkisp1/algorithms/dpf.h\n+++ b/src/ipa/rkisp1/algorithms/dpf.h\n@@ -30,13 +30,24 @@ public:\n \t\t RkISP1Params *params) override;\n \n private:\n+\tstruct ModeConfig {\n+\t\tint32_t modeValue;\n+\t\trkisp1_cif_isp_dpf_config dpf;\n+\t\trkisp1_cif_isp_dpf_strength_config strength;\n+\t};\n+\n \tbool parseConfig(const YamlObject &tuningData);\n+\tbool parseModes(const YamlObject &tuningData);\n \tbool parseSingleConfig(const YamlObject &tuningData,\n \t\t\t rkisp1_cif_isp_dpf_config &config,\n \t\t\t rkisp1_cif_isp_dpf_strength_config &strengthConfig);\n \n+\tbool loadReductionConfig(int32_t mode);\n+\n \tstruct rkisp1_cif_isp_dpf_config config_;\n \tstruct rkisp1_cif_isp_dpf_strength_config strengthConfig_;\n+\tstd::vector<ModeConfig> noiseReductionModes_;\n+\tint32_t runningMode_;\n };\n \n } /* namespace ipa::rkisp1::algorithms */\n", "prefixes": [ "v4", "2/7" ] }