Patch Detail
Show a patch.
GET /api/1.1/patches/25374/?format=api
{ "id": 25374, "url": "https://patchwork.libcamera.org/api/1.1/patches/25374/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25374/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251205-mali-cru-v1-4-d81bb5ffe73a@ideasonboard.com>", "date": "2025-12-05T14:52:10", "name": "[4/7] libcamera: mali-c55: Configure camera in memory-to-memory", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "03aedb2c4bd55e9868a5a6bbce4e30dba91ce257", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25374/mbox/", "series": [ { "id": 5640, "url": "https://patchwork.libcamera.org/api/1.1/series/5640/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5640", "date": "2025-12-05T14:52:06", "name": "libcamera: mali-c55: Add support for memory-to-memory", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5640/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25374/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25374/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 756C2C326B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 5 Dec 2025 14:52:40 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1E311613F9;\n\tFri, 5 Dec 2025 15:52:36 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6B023613A5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 5 Dec 2025 15:52:31 +0100 (CET)", "from [192.168.1.4] (net-93-65-100-155.cust.vodafonedsl.it\n\t[93.65.100.155])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2C5E711EF;\n\tFri, 5 Dec 2025 15:50:15 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CYvNHnkM\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1764946215;\n\tbh=YjJ9aXd41gmwwuZExWFJU4Q3KYuLVmrMwL87At7x/54=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=CYvNHnkMxtJjXQT6ZP5AcQ7O12+6zj2ocMaw3RQq9jSqyZg1vNUnJBM6/+WikvLBK\n\tkR5j5TBQYx/QaFNWUnzQ6vMgTzhw8qyIwKdAbwvG9htw3jS+X6CekGnQu/sbm/m+5p\n\tpoOetMU4J5hgg5ogyyfh0uw4BpRYaj9Ui4beFZU4=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Date": "Fri, 05 Dec 2025 15:52:10 +0100", "Subject": "[PATCH 4/7] libcamera: mali-c55: Configure camera in\n\tmemory-to-memory", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20251205-mali-cru-v1-4-d81bb5ffe73a@ideasonboard.com>", "References": "<20251205-mali-cru-v1-0-d81bb5ffe73a@ideasonboard.com>", "In-Reply-To": "<20251205-mali-cru-v1-0-d81bb5ffe73a@ideasonboard.com>", "To": "Daniel Scally <dan.scally@ideasonboard.com>, \n\tlibcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "X-Mailer": "b4 0.14.2", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1828;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=YjJ9aXd41gmwwuZExWFJU4Q3KYuLVmrMwL87At7x/54=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBpMvGtxWQUjspbepm4kjtnEcqCa+phRAaKWBMOf\n\tyvXeein2dSJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaTLxrQAKCRByNAaPFqFW\n\tPId9EACkUuQAlk0xkIEun1SMk9vvebbjb3GGS9JFkfJeufSPJsO52v/yN29FIcKZ6OopIRpLZVx\n\teCXoz15bMq+G9Si2oDQ1qd+RhaoeRdaSrflyKVkYkbZwuyD8abHi/4jHXFR46fuQiTd4eh76Ff7\n\tJjdetu15G4bxkNx6gwR52Q50jNql+Rosbf+CUyy6Ja7o120iwLX9lXepRjcXuQGqwMqEZGHiCWB\n\t47BqLfAZWwyN0jv/uSHywiGdsV8mMmnJQ0yTX6slGIJsHOCCTfR4f0xI+1bBW/4MGBMwNt/GJ59\n\tC2NY0PLrTSg9178EAWEm7cBkB0NJ2B2qtzXk39uk2Wism2jwwhDIKI6bKF6nK1GWS0Nk2XA2Lki\n\ts9CzRqdcS7EFTu0uy72XuFi7V3LGAJwkEqIdGJw74+TVbPWLLjMG2MQXO8dNK5iy8BUmZ+5hu1i\n\t0ec95EiXyAqkd6ezerQaIMcVFkxVYO1FLBInlU4blhOxrZQ9ZTeFR8Bg+ufO7p03N7og/NbjMgc\n\tAqB+AmPUpPffzWhaZAJliXOGVxdcrfocnAMGOF3S9rFlCLxvgH3BCgZZZNXgsqt5/hT4b7yRgxI\n\tV/sOR16Pb1uaFlqxYJLGoVJD+NGHe7ALXvWjCBMz8z3uddg2L0+r31L942wV9ikKaPWpgqdqk7c\n\t+Qu+b3/bY7Hsbkw==", "X-Developer-Key": "i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add support for memory-to-memory Camera to the\nPipelineHandlerMaliC55::configure() function.\n\nStart by enabling the IVC links, then configure the CRU and\npropagate the format to the IVC.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 26 ++++++++++++++++++++++++--\n 1 file changed, 24 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex 6816bf7179ae09434ec10c35ea296725d3ac0700..6dce315c1c82db3554e8c0eae727cba9d632ca82 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -1021,9 +1021,12 @@ int PipelineHandlerMaliC55::configure(Camera *camera,\n \t\tret = csi2Entity->getPadByIndex(1)->links()[0]->setEnabled(true);\n \t\tbreak;\n \t}\n-\tcase MaliC55CameraData::Memory:\n+\tcase MaliC55CameraData::Memory: {\n+\t\tconst MediaEntity *ivcEntity = ivc_->entity();\n+\t\tret = ivcEntity->getPadByIndex(1)->links()[0]->setEnabled(true);\n \t\tbreak;\n \t}\n+\t}\n \tif (ret)\n \t\treturn ret;\n \n@@ -1049,9 +1052,28 @@ int PipelineHandlerMaliC55::configure(Camera *camera,\n \t\tret = data->inlineInput.csi2_->getFormat(1, &subdevFormat);\n \n \t\tbreak;\n-\tcase MaliC55CameraData::Memory:\n+\tcase MaliC55CameraData::Memory: {\n+\t\tV4L2DeviceFormat inputFormat;\n+\t\tret = data->memoryInput.cru_->configure(&subdevFormat, &inputFormat);\n+\t\tif (ret)\n+\t\t\treturn ret;\n+\n+\t\t/* Propagate the CRU format to the IVC input. */\n+\t\tret = ivc_->setFormat(0, &subdevFormat);\n+\t\tif (ret)\n+\t\t\treturn ret;\n+\n+\t\tret = ivc_->getFormat(1, &subdevFormat);\n+\t\tif (ret)\n+\t\t\treturn ret;\n+\n+\t\tret = input_->setFormat(&inputFormat);\n+\t\tif (ret)\n+\t\t\treturn ret;\n+\n \t\tbreak;\n \t}\n+\t}\n \tif (ret)\n \t\treturn ret;\n \n", "prefixes": [ "4/7" ] }