Patch Detail
Show a patch.
GET /api/1.1/patches/25360/?format=api
{ "id": 25360, "url": "https://patchwork.libcamera.org/api/1.1/patches/25360/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25360/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251204164918.83334-5-mzamazal@redhat.com>", "date": "2025-12-04T16:49:13", "name": "[v17,4/7] libcamera: simple: Don't enforce conversion with an added raw stream", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "469ef729f7b1103f9d8dbd078924c72669899872", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/1.1/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25360/mbox/", "series": [ { "id": 5637, "url": "https://patchwork.libcamera.org/api/1.1/series/5637/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5637", "date": "2025-12-04T16:49:09", "name": "Enable raw streams with software ISP", "version": 17, "mbox": "https://patchwork.libcamera.org/series/5637/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25360/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25360/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3AD92C3257\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 4 Dec 2025 16:49:52 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E0A756115A;\n\tThu, 4 Dec 2025 17:49:51 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 513BD61130\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 4 Dec 2025 17:49:50 +0100 (CET)", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-563-hQYR2r1pPkiGwhsk_PXpEA-1;\n\tThu, 04 Dec 2025 11:49:45 -0500", "from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 5C7771800342; Thu, 4 Dec 2025 16:49:41 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.32.71])\n\tby mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 129FE300F965; Thu, 4 Dec 2025 16:49:37 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"NGfrAVr9\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1764866989;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=MJH6AmNOLYgPdJDEDPZvRKcqbBe2ja00VKBXFcKPHCQ=;\n\tb=NGfrAVr9azCma9sQPO6UJw6WCr86Y8p1nTAXB7QnT+ut44Dj0U6ejGmoOJZlNlpyzgJ7wu\n\tDRYCEHNoMWIzjzpUUeoUSe3GprzzS56rLEFzlu6L0rGLTbo43HvgYrFc+fZDOJ7oHVc1TY\n\tSgJyLVCG9thNNRSW4WXjHYtz+0Bv+3s=", "X-MC-Unique": "hQYR2r1pPkiGwhsk_PXpEA-1", "X-Mimecast-MFC-AGG-ID": "hQYR2r1pPkiGwhsk_PXpEA_1764866981", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>, Laurent Pinchart\n\t<laurent.pinchart@ideasonboard.com>, Kieran Bingham\n\t<kieran.bingham@ideasonboard.com>, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t<barnabas.pocze@ideasonboard.com>, Paul Elder\n\t<paul.elder@ideasonboard.com>, Umang Jain <uajain@igalia.com>,\n\tPavel Machek <pavel@ucw.cz>", "Subject": "[PATCH v17 4/7] libcamera: simple: Don't enforce conversion with an\n\tadded raw stream", "Date": "Thu, 4 Dec 2025 17:49:13 +0100", "Message-ID": "<20251204164918.83334-5-mzamazal@redhat.com>", "In-Reply-To": "<20251204164918.83334-1-mzamazal@redhat.com>", "References": "<20251204164918.83334-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.4", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "GcBe1uXecC541tVEsYNAKlmYpRUgWjtnZPYu4ieqfgs_1764866981", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When a raw stream is requested, either alone or together with a\nprocessed stream, it can be produced without conversion. Let's amend\nthe corresponding check on the number of configurations, so that the\nmere presence of a raw stream doesn't enforce conversion.\n\nReviewed-by: Umang Jain <uajain@igalia.com>\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/libcamera/pipeline/simple/simple.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex aaafe0571..178bc1bc7 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -1249,7 +1249,7 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate()\n \t * require any conversion, similar to raw capture use cases). This is\n \t * left as a future improvement.\n \t */\n-\tneedConversion_ = config_.size() > 1;\n+\tneedConversion_ = config_.size() > 1 + rawCount;\n \n \tfor (unsigned int i = 0; i < config_.size(); ++i) {\n \t\tStreamConfiguration &cfg = config_[i];\n", "prefixes": [ "v17", "4/7" ] }