Patch Detail
Show a patch.
GET /api/1.1/patches/25328/?format=api
{ "id": 25328, "url": "https://patchwork.libcamera.org/api/1.1/patches/25328/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25328/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251202134544.662446-20-bryan.odonoghue@linaro.org>", "date": "2025-12-02T13:45:39", "name": "[v6,19/24] ipa: simple: Add a flag to indicate gpuIspEnabled", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "eb72be8930ba83fc7926620d682bf8490a897b25", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25328/mbox/", "series": [ { "id": 5631, "url": "https://patchwork.libcamera.org/api/1.1/series/5631/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5631", "date": "2025-12-02T13:45:20", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 6, "mbox": "https://patchwork.libcamera.org/series/5631/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25328/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25328/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F008AC32F8\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 2 Dec 2025 13:46:28 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2E78360F5C;\n\tTue, 2 Dec 2025 14:46:28 +0100 (CET)", "from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com\n\t[IPv6:2a00:1450:4864:20::32b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6C22C60F2B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 2 Dec 2025 14:46:20 +0100 (CET)", "by mail-wm1-x32b.google.com with SMTP id\n\t5b1f17b1804b1-47795f6f5c0so32984605e9.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 02 Dec 2025 05:46:20 -0800 (PST)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-47926f0ec69sm19383375e9.1.2025.12.02.05.46.18\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 02 Dec 2025 05:46:19 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"OOZcDnrA\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1764683180; x=1765287980;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=nivFNcCIHsaOZPEeps0+pnpIxnf4gkOkum1uGeCG8kg=;\n\tb=OOZcDnrAIaJEATiiN1Q4DnRaCWBnPp0ALon9oYtB2Ii7bLNM6E2nlapcdlRUO0OO06\n\tW5ytibjC7PR3fIFY0PzBmjZVMGbQ+7bSvIAMB31HSh4bnzBqjz2czMEk0VHU8wL4EiEn\n\t8goZMHYkoTcY+iOEy5dm7kdvfCVG6MPbV7mCoNzbGtJ8zr/rJWsSSQBHAa32L4fmuH1y\n\tEiya4EWGjE2UMrvg2NZtcvcI8pdfnt0c310cHWu/z/nVzpCRGfSGuSbqCJFyLpxdBugO\n\tgcfxD28asmsa/6ksz7iUWNjRksJ7GGlLaKqmBzchCjlVZ+bG6+ZqunHAs1oj/XVoIu6m\n\tiFVw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1764683180; x=1765287980;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=nivFNcCIHsaOZPEeps0+pnpIxnf4gkOkum1uGeCG8kg=;\n\tb=g2sg02jJ5OozvKZpHzefTueiFWRtXo6wqG61SWUYGB/79d0/y/ZYmLLFsCygnf/qRC\n\t2NzkquEJchYxjLWxBykjnBGPl8Zak8ye8KGBwRD3V75P1Tm5bEvoi1VN01r51yrUIPA7\n\tqRPVB7OqffLFzNosMt8fxKLspgRKkDstLxS3dL2N6tAfHc0SyH7ycgYv451gbD0PzTWz\n\tuNLBnZ6aNsu5A6BcVopGi3w405GNN3/amIFeW8pJaz3SG+6Rtksy8shwUPLwSWgbD5Xn\n\tnoPtyL34bIwfXEd56Ssm2w3rLUKFm7vlDET5fwKIOl2iROo6BxNAKLrMlHi9igRqVCvd\n\teNBA==", "X-Gm-Message-State": "AOJu0YxgLIle6Zlvdsf3Hn8xY28qjj6Ste12Rmj4LoWHOQBwUL9jtIZr\n\tF/VJj8Tok+Pcu6Wg7iSwufLkxsaKFKI+3wK/iMTjVX2i2vDwV1s/L2NPZtlQDcnP6NyrLSlgv6u\n\t7WmUn", "X-Gm-Gg": "ASbGncsO1nVYFFQHsB0NjoG4WoKy6VUhmifBSJTAlEWcDxVuj0aiaxmeHp6TY6a+MY6\n\tQkrI8n7d6glan7VDtMbN3aMpsGdrnscIEMNHLdLlbFtig2JxiqTtGq9JQtCdBiCjSrJd7QtFub/\n\tvcR9RzqXVbH9MtRq46OQBA+Ni07dQyh/JqDhPqKErzkdEFr71/0KeqL5qoLizlhQYdPnye0Sfbb\n\tTRvZtEXiZXgImR+LDd1QfM95S8cWxtA5taMm9EXnLuGnyJvW9pXuMDdvn+wIlmGLW4TYkyJIkoC\n\t+azN+6u2IeImbVKYVyXhZkhoK/11hf1r4fAWlv6YL1QWC5S6l8JWgEDbevhMcGnYCc3kUBVlo6d\n\tG8wY8GbfyR3u83ucbpwJYeEkjzr0TcE/Lbg4MDxEePAzcsVyxOjf9GWVA2zcZQ/AEEtamuSiZrH\n\t+dun6M5OQfZVH0GTBzXElJTOgDwu9R27HdGykm2aLpMAm6IdHYMFi6WHSIWF7ggiVeXMIiwtNaH\n\tCnKEA==", "X-Google-Smtp-Source": "AGHT+IHt/9vIppjRGfU4/n9GiNKPzEPhqhNpUtJkvFIscW/5xTxxJgXpdVjYnvxVDCHU1QtsaDmSGA==", "X-Received": "by 2002:a05:600c:5253:b0:477:63dc:be00 with SMTP id\n\t5b1f17b1804b1-477c01bf726mr362385535e9.25.1764683179693; \n\tTue, 02 Dec 2025 05:46:19 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz,\n\tBryan O'Donoghue <bryan.odonoghue@linaro.org>", "Subject": "[PATCH v6 19/24] ipa: simple: Add a flag to indicate gpuIspEnabled", "Date": "Tue, 2 Dec 2025 13:45:39 +0000", "Message-ID": "<20251202134544.662446-20-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20251202134544.662446-1-bryan.odonoghue@linaro.org>", "References": "<20251202134544.662446-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Flag gpuIspEnabled in the simple IPA context. This flag will allow to\nselectively avoid some calculations or to generate a default CCM.\n\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n include/libcamera/ipa/soft.mojom | 3 ++-\n src/ipa/simple/ipa_context.h | 1 +\n src/ipa/simple/soft_simple.cpp | 3 +++\n src/libcamera/software_isp/software_isp.cpp | 8 +++++++-\n 4 files changed, 13 insertions(+), 2 deletions(-)", "diff": "diff --git a/include/libcamera/ipa/soft.mojom b/include/libcamera/ipa/soft.mojom\nindex 77328c5fd..aff8fcbd3 100644\n--- a/include/libcamera/ipa/soft.mojom\n+++ b/include/libcamera/ipa/soft.mojom\n@@ -17,7 +17,8 @@ interface IPASoftInterface {\n \t libcamera.SharedFD fdStats,\n \t libcamera.SharedFD fdParams,\n \t libcamera.IPACameraSensorInfo sensorInfo,\n-\t libcamera.ControlInfoMap sensorControls)\n+\t libcamera.ControlInfoMap sensorControls,\n+\t bool gpuIspEnabled)\n \t\t=> (int32 ret, libcamera.ControlInfoMap ipaControls, bool ccmEnabled);\n \tstart() => (int32 ret);\n \tstop();\ndiff --git a/src/ipa/simple/ipa_context.h b/src/ipa/simple/ipa_context.h\nindex c3081e306..ee8fb6b03 100644\n--- a/src/ipa/simple/ipa_context.h\n+++ b/src/ipa/simple/ipa_context.h\n@@ -103,6 +103,7 @@ struct IPAContext {\n \tFCQueue<IPAFrameContext> frameContexts;\n \tControlInfoMap::Map ctrlMap;\n \tbool ccmEnabled = false;\n+\tbool gpuIspEnabled = false;\n };\n \n } /* namespace ipa::soft */\ndiff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\nindex b147aca2e..2bbe271d9 100644\n--- a/src/ipa/simple/soft_simple.cpp\n+++ b/src/ipa/simple/soft_simple.cpp\n@@ -55,6 +55,7 @@ public:\n \t\t const SharedFD &fdParams,\n \t\t const IPACameraSensorInfo &sensorInfo,\n \t\t const ControlInfoMap &sensorControls,\n+\t\t bool gpuIspEnabled,\n \t\t ControlInfoMap *ipaControls,\n \t\t bool *ccmEnabled) override;\n \tint configure(const IPAConfigInfo &configInfo) override;\n@@ -95,6 +96,7 @@ int IPASoftSimple::init(const IPASettings &settings,\n \t\t\tconst SharedFD &fdParams,\n \t\t\tconst IPACameraSensorInfo &sensorInfo,\n \t\t\tconst ControlInfoMap &sensorControls,\n+\t\t\tbool gpuIspEnabled,\n \t\t\tControlInfoMap *ipaControls,\n \t\t\tbool *ccmEnabled)\n {\n@@ -106,6 +108,7 @@ int IPASoftSimple::init(const IPASettings &settings,\n \t}\n \n \tcontext_.sensorInfo = sensorInfo;\n+\tcontext_.gpuIspEnabled = gpuIspEnabled;\n \n \t/* Load the tuning data file */\n \tFile file(settings.configurationFile);\ndiff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex fd68dd0c5..a14fa22e5 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -130,6 +130,8 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n \t\t}\n \t}\n \n+\tbool gpuIspEnabled;\n+\n #if HAVE_DEBAYER_EGL\n \tif (!softISPMode || !strcmp(softISPMode, \"gpu\")) {\n \t\tdebayer_ = std::make_unique<DebayerEGL>(std::move(stats), configuration);\n@@ -137,10 +139,13 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n \t\t\tLOG(SoftwareIsp, Error) << \"Failed to instantiate GPUISP\";\n \t\t\treturn;\n \t\t}\n+\t\tgpuIspEnabled = true;\n \t}\n #endif\n-\tif (!debayer_)\n+\tif (!debayer_) {\n \t\tdebayer_ = std::make_unique<DebayerCpu>(std::move(stats), configuration);\n+\t\tgpuIspEnabled = false;\n+\t}\n \n \tif (!debayer_) {\n \t\tLOG(SoftwareIsp, Error) << \"Failed to create Debayer object\";\n@@ -177,6 +182,7 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n \t\t\t sharedParams_.fd(),\n \t\t\t sensorInfo,\n \t\t\t sensor->controls(),\n+\t\t\t gpuIspEnabled,\n \t\t\t ipaControls,\n \t\t\t &ccmEnabled_);\n \tif (ret) {\n", "prefixes": [ "v6", "19/24" ] }