Patch Detail
Show a patch.
GET /api/1.1/patches/25314/?format=api
{ "id": 25314, "url": "https://patchwork.libcamera.org/api/1.1/patches/25314/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25314/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251202134544.662446-6-bryan.odonoghue@linaro.org>", "date": "2025-12-02T13:45:25", "name": "[v6,05/24] libcamera: shaders: Use highp not mediump for float precision", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "6c6d01298168b7fdda1e1bf9b659e20aec8e0b4b", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25314/mbox/", "series": [ { "id": 5631, "url": "https://patchwork.libcamera.org/api/1.1/series/5631/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5631", "date": "2025-12-02T13:45:20", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 6, "mbox": "https://patchwork.libcamera.org/series/5631/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25314/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25314/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 63523C32DE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 2 Dec 2025 13:46:05 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C5FE960D17;\n\tTue, 2 Dec 2025 14:46:04 +0100 (CET)", "from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com\n\t[IPv6:2a00:1450:4864:20::32d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A041E60C92\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 2 Dec 2025 14:45:59 +0100 (CET)", "by mail-wm1-x32d.google.com with SMTP id\n\t5b1f17b1804b1-477b198f4bcso40705295e9.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 02 Dec 2025 05:45:59 -0800 (PST)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-47926f0ec69sm19383375e9.1.2025.12.02.05.45.57\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 02 Dec 2025 05:45:58 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"xGs2SImB\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1764683159; x=1765287959;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=W/s9mmdbl87zzKzmRKPs0PR9N0I+f2koWRf2p9p2M+w=;\n\tb=xGs2SImBMNZNY3bgVCwvLRDQFE9cSmvYpy93h9e/mtAQHFW1mC4VcKBCKOhnC31Cnz\n\ty/EqqTGA/c5f1dvX07KenpvVTskAJPuxX7LFIhnWnf2CRdoTvre418xR1cWb0zmM7MuB\n\tzE8G+ZLWfeeb0zetqTyTeBu5HUPi5M9+K+6VAfmj9FpEg3UXcnb+vl2v8RFGqkVVNDZw\n\tt1Rh9chHVgNco6UQ/Rp+KZdnOil9Xj7Dvlm4a9n2FwRtFkrl2KOkr6UhnEgvv2m44gFL\n\tUujNdmIMzLcBwemgq5n2lWyUDhtzbFprBurhDj6mTRdHbrhfzC3R8EUGlDXFQ+qM8JMU\n\t7Nng==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1764683159; x=1765287959;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=W/s9mmdbl87zzKzmRKPs0PR9N0I+f2koWRf2p9p2M+w=;\n\tb=vHS+0orpDEfKcI4Mmw4KDEyzKij7D5WaSYZ3hB8JaWsDPjHIvEGj6o24Hz5Pra8Ywi\n\t4Zv4AFFkyGzJGn+mQm5yxiTw5XJIbQd3KvrmtmitCRbX0t9ujoR+DrzNvZKpBqVQ2QMF\n\tMbZwwmpNdiD6vj2UCYQkuFfXHh0KboDgugqWJxKsHmPLO5TebbP9+0Rg55FpHF60AOi/\n\ths1723SRyGf8Kv6Vj4C7V76dC0Z2OhyB5JvtznP7O/YiigOm3n2YJ6AIMJgMQPDB8FTn\n\tDEEtQtTYxacIRNIuS29Ekw84t7rEkAGZGa+pUuzMF7ysP84XwgsomObr41yEIFzsLa9J\n\tg3jA==", "X-Gm-Message-State": "AOJu0YwhPNqqACHNMTdvYO2lxMJ8MS3X+pHImm447xmNJ/URUeQQN4Gx\n\tyN/y0BhducxfqQN/tkdOCx1vYUaZrXhRQCSOadaHmmD7aJK+WUg404rfNHOQbxCkGif/UBM9G2d\n\t+XgYL", "X-Gm-Gg": "ASbGncvnU0EifQdZwLV3r+CWVzlIBXdeVjOlYFHV8mC16Bzgt8EH4Tal/cNvu3Hd95J\n\tJ4LSCYBnt2ptqsQEuH4iKFLF0RrJJLTPRog4nuS8Uj72/fD3pfq4/7UZekWq3+0Cpi6Lu9udzXT\n\tihEPpAxlEXIepawC4sHrjivuR+p8OxEMvwGnXRHSPO9HCroWTs9XKkF85ZRfxNWZGxH7OT2qrXA\n\tK7Jfj7uHtaVyEK8HJjMQb0RvEMkL+Z/rN/BrgJ1QZYrZf8yFvO+I+kEAE0TzGyyPauX5Sx4BdC+\n\t9UCPHYankBp2RyMpQcVBcNzyXIYyAOK1PNCVMyASTVNhSIZfAdgNLZvw4/rzo/jQ1b++G/r+k0S\n\tPhr8WfdgWqXLthJPCIVVohO5YLpNmcUltiIV3QdNXpqR+Wi6YVOjhdbbvyxDlavDrBr6+C4VmB9\n\t83pWSvBR5trsQ9Q9Zgav81n7NvqSAS/5Tp7hKRWGanGQef/BqP0r/sGc/60qYKDBXLnCU=", "X-Google-Smtp-Source": "AGHT+IHoFvCrxxewE0J4bGcOHNU5dUGu6ccyxKVs6Jo6GnqbmLGYKPsOjqdtSFPyeOJzqX98TKxiOg==", "X-Received": "by 2002:a05:600c:474b:b0:477:9dc1:b706 with SMTP id\n\t5b1f17b1804b1-477c01b494fmr443451105e9.19.1764683158899; \n\tTue, 02 Dec 2025 05:45:58 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v6 05/24] libcamera: shaders: Use highp not mediump for float\n\tprecision", "Date": "Tue, 2 Dec 2025 13:45:25 +0000", "Message-ID": "<20251202134544.662446-6-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20251202134544.662446-1-bryan.odonoghue@linaro.org>", "References": "<20251202134544.662446-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "mediump gives 10 bits of mantissa as the resolution. At higher resolutions\n10 bits of accuracy is insufficient - for example at a width of 1928 bytes\nwe need log2(1928) = ~11 bit resolution.\n\nSwitching to highp gives us 23 bits of mantissa giving a sample width\nprecision of about 2^23 ~ 8,388,608.\n\nAcked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/shaders/RGB.frag | 2 +-\n src/libcamera/shaders/YUV_2_planes.frag | 2 +-\n src/libcamera/shaders/YUV_3_planes.frag | 2 +-\n src/libcamera/shaders/YUV_packed.frag | 2 +-\n src/libcamera/shaders/bayer_1x_packed.frag | 2 +-\n src/libcamera/shaders/bayer_unpacked.frag | 2 +-\n 6 files changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/libcamera/shaders/RGB.frag b/src/libcamera/shaders/RGB.frag\nindex 4c374ac98..724395894 100644\n--- a/src/libcamera/shaders/RGB.frag\n+++ b/src/libcamera/shaders/RGB.frag\n@@ -6,7 +6,7 @@\n */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n varying vec2 textureOut;\ndiff --git a/src/libcamera/shaders/YUV_2_planes.frag b/src/libcamera/shaders/YUV_2_planes.frag\nindex 1d5d12062..d286f1179 100644\n--- a/src/libcamera/shaders/YUV_2_planes.frag\n+++ b/src/libcamera/shaders/YUV_2_planes.frag\n@@ -6,7 +6,7 @@\n */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n varying vec2 textureOut;\ndiff --git a/src/libcamera/shaders/YUV_3_planes.frag b/src/libcamera/shaders/YUV_3_planes.frag\nindex 8f788e90a..8e3e0b4a5 100644\n--- a/src/libcamera/shaders/YUV_3_planes.frag\n+++ b/src/libcamera/shaders/YUV_3_planes.frag\n@@ -6,7 +6,7 @@\n */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n varying vec2 textureOut;\ndiff --git a/src/libcamera/shaders/YUV_packed.frag b/src/libcamera/shaders/YUV_packed.frag\nindex b9ef9d41b..3c9e3e397 100644\n--- a/src/libcamera/shaders/YUV_packed.frag\n+++ b/src/libcamera/shaders/YUV_packed.frag\n@@ -6,7 +6,7 @@\n */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n varying vec2 textureOut;\ndiff --git a/src/libcamera/shaders/bayer_1x_packed.frag b/src/libcamera/shaders/bayer_1x_packed.frag\nindex f53f55758..19b13ad08 100644\n--- a/src/libcamera/shaders/bayer_1x_packed.frag\n+++ b/src/libcamera/shaders/bayer_1x_packed.frag\n@@ -20,7 +20,7 @@\n */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n /*\ndiff --git a/src/libcamera/shaders/bayer_unpacked.frag b/src/libcamera/shaders/bayer_unpacked.frag\nindex 7e35ca88e..aa7a1b004 100644\n--- a/src/libcamera/shaders/bayer_unpacked.frag\n+++ b/src/libcamera/shaders/bayer_unpacked.frag\n@@ -16,7 +16,7 @@ Copyright (C) 2021, Linaro\n \n //Pixel Shader\n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n /** Monochrome RGBA or GL_LUMINANCE Bayer encoded texture.*/\n", "prefixes": [ "v6", "05/24" ] }