Patch Detail
Show a patch.
GET /api/1.1/patches/25307/?format=api
{ "id": 25307, "url": "https://patchwork.libcamera.org/api/1.1/patches/25307/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25307/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251202133157.661407-22-bryan.odonoghue@linaro.org>", "date": "2025-12-02T13:31:52", "name": "[v3,21/22] libcamera: software_isp: lut: Make gamma from lut.cpp available in debayer params", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "7e3165c52936b4a82668272030fb62fd74c41dad", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25307/mbox/", "series": [ { "id": 5630, "url": "https://patchwork.libcamera.org/api/1.1/series/5630/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5630", "date": "2025-12-02T13:31:31", "name": "GPUISP precursor series", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5630/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25307/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25307/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E7FB4C32DE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 2 Dec 2025 13:32:38 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7ED7460D38;\n\tTue, 2 Dec 2025 14:32:38 +0100 (CET)", "from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com\n\t[IPv6:2a00:1450:4864:20::42b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 61AF160D2F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 2 Dec 2025 14:32:25 +0100 (CET)", "by mail-wr1-x42b.google.com with SMTP id\n\tffacd0b85a97d-42e2d44c727so1351477f8f.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 02 Dec 2025 05:32:25 -0800 (PST)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-42e1c5c30c4sm33363322f8f.9.2025.12.02.05.32.23\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 02 Dec 2025 05:32:24 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"PmhJ0PlQ\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1764682345; x=1765287145;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=HoRMsGpYrPRY+icAUgHJVJD1/UYHwY8MVQgFeGlpOV4=;\n\tb=PmhJ0PlQ0bBC5qwRRNQnueqhkDbMk0Esb74TGsLlRl4hRsKHskgV87qX5KaWLxuCW1\n\tp8UtwUPIGnV0Tb70gq0Ty7yPcleicw05K27iWUIFvo1r4QOM5SLZi3Un3ImiPgC8GGw6\n\tkuLCNaCYoPYu/1JqUYHU8aQjqxZ2xkRLqCRLsdDKwCRdLz6bIcUmoJKobwg4vIoUcRJG\n\tLBBEY0dIYShZZfX7PtlDfKVZnD+bpQ3W275ND8Gfu3fuJNNKGAFifKG8en5HyLTIWzCm\n\tw74jUpvY30vWd6pBm9fujlZkdklSvFMSbozh2sKgvQdaXbQoMlvaeArRWy795Avn0S4T\n\tQhRw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1764682345; x=1765287145;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=HoRMsGpYrPRY+icAUgHJVJD1/UYHwY8MVQgFeGlpOV4=;\n\tb=mlGNuvhFJZ2YRT286ihpg0Y3/SA4X/iNgHO+oxp6fXPrPN3DkX8PjNJ+OmoLoUYpNL\n\t5vAoGQSte/XKkMmrzBqnd149gnwrhzwNigoOPgy/o+3ipZWDC3nrylgH8gUYqw5SGl8j\n\tLY65SYqgbdswgcoAR2rnp4fIzrS6Nx54kaKTa6JvYBv9FxW1YfKMhdfGhg8/PP/5QfJP\n\td2viYPskFOiYWmQnpHnNIZTVIhaNl6x9YskYceNhql5Tnay/1qyUrXwHs3987G54OtTT\n\tr1qTBpxJH6zIqUN8ybAQQHogEWW0p7W7RXTTXLCAPotNy4hTo0i7QaMJ1oVbTPoaJA/c\n\tz+IA==", "X-Gm-Message-State": "AOJu0Yxt82MbTZT8pgR/Upx7VP8NAPWHCMf8onpnH6zD2nyrdQOI5ThM\n\t2/pzbHT08YHFGURkhVDY4UReycsJnFaP+RA+Q1hh9r2V3VGeWeQYBbyVDKbKv+dIigYPDSleqic\n\tnBvln", "X-Gm-Gg": "ASbGncssO0DXqf8pJyxlixZdbcGvzsaIsqUZu+Xe6QLFvB34WqJK9ZT3/xcQY7h7xo/\n\tXFVhVrBh+XAVm+qSKWqCwocwszMmdMw6nWj8D8JCBPAtIPMPXfJ9cDLSpf9O4gZW9MBYbLmnb26\n\tE9bcLV7k6fLeUjI9o5UZJNpv1EQHZGaGKLN5a8y3NIE5y8A8SPtaGw6Rf3BMJt8mKNn9mSkwx9A\n\tvtSBdml/fUuhzF33E3bYxtxYJ+2Di3hs/WQqj8OMcpdh7BmM8SsPsGRK9oaOFRhr00iEwCWjrbj\n\tr8JANsQvrlnoEzyE7yqHavze0DE+8ggoQrdoj6NAINQwpcDDzf0Ue6/bk1bIzXNdj2/7mkucdAB\n\tmKO081KSsuxlGxWvS0HagbXeUINpe8QMXERS0O6hJZrFyps55Rs5o3nHQHVcLnAtmgDNYSRib2z\n\tQfy8lvEtRrGEOR1H0oKuU85O1U6j+oicegmDx94Fn1XGlb6VpAtGdbXmmqkZ1Oq2A2H7A=", "X-Google-Smtp-Source": "AGHT+IFtMjFGiNlPil8Yuq/yFjoaejOkbWhCH5ynd0ZXcP+6ALGDnkVGJ0AC8iVv0jB3Y4j00+SD8A==", "X-Received": "by 2002:a5d:5d10:0:b0:42b:496e:517c with SMTP id\n\tffacd0b85a97d-42cc1ac9146mr44289434f8f.13.1764682344687; \n\tTue, 02 Dec 2025 05:32:24 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tMilan Zamazal <mzamazal@redhat.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v3 21/22] libcamera: software_isp: lut: Make gamma from\n\tlut.cpp available in debayer params", "Date": "Tue, 2 Dec 2025 13:31:52 +0000", "Message-ID": "<20251202133157.661407-22-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20251202133157.661407-1-bryan.odonoghue@linaro.org>", "References": "<20251202133157.661407-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Provide the gamma used in IPA to Bayer parameters. We will pass Gamma into\nthe shader via a uniform and can then tweak that value from outside at\nwill.\n\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n include/libcamera/internal/software_isp/debayer_params.h | 1 +\n src/ipa/simple/algorithms/lut.cpp | 2 ++\n src/libcamera/software_isp/debayer.cpp | 5 +++++\n 3 files changed, 8 insertions(+)", "diff": "diff --git a/include/libcamera/internal/software_isp/debayer_params.h b/include/libcamera/internal/software_isp/debayer_params.h\nindex 5a0d9438f..d5dad1a98 100644\n--- a/include/libcamera/internal/software_isp/debayer_params.h\n+++ b/include/libcamera/internal/software_isp/debayer_params.h\n@@ -58,6 +58,7 @@ struct DebayerParams {\n \t */\n \tMatrix<float, 3, 3> ccm;\n \tRGB<float> blackLevel;\n+\tfloat gamma;\n };\n \n } /* namespace libcamera */\ndiff --git a/src/ipa/simple/algorithms/lut.cpp b/src/ipa/simple/algorithms/lut.cpp\nindex 49482d711..ea5a86b20 100644\n--- a/src/ipa/simple/algorithms/lut.cpp\n+++ b/src/ipa/simple/algorithms/lut.cpp\n@@ -147,6 +147,8 @@ void Lut::prepare(IPAContext &context,\n \t\t\tparams->gammaLut[i] = gammaTable[i / div];\n \t\t}\n \t}\n+\n+\tparams->gamma = context.configuration.gamma;\n }\n \n void Lut::process([[maybe_unused]] IPAContext &context,\ndiff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp\nindex 16bf7a218..7e8d81c09 100644\n--- a/src/libcamera/software_isp/debayer.cpp\n+++ b/src/libcamera/software_isp/debayer.cpp\n@@ -110,6 +110,11 @@ namespace libcamera {\n * \\brief Blacklevel gains for the GPUISP\n */\n \n+/**\n+ * \\var DebayerParams::gamma\n+ * \\brief Gamma value for the GPUISP\n+ */\n+\n /**\n * \\class Debayer\n * \\brief Base debayering class\n", "prefixes": [ "v3", "21/22" ] }