Patch Detail
Show a patch.
GET /api/1.1/patches/25298/?format=api
{ "id": 25298, "url": "https://patchwork.libcamera.org/api/1.1/patches/25298/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25298/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251202133157.661407-13-bryan.odonoghue@linaro.org>", "date": "2025-12-02T13:31:43", "name": "[v3,12/22] libcamera: software_isp: Move DMA Sync code to Debayer base class", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "ff01a0166ba8b70a5fa961a8b3b8890bbc7d6298", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25298/mbox/", "series": [ { "id": 5630, "url": "https://patchwork.libcamera.org/api/1.1/series/5630/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5630", "date": "2025-12-02T13:31:31", "name": "GPUISP precursor series", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5630/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25298/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25298/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 93321BD80A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 2 Dec 2025 13:32:26 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1648B60D23;\n\tTue, 2 Dec 2025 14:32:26 +0100 (CET)", "from mail-wr1-x431.google.com (mail-wr1-x431.google.com\n\t[IPv6:2a00:1450:4864:20::431])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2C62460D14\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 2 Dec 2025 14:32:15 +0100 (CET)", "by mail-wr1-x431.google.com with SMTP id\n\tffacd0b85a97d-42e33956e76so1121408f8f.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 02 Dec 2025 05:32:15 -0800 (PST)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-42e1c5c30c4sm33363322f8f.9.2025.12.02.05.32.13\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 02 Dec 2025 05:32:14 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"Qg7Xczmw\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1764682334; x=1765287134;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=Bh1xFO5NOzK/gF5i4+/9KWqgioiivN0r41v6p9dQA20=;\n\tb=Qg7XczmwuM05CSUxUqjJLsahc/dlJRRAXCsYTScOgGSZ+9LmTAHbRrDxvDvo1i7jEM\n\t8Z+8evIfCGgy3OfqWjq4SKlzdK82BgA0zIoTD9oBa0zlpKzbzF+m1v4rpYxrLpwQlOWa\n\t+LFh2f8bi3BEr6TLKyVCbL867kCYENkWM1avRNsSWFT2CC2LmKJ113orhEkM23xtijCX\n\trGIxr17gF2iKmfkmt97eMLC3Ksim7+bb9bpt/4UHjrIverOAVoysNjo8lxRUj6Lbmswk\n\tWrQSMK2k/l+BHUAwtQ0rYWcrpX3h9wl6afoH7/ySqq0XkaSj3K++3WlDruRAblgkas4y\n\tj6Fg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1764682334; x=1765287134;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=Bh1xFO5NOzK/gF5i4+/9KWqgioiivN0r41v6p9dQA20=;\n\tb=O6hvwxDS+ddojk8mjj5tpX3ZpAz+5YD4HnrgnuLKNtL0EGRmQ2QVwffM3YOdIiY+7Z\n\tZtTwYApdnBr2m90f5DpeqPca1SE5ZKh+11qbyQXoR0buLNy8zO2BRw5sQB0RCtweeoVV\n\ty6xZiwrPaDnCwkVwu/Z6I1i7kc7G7SQ093lGjlI5Z6FH42LE+zB2ZxhHuAynB4ohFUAs\n\tSwm1cC2/5qrui9Z79KwzIF3MAjmlULOvIGAfnwHIyD0kbHVzPi8CMcGkYw2QJ+XD/wnB\n\tqexrpF3LSG6nKbAzMzAt7KhbQqY0snBDJCGZInPFZZpDHheSZr+YiNtWJNLCFstJI/zT\n\tn1pQ==", "X-Gm-Message-State": "AOJu0YyYqNw4o3kCzIEf7CLylrGrR7PqBbKa3VO3+Lch7D2nhb6E0UPd\n\tMPNe/V94r5Ha6E4R3IPitcF6bS9K56g4rpiVDcf7qq2Sasv24CCYkzz25pdrtSdsU1AZTTAIAnm\n\tqF3Nu", "X-Gm-Gg": "ASbGncsWgJPHBORS8fQF6TRxRdhvy/o/ZcVWbkicimiwzy2YFNuL02RDVe0pDTqYeEE\n\txV9+qfzepaUcz+WCh0Oq8ocNWlEGJAT60oQ/j7ybq26IvU0Ydf8lkoG40VKzshoKP3OkQsMsJvb\n\tmSVd4JD4JMdEpIsm6mFuysYc4EClX2wqtBRXJq+buQmzNGi3Usbrmu9igS/AGEZCSf3tHyVtjQB\n\t6RH1HKnHJWwrEeWj48gs3+c86LS3N4vpRvchhVotGs4OPslzrvmwhA4mnVailLKECGcQuJRWRNe\n\tJVvS5Q2sIyr51u0YLX1J26zfkAgoVYw8ZaOQ9ouEPDlYg1iJmGd+XKWSskfUodlgijJnYeRWaWs\n\triuW5AQjKxLS0qpVti+cxv5AKLjnzoq2X7JYSNB4OasN7XujltjbLNqBqjK/ul0mlEP4ELPDjBv\n\tCRWxZLYtpI5tsRz47ZWJlLZ8RJopPdPeQyvvo472TQ0jXgIev4doSK55+dTaK3bPlNgFk=", "X-Google-Smtp-Source": "AGHT+IFelnZN6DqrBF1bCehBrJ+WoHesdp+6IiCB0RsJv2KHboHSG5Q+BLe4lMFu0KWAC/a9McDqWQ==", "X-Received": "by 2002:a05:6000:2013:b0:3ec:de3c:c56 with SMTP id\n\tffacd0b85a97d-42cc1acce0emr45239021f8f.16.1764682334427; \n\tTue, 02 Dec 2025 05:32:14 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tMilan Zamazal <mzamazal@redhat.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v3 12/22] libcamera: software_isp: Move DMA Sync code to\n\tDebayer base class", "Date": "Tue, 2 Dec 2025 13:31:43 +0000", "Message-ID": "<20251202133157.661407-13-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.52.0", "In-Reply-To": "<20251202133157.661407-1-bryan.odonoghue@linaro.org>", "References": "<20251202133157.661407-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "We can reuse the DMA Sync code in the GPUISP. Move the code we need to\nthe base class.\n\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/debayer.cpp | 13 +++++++++++++\n src/libcamera/software_isp/debayer.h | 2 ++\n src/libcamera/software_isp/debayer_cpu.cpp | 6 +-----\n 3 files changed, 16 insertions(+), 5 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp\nindex cea30af67..544921656 100644\n--- a/src/libcamera/software_isp/debayer.cpp\n+++ b/src/libcamera/software_isp/debayer.cpp\n@@ -364,4 +364,17 @@ void Debayer::setParams(DebayerParams ¶ms)\n \tgammaLut_ = params.gammaLut;\n }\n \n+/**\n+ * \\fn void Debayer::dmaSyncBegin(DebayerParams ¶ms)\n+ * \\brief Common CPU/GPU Dma Sync Buffer begin\n+ */\n+void Debayer::dmaSyncBegin(std::vector<DmaSyncer> &dmaSyncers, FrameBuffer *input, FrameBuffer *output)\n+{\n+\tfor (const FrameBuffer::Plane &plane : input->planes())\n+\t\tdmaSyncers.emplace_back(plane.fd, DmaSyncer::SyncType::Read);\n+\n+\tfor (const FrameBuffer::Plane &plane : output->planes())\n+\t\tdmaSyncers.emplace_back(plane.fd, DmaSyncer::SyncType::Write);\n+}\n+\n } /* namespace libcamera */\ndiff --git a/src/libcamera/software_isp/debayer.h b/src/libcamera/software_isp/debayer.h\nindex 6903caae8..d2893d81b 100644\n--- a/src/libcamera/software_isp/debayer.h\n+++ b/src/libcamera/software_isp/debayer.h\n@@ -20,6 +20,7 @@\n #include <libcamera/geometry.h>\n #include <libcamera/stream.h>\n \n+#include \"libcamera/internal/dma_buf_allocator.h\"\n #include \"libcamera/internal/global_configuration.h\"\n #include \"libcamera/internal/software_isp/benchmark.h\"\n #include \"libcamera/internal/software_isp/debayer_params.h\"\n@@ -86,6 +87,7 @@ private:\n \n protected:\n \tvoid setParams(DebayerParams ¶ms);\n+\tvoid dmaSyncBegin(std::vector<DmaSyncer> &dmaSyncers, FrameBuffer *input, FrameBuffer *output);\n };\n \n } /* namespace libcamera */\ndiff --git a/src/libcamera/software_isp/debayer_cpu.cpp b/src/libcamera/software_isp/debayer_cpu.cpp\nindex 6be5cdbd5..8f1b4e53d 100644\n--- a/src/libcamera/software_isp/debayer_cpu.cpp\n+++ b/src/libcamera/software_isp/debayer_cpu.cpp\n@@ -22,7 +22,6 @@\n #include <libcamera/formats.h>\n \n #include \"libcamera/internal/bayer_format.h\"\n-#include \"libcamera/internal/dma_buf_allocator.h\"\n #include \"libcamera/internal/framebuffer.h\"\n #include \"libcamera/internal/global_configuration.h\"\n #include \"libcamera/internal/mapped_framebuffer.h\"\n@@ -752,11 +751,8 @@ void DebayerCpu::process(uint32_t frame, FrameBuffer *input, FrameBuffer *output\n \tbench_.startFrame();\n \n \tstd::vector<DmaSyncer> dmaSyncers;\n-\tfor (const FrameBuffer::Plane &plane : input->planes())\n-\t\tdmaSyncers.emplace_back(plane.fd, DmaSyncer::SyncType::Read);\n \n-\tfor (const FrameBuffer::Plane &plane : output->planes())\n-\t\tdmaSyncers.emplace_back(plane.fd, DmaSyncer::SyncType::Write);\n+\tdmaSyncBegin(dmaSyncers, input, output);\n \n \tsetParams(params);\n \n", "prefixes": [ "v3", "12/22" ] }