Patch Detail
Show a patch.
GET /api/1.1/patches/2529/?format=api
{ "id": 2529, "url": "https://patchwork.libcamera.org/api/1.1/patches/2529/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2529/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20200108101725.6404-2-jacopo@jmondi.org>", "date": "2020-01-08T10:17:23", "name": "[libcamera-devel,v2,1/3] v4l2: camera_proxy: Fix try_fmt format conversion", "commit_ref": "769ca0a5503ce99fd9687aa3a3a96eea6242116c", "pull_url": null, "state": "accepted", "archived": false, "hash": "4e4d27b27cf48cd51078c01a806bf48a5889dc24", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2529/mbox/", "series": [ { "id": 609, "url": "https://patchwork.libcamera.org/api/1.1/series/609/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=609", "date": "2020-01-08T10:17:22", "name": "v4l2: minor fixes", "version": 2, "mbox": "https://patchwork.libcamera.org/series/609/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2529/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2529/checks/", "tags": {}, "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 377BD6045F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 8 Jan 2020 11:15:07 +0100 (CET)", "from uno.lan (93-34-114-233.ip49.fastwebnet.it [93.34.114.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id 81371100011;\n\tWed, 8 Jan 2020 10:15:06 +0000 (UTC)" ], "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 8 Jan 2020 11:17:23 +0100", "Message-Id": "<20200108101725.6404-2-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.24.0", "In-Reply-To": "<20200108101725.6404-1-jacopo@jmondi.org>", "References": "<20200108101725.6404-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 1/3] v4l2: camera_proxy: Fix try_fmt\n\tformat conversion", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 08 Jan 2020 10:15:07 -0000" }, "content": "The set pixelformat field of struct v4l2_pix_format structure was\nwrongly converted to PixelFormat by calling v4l2ToDrm(), with an already\nconverted 'format' argument.\n\nFix this by calling the right drmToV4l2() conversion function.\n\nFixes: 0ce8f2390b52 (\"v4l2: v4l2_compat: Add V4L2 compatibility layer\")\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/v4l2/v4l2_camera_proxy.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\nindex 8d1b40da7367..0f1d5ea4be39 100644\n--- a/src/v4l2/v4l2_camera_proxy.cpp\n+++ b/src/v4l2/v4l2_camera_proxy.cpp\n@@ -282,7 +282,7 @@ int V4L2CameraProxy::vidioc_try_fmt(struct v4l2_format *arg)\n \n \targ->fmt.pix.width = size.width;\n \targ->fmt.pix.height = size.height;\n-\targ->fmt.pix.pixelformat = v4l2ToDrm(format);\n+\targ->fmt.pix.pixelformat = drmToV4L2(format);\n \targ->fmt.pix.field = V4L2_FIELD_NONE;\n \targ->fmt.pix.bytesperline = bplMultiplier(drmToV4L2(format)) *\n \t\t\t\t arg->fmt.pix.width;\n", "prefixes": [ "libcamera-devel", "v2", "1/3" ] }