Patch Detail
Show a patch.
GET /api/1.1/patches/25276/?format=api
{ "id": 25276, "url": "https://patchwork.libcamera.org/api/1.1/patches/25276/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25276/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251129220100.2685228-1-rui.wang@ideasonboard.com>", "date": "2025-11-29T22:01:00", "name": "[v2] media: rkisp1: Fix filter mode register configuration", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "facb31070664d0ff0fb7924266a8c4f3ff7aa837", "submitter": { "id": 241, "url": "https://patchwork.libcamera.org/api/1.1/people/241/?format=api", "name": "Rui Wang", "email": "rui.wang@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25276/mbox/", "series": [ { "id": 5621, "url": "https://patchwork.libcamera.org/api/1.1/series/5621/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5621", "date": "2025-11-29T22:01:00", "name": "[v2] media: rkisp1: Fix filter mode register configuration", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5621/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25276/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25276/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 13CEBC3257\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 29 Nov 2025 22:01:20 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CBE7A60A85;\n\tSat, 29 Nov 2025 23:01:18 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4CB7C60805\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 29 Nov 2025 23:01:17 +0100 (CET)", "from rui-Precision-7560.local (unknown [209.216.103.65])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5575A42B;\n\tSat, 29 Nov 2025 22:59:04 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pgWAnG2g\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1764453544;\n\tbh=vmUChq+NUWys4oSASCIvZLhjIOmRnSQ9t2eLNaGea18=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=pgWAnG2gnYc5FV43CDlIGJAYlF6hoLeR1Ky8rUc4qjFYFhq//bgCX8Ycto3i24QJZ\n\tkM+YqpngYLuFuyo5HHGzUiimjIvchSoTBM8JkIedLCcP+YPwXmDFIzpzC3uHJMMene\n\tQ38mRBM4zYenK5J5N2uici3a8slQLHSs5sV1Vm/c=", "From": "Rui Wang <rui.wang@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Rui Wang <rui.wang@ideasonboard.com>", "Subject": "[PATCH v2] media: rkisp1: Fix filter mode register configuration", "Date": "Sat, 29 Nov 2025 17:01:00 -0500", "Message-ID": "<20251129220100.2685228-1-rui.wang@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The current implementation in rkisp1_flt_config() treats the\narg->mode field as a boolean for enabling DNR mode, which doesn't\nproperly separate the filter enable bit from the DNR mode bit in\nthe RKISP1_CIF_ISP_FILT_MODE register.\n\n- Bit 0 of arg->mode controls the filter enable\n (RKISP1_CIF_ISP_FLT_ENA)\n- Bit 1 of arg->mode controls the DNR mode\n (RKISP1_CIF_ISP_FLT_MODE_DNR)\n\nThis ensures that the filter enable and DNR mode can be configured\nindependently through the mode field.\n\nSigned-off-by: Rui Wang <rui.wang@ideasonboard.com>\n---\n drivers/media/platform/rockchip/rkisp1/rkisp1-params.c | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c\nindex c9f88635224c..979a22a5d04d 100644\n--- a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c\n+++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c\n@@ -412,6 +412,7 @@ static void rkisp1_flt_config(struct rkisp1_params *params,\n \t\t arg->lum_weight);\n \n \trkisp1_write(params->rkisp1, RKISP1_CIF_ISP_FILT_MODE,\n+\t\t (arg->mode & RKISP1_CIF_ISP_FLT_ENA) |\n \t\t (arg->mode ? RKISP1_CIF_ISP_FLT_MODE_DNR : 0) |\n \t\t RKISP1_CIF_ISP_FLT_CHROMA_V_MODE(arg->chr_v_mode) |\n \t\t RKISP1_CIF_ISP_FLT_CHROMA_H_MODE(arg->chr_h_mode) |\n", "prefixes": [ "v2" ] }