Patch Detail
Show a patch.
GET /api/1.1/patches/25250/?format=api
{ "id": 25250, "url": "https://patchwork.libcamera.org/api/1.1/patches/25250/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25250/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251127023739.179652-14-bryan.odonoghue@linaro.org>", "date": "2025-11-27T02:37:28", "name": "[v5,13/24] libcamera: software_isp: debayer_egl: Make DebayerEGL an environment option", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "aea7f1ea4e16a1b7f2117eb68a565f74fd065fe1", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25250/mbox/", "series": [ { "id": 5617, "url": "https://patchwork.libcamera.org/api/1.1/series/5617/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5617", "date": "2025-11-27T02:37:15", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 5, "mbox": "https://patchwork.libcamera.org/series/5617/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25250/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25250/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A22AFC32DE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 27 Nov 2025 02:38:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1B63E60B0F;\n\tThu, 27 Nov 2025 03:38:17 +0100 (CET)", "from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com\n\t[IPv6:2a00:1450:4864:20::32d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7E4B560AB8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 27 Nov 2025 03:38:13 +0100 (CET)", "by mail-wm1-x32d.google.com with SMTP id\n\t5b1f17b1804b1-4775ae77516so3297035e9.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 26 Nov 2025 18:38:13 -0800 (PST)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4790552c3c9sm58186345e9.0.2025.11.26.18.38.12\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 26 Nov 2025 18:38:12 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"VUy9+i1+\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1764211093; x=1764815893;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=+2GcZ5YL21UUK5YHwLU7zkEQf8v6DCPa5f56k85rtTM=;\n\tb=VUy9+i1+QwVOT5Fy/vLoNtEK/VcOElbPhb98lp+i12v8E8SkY+z2NVvnvpchn+VIrG\n\tHcaAxjJ/LOvFMfam+YApFAAWFL+YmgBbzZfJurMgBDkwXP53xODyvunGcQiPs8O8oO3l\n\toJ4qFVhrcOGGch/t0Js09lyuhwikvnk9RQzwansS29EIfF6GwRf/HoL7aCFRcaylFDrs\n\tuI9ORvnR8rEswlBp8hAadr6EoYfDcwVNrwoVNXkZvc/tWZ9Pi8Tl/lhpFqh2czmSU4cD\n\t33V6N84jxsSQ1hfm0yslHmJ9GoBEX/jJhrHzUm+d189y/iZqIxumiB+s9AHBxD832y/S\n\twwzg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1764211093; x=1764815893;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=+2GcZ5YL21UUK5YHwLU7zkEQf8v6DCPa5f56k85rtTM=;\n\tb=Ch3uN67v+QoKegGSF2HC4z8UDJ37FdiEuto4FoiHBhxsmR7UmSCNvkOkpingCpyJ7w\n\t+4XgX0AXdJjNruf7jC83ta1FZPcU9PRQJa/T84+pixhBU6ieBZJnG2o8LW7KejofwAxy\n\tln676C1ISKbSMhQYo6JzRjT+0k+jkoAgMH54qJoHAMIYSyefSHbe0ubMHZH/6690Z5U0\n\tMeUJ6b+abF+A6G11zdBujh74sk21F3fSh4ezgVvMz+2QT89DsZZDpWqTcaMzTOj5jOKl\n\tk/f3gT7mUIpSXqbbZrOo2CKHoRH0TKgLdoAqyr7GEQAULqQtxxX1Intiu53cXFZpFQRF\n\tPTcw==", "X-Gm-Message-State": "AOJu0YyEZcoJjqEr/1wMW+SnGdJTMfuEv/KcSvlFYOhVBrPhB+No8yUp\n\tTR/Uh0JJvd8TPCj2ceUHHD8emsaoE0jTZs/G5mNNvjSXs7Mt/yLw8BMrsOn1SdhDYfeZ8PcooXm\n\tDM8r1Nsc=", "X-Gm-Gg": "ASbGnct9BrNgnMkLZog5Sdf+oxoyPMLudft1FmZxgjpSg/YfkyASC3f4LvHpOMSvXxJ\n\tBP7TQPQTJ1fHkdvIymgcMzlac4PZj6/bUgGIIi00LgyljLXgecQ7oEWi1iFJ6pEAA8aAvqJ6bJ9\n\tnpwpWEi6hKzmiIk2xWrneke6AWexFyN2yeSGuZ4UtgLsb7QBVUOBWWg0NAtmA14b1/76w0tHBu6\n\tJOXXuuo7sYNzdBDLMhIRpB8PQrj/QexT3SBYt6axYPIosn4HuHDtZA9fXzuQREoP/Gc9W/uKCst\n\tAmzXAHLaM8TgnG3vXFmn5JXUoPqnMBzBUhGMKGrSPyEsX4ibLz5Un5d20/LhvAfqorCAZ/pAuBz\n\tGRemx7baTaE3wq2fif6bVi4k8la9URbVI9FUbWeuKK5c1TAvhg/+3m4dN3juiNEAvZwKmDiT27e\n\tmsvijuYVDEfA9eVGuUsfdxUxxVOSah3fkFtbBRJe406BVn/R3DwTtpN0iEnBci+oVfmeg=", "X-Google-Smtp-Source": "AGHT+IEhTfCvKyTW0GwCobwbCDuHVZ4FQjtXb5BxqV0kc/rf16ZpPOnGed4TPK058QJ9YizHiCjWqg==", "X-Received": "by 2002:a05:600c:1f85:b0:477:7b30:a6fe with SMTP id\n\t5b1f17b1804b1-477c1116013mr197235665e9.18.1764211092864; \n\tWed, 26 Nov 2025 18:38:12 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz,\n\tBryan O'Donoghue <bryan.odonoghue@linaro.org>", "Subject": "[PATCH v5 13/24] libcamera: software_isp: debayer_egl: Make\n\tDebayerEGL an environment option", "Date": "Thu, 27 Nov 2025 02:37:28 +0000", "Message-ID": "<20251127023739.179652-14-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.51.2", "In-Reply-To": "<20251127023739.179652-1-bryan.odonoghue@linaro.org>", "References": "<20251127023739.179652-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "If GPUISP support is available make it so an environment variable can\nswitch it on.\n\nGiven we don't have full feature parity with CPUISP just yet on pixel\nformat output, we should default to CPUISP mode giving the user the option\nto switch on GPUISP by setting LIBCAMERA_SOFTISP_MODE=gpu\n\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/software_isp.cpp | 24 ++++++++++++++++++++-\n 1 file changed, 23 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex aa4a40cb6..223c1d4be 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -15,6 +15,7 @@\n \n #include <libcamera/base/log.h>\n #include <libcamera/base/thread.h>\n+#include <libcamera/base/utils.h>\n \n #include <libcamera/controls.h>\n #include <libcamera/formats.h>\n@@ -25,6 +26,9 @@\n #include \"libcamera/internal/software_isp/debayer_params.h\"\n \n #include \"debayer_cpu.h\"\n+#if HAVE_DEBAYER_EGL\n+#include \"debayer_egl.h\"\n+#endif\n \n /**\n * \\file software_isp.cpp\n@@ -117,7 +121,25 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n \t}\n \tstats->statsReady.connect(this, &SoftwareIsp::statsReady);\n \n-\tdebayer_ = std::make_unique<DebayerCpu>(std::move(stats), configuration);\n+#if HAVE_DEBAYER_EGL\n+\tconst char *softISPMode = utils::secure_getenv(\"LIBCAMERA_SOFTISP_MODE\");\n+\n+\tif (softISPMode && !strcmp(softISPMode, \"gpu\")) {\n+\t\tdebayer_ = std::make_unique<DebayerEGL>(std::move(stats), configuration);\n+\t\tif (!debayer_) {\n+\t\t\tLOG(SoftwareIsp, Error) << \"Failed to instantiate GPUISP\";\n+\t\t\treturn;\n+\t\t}\n+\t}\n+#endif\n+\tif (!debayer_)\n+\t\tdebayer_ = std::make_unique<DebayerCpu>(std::move(stats), configuration);\n+\n+\tif (!debayer_) {\n+\t\tLOG(SoftwareIsp, Error) << \"Failed to create Debayer object\";\n+\t\treturn;\n+\t}\n+\n \tdebayer_->inputBufferReady.connect(this, &SoftwareIsp::inputReady);\n \tdebayer_->outputBufferReady.connect(this, &SoftwareIsp::outputReady);\n \n", "prefixes": [ "v5", "13/24" ] }