Patch Detail
Show a patch.
GET /api/1.1/patches/25247/?format=api
{ "id": 25247, "url": "https://patchwork.libcamera.org/api/1.1/patches/25247/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25247/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251127023739.179652-11-bryan.odonoghue@linaro.org>", "date": "2025-11-27T02:37:25", "name": "[v5,10/24] libcamera: shaders: Add support for contrast", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "206add1a595e3ba2b211f99d100fde0161161c03", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25247/mbox/", "series": [ { "id": 5617, "url": "https://patchwork.libcamera.org/api/1.1/series/5617/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5617", "date": "2025-11-27T02:37:15", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 5, "mbox": "https://patchwork.libcamera.org/series/5617/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25247/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25247/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9168EC0F2A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 27 Nov 2025 02:38:12 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3EF3E60AD0;\n\tThu, 27 Nov 2025 03:38:12 +0100 (CET)", "from mail-wm1-x332.google.com (mail-wm1-x332.google.com\n\t[IPv6:2a00:1450:4864:20::332])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3626560A8B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 27 Nov 2025 03:38:09 +0100 (CET)", "by mail-wm1-x332.google.com with SMTP id\n\t5b1f17b1804b1-47118259fd8so2250385e9.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 26 Nov 2025 18:38:09 -0800 (PST)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4790552c3c9sm58186345e9.0.2025.11.26.18.38.06\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 26 Nov 2025 18:38:07 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"ICERSK2Q\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1764211088; x=1764815888;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=/PZjb99W2l+LEd1sej3PwFkHQEZZRLTROogT00grB9Y=;\n\tb=ICERSK2Q3X7yYfO5KKlgjCrvYAN/njv9h32XsiGwIbSsmg7d9d2n8RuveMusd7gdWn\n\tSCnFAHj2bpO3Hd+2hil3HErRlpmU7z6CRyiM5aZDeid92fF7b0OrkFov9ra9NABHwKWy\n\tWGCU/OamP6dGzkU4RGUJuTWzFE5kMQnQoIGCwIeseL4wTkYjdEM3/zemu5GgadIndrzI\n\tgX9b0RBDc1giNJBUkg811Im0YL1ax90E9nYgKsiRCKmNGBpwyZ07Rux7Up/R+t0LwcC+\n\tI/5reUgoCzNLg7TxhKkF/v1QoJgBJN5Vm4GJGumhQ+6jN75ZuGQkWvRHRCii72EVgubU\n\t1smQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1764211088; x=1764815888;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=/PZjb99W2l+LEd1sej3PwFkHQEZZRLTROogT00grB9Y=;\n\tb=NkeFtFF5qsLHSzEZVkh7jOQIYv6/rHyfqa9+H6wEARE4wq6KErpZwXZtmUSbhzmORX\n\tB09u41z6PnI6eQnwVdToC8fuMo1dIQDI6QJPiRbqqOhrEOCIn8mEzdrWYA4a0ElT8CG0\n\to5pEqtXAAkPeyVFAusiYOhrGFJNUnyYKnxGaKojqHM5X9LkE7BcVDXMgwTZBipaUjWj5\n\tnFkS21wZaT3PPMX3dexO4OKPLCZvkmhLRZD+azaWeDfM7lKDFOMd1IzcqqHY08BHms12\n\tPK1+DamJKyemQnNflpqBWsw4Pz7ETJVb2zmU7O1TzkpyZbEjUmAe6+V/F5BqDCV7Oy/V\n\t7dSQ==", "X-Gm-Message-State": "AOJu0YwVM7GzsERN2cieKZHwRwG0+GVHqTZtDOtWJ4O3tgL4JXKmz860\n\tYlNELw3cg3pBkDL5Ctznp5WoUGpt8neuocOHbkS2T13WlGWm6AuFROVchWiJazoPQCnF9ttvfLA\n\txFUPYieU=", "X-Gm-Gg": "ASbGncu4EhdC8qdA7pC6VYDrBGFAgzvz/B7gWRPeaZPMoyEWMmBJbZUPSFfgpFY2loS\n\tkSTZMgIHrqgIi/WxtLnuvBQsElyxjSy2fqg0zftajx3cSGP76seXOfjqbBGB1nN579tvw6mM715\n\t9+oSiWZprW31fRqQtRJok8wx0SiGCVyehblP13UdWmyE+4rB8KT7DfwkJD5cR7qQfl9zvde5Bi7\n\tQrn8XoqP0HwVTmzqICtBhrOnpIPBeEujJsOP0rd4OArExcwA+hxMQ/R2lPL2DA9smPvAHH7IZeV\n\tEpNpowjldhLmwypDM01S2nRM5zSwZ2hpXiZdc3+39TiAN88eIZYQohs9HWw2RUuM6fReQ6aZJAs\n\ti81co8Uxh0dGQq3Flk3Rcbz2Wr2eUwjTOuAjmW6LhM47ql/ddg7zX03NI8T4a1kEkvkycsTzDHv\n\trBKxZ1fHq+pgHz8NQKMiAah20eMhoPtRjzpyXzy3270ZkK6JIRc6jBSrEa59H31ZpBlhE=", "X-Google-Smtp-Source": "AGHT+IED1IeoYlpP7jt3zgiKEDbrxcxz+fxhTOzb4FKxv5P69Hil4JGrPC7tl0dLP/0wHQWbzNVmuQ==", "X-Received": "by 2002:a05:600c:6011:b0:477:abea:9028 with SMTP id\n\t5b1f17b1804b1-47904ac44d6mr59225615e9.6.1764211088560; \n\tWed, 26 Nov 2025 18:38:08 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tMilan Zamazal <mzamazal@redhat.com>", "Subject": "[PATCH v5 10/24] libcamera: shaders: Add support for contrast", "Date": "Thu, 27 Nov 2025 02:37:25 +0000", "Message-ID": "<20251127023739.179652-11-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.51.2", "In-Reply-To": "<20251127023739.179652-1-bryan.odonoghue@linaro.org>", "References": "<20251127023739.179652-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Apply contrast after black-level and CCM operations.\n\nSuggested-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/shaders/bayer_1x_packed.frag | 19 +++++++++++++++++++\n src/libcamera/shaders/bayer_unpacked.frag | 19 +++++++++++++++++++\n 2 files changed, 38 insertions(+)", "diff": "diff --git a/src/libcamera/shaders/bayer_1x_packed.frag b/src/libcamera/shaders/bayer_1x_packed.frag\nindex 069b880ff..741896d01 100644\n--- a/src/libcamera/shaders/bayer_1x_packed.frag\n+++ b/src/libcamera/shaders/bayer_1x_packed.frag\n@@ -71,6 +71,19 @@ uniform sampler2D blue_param;\n uniform mat3 ccm;\n uniform vec3 blacklevel;\n uniform float gamma;\n+uniform float contrast;\n+\n+float apply_contrast(float normalise, float contrast_in)\n+{\n+\t// Convert 0..2 contrast to 0..infinity; avoid actual infinity at tan(pi/2)\n+\tfloat contrastExp = tan(clamp(contrast_in * 0.78539816339744830962, 0.0, 1.5707963267948966 - 0.00001));\n+\n+\t// Apply simple S-curve\n+\tif (normalise < 0.5)\n+\t\treturn 0.5 * pow(normalise / 0.5, contrastExp);\n+\telse\n+\t\treturn 1.0 - 0.5 * pow((1.0 - normalise) / 0.5, contrastExp);\n+}\n \n void main(void)\n {\n@@ -266,6 +279,12 @@ void main(void)\n \trgb.g = (rin * ccm[1][0]) + (gin * ccm[1][1]) + (bin * ccm[1][2]);\n \trgb.b = (rin * ccm[2][0]) + (gin * ccm[2][1]) + (bin * ccm[2][2]);\n \n+\t/* Contrast */\n+\trgb = clamp(rgb, 0.0, 1.0);\n+\trgb.r = apply_contrast(rgb.r, contrast);\n+\trgb.g = apply_contrast(rgb.g, contrast);\n+\trgb.b = apply_contrast(rgb.b, contrast);\n+\n \t/* Apply gamma after colour correction */\n \trgb = pow(rgb, vec3(gamma));\n \ndiff --git a/src/libcamera/shaders/bayer_unpacked.frag b/src/libcamera/shaders/bayer_unpacked.frag\nindex 86bf2c31c..43ed99e33 100644\n--- a/src/libcamera/shaders/bayer_unpacked.frag\n+++ b/src/libcamera/shaders/bayer_unpacked.frag\n@@ -30,6 +30,19 @@ varying vec4 xCoord;\n uniform mat3 ccm;\n uniform vec3 blacklevel;\n uniform float gamma;\n+uniform float contrast;\n+\n+float apply_contrast(float normalise, float contrast_in)\n+{\n+ // Convert 0..2 contrast to 0..infinity; avoid actual infinity at tan(pi/2)\n+ float contrastExp = tan(clamp(contrast_in * 0.78539816339744830962, 0.0, 1.5707963267948966 - 0.00001));\n+\n+ // Apply simple S-curve\n+ if (normalise < 0.5)\n+ return 0.5 * pow(normalise / 0.5, contrastExp);\n+ else\n+ return 1.0 - 0.5 * pow((1.0 - normalise) / 0.5, contrastExp);\n+}\n \n void main(void) {\n vec3 rgb;\n@@ -161,6 +174,12 @@ void main(void) {\n rgb.g = (rin * ccm[1][0]) + (gin * ccm[1][1]) + (bin * ccm[1][2]);\n rgb.b = (rin * ccm[2][0]) + (gin * ccm[2][1]) + (bin * ccm[2][2]);\n \n+ /* Contrast */\n+ rgb = clamp(rgb, 0.0, 1.0);\n+ rgb.r = apply_contrast(rgb.r, contrast);\n+ rgb.g = apply_contrast(rgb.g, contrast);\n+ rgb.b = apply_contrast(rgb.b, contrast);\n+\n /* Apply gamma after colour correction */\n rgb = pow(rgb, vec3(gamma));\n \n", "prefixes": [ "v5", "10/24" ] }