Patch Detail
Show a patch.
GET /api/1.1/patches/25244/?format=api
{ "id": 25244, "url": "https://patchwork.libcamera.org/api/1.1/patches/25244/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25244/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251127023739.179652-8-bryan.odonoghue@linaro.org>", "date": "2025-11-27T02:37:22", "name": "[v5,07/24] libcamera: shaders: Extend bayer shaders to support swapping R and B on output", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "e8a4108a9a4db4a142a90f1e97d86dc8c03109cf", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25244/mbox/", "series": [ { "id": 5617, "url": "https://patchwork.libcamera.org/api/1.1/series/5617/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5617", "date": "2025-11-27T02:37:15", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 5, "mbox": "https://patchwork.libcamera.org/series/5617/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25244/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25244/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7FCE0C3257\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 27 Nov 2025 02:38:05 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 36F6260AB8;\n\tThu, 27 Nov 2025 03:38:05 +0100 (CET)", "from mail-wm1-x335.google.com (mail-wm1-x335.google.com\n\t[IPv6:2a00:1450:4864:20::335])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DFA2C609DE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 27 Nov 2025 03:38:02 +0100 (CET)", "by mail-wm1-x335.google.com with SMTP id\n\t5b1f17b1804b1-47774d3536dso2827835e9.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 26 Nov 2025 18:38:02 -0800 (PST)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4790552c3c9sm58186345e9.0.2025.11.26.18.37.59\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 26 Nov 2025 18:38:01 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"Hu6Va5YL\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1764211082; x=1764815882;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=5QzPnlwjhvESIFdxhKHBTYkka7xzVX4r9w83gKJuA78=;\n\tb=Hu6Va5YLJCLJKWOkB6T7fTDekXAyxBcWKCKnQhmBJULuLWKouj8oZKy5r2oG0Ygs25\n\t67I3UF/kPOZN8yscJu0Aqu5NynDyfLsv0ndICgek7KBe8/Nzopi8zKckNyXjdbYFbm3q\n\tG19FTmN1yYz4ePi5nj1lGfaWYLRHmkhvlFaLu62cKzeyXMyQJx7QT0t+ZND4UpTvvE9p\n\tOtXYYuALHmd9eSoFAbHrY3t4cdLH+FvPPrWSK7o6GELqGGHvX+3Br313uOl5Kut9J5r7\n\tYkuBN6XNJ8dMHEWSQGYT3S35RHePoWZPqDBFEgMIVyyb03yYcHtqShQFRLXySNkQBYdE\n\tK0Ng==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1764211082; x=1764815882;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=5QzPnlwjhvESIFdxhKHBTYkka7xzVX4r9w83gKJuA78=;\n\tb=Qx4ZEozJY4DilN4a39JSOK1kPTMnjkzw8H7ryH6CnMPW+xQ2+T/IivDX5k7KJZKMWH\n\tTG+TsVeIrQtg08mm6IcP2CVuGxHGUJRYUxwHPwp+WQv0cFf+Jag5QrmPGUXxewlSErR0\n\tJ75Iiy2uQ1v3Ftr+zo1L11aQGDwMSMH640SGlqmhTBywKo5kD1hZc/95AbNAk0MMuXOi\n\trFGtPCqp8S2OCra7CNrgxW9F9tYUV/Z1cfqT9GMDKMGIS2jmAVY82lqcGUFYbc9MbjLs\n\t5DjbotBNpr1aJri+1mcfG6/mdi5mjwu4WNx1sklXChtNg4hrRoZmbWVfjvB7A7rUXDxp\n\ts4tg==", "X-Gm-Message-State": "AOJu0Yyr6U79BPQvtOn5TXMo6VUwwyTv9e3oPbKF15k76Nijf/RX5sxc\n\tqbcOE8EgErpkdX6KWFvgJiio4e9dzawZ8RbdH+C6nTWA/gVPSvRaH+oemL4ugim9TONrV2DSfkk\n\thIpnehd8=", "X-Gm-Gg": "ASbGncueHj77FyjjVKspBAmnGRaCMUQeqdiIxRbUZ0NuQwxvj1CkbKgcZBdAz75F5uM\n\t2/OUFXLxENu53B0GtiMACXuH80w7dYDx6xjslrWTvgq7KnG82adx+ZL8bdYpOY27/QBWPDrtRfO\n\tVfr/gs9FPDW+3uqCOfSU6XxC1XzBLsk5WCxgRFEJ6wEHE2PAgsL4NYYIJ/pUsXavUzkOGdc1s/H\n\tsXzuTFeyKMXeUyBO6IeEVsGSIdfMvEr6ror2jczYVADMPfv6fgyWuZ8oUePeDPAitz3SuAEC/ah\n\tZasSguLG2a1ypQJ42DU1w0tZDWPh3WrVl4rTtA0PRDGydGOzZgu7fqW/+74NIII/QUFhb/upDHQ\n\tPDfwNR0XyGXZSZaAqURq0zHsm5ZOQvoCbH+iAC1UdemuCjM1DDgOLuLYwjNDgQefl/ckTeIqC37\n\thI5il1uJcrEZfxGqIW6DZkIdaaAFFIGWmwXiE9hQ28BPQeaGu/0tkYBbRKkoBkD/r1PA4=", "X-Google-Smtp-Source": "AGHT+IGbxsIKDnFRrau5MUln2wamfa2a/F8oI8AOjW00WSVuKniYdze5ukkjRpEsNDjRTzAGc9ZmOg==", "X-Received": "by 2002:a05:600c:628f:b0:477:bf1:8c82 with SMTP id\n\t5b1f17b1804b1-477c053c90amr232096685e9.15.1764211082311; \n\tWed, 26 Nov 2025 18:38:02 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tMilan Zamazal <mzamazal@redhat.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v5 07/24] libcamera: shaders: Extend bayer shaders to support\n\tswapping R and B on output", "Date": "Thu, 27 Nov 2025 02:37:22 +0000", "Message-ID": "<20251127023739.179652-8-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.51.2", "In-Reply-To": "<20251127023739.179652-1-bryan.odonoghue@linaro.org>", "References": "<20251127023739.179652-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "We can easily facilitate swapping R and B on output. Pivot on an\nenvironment define for this purpose.\n\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nAcked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/shaders/bayer_1x_packed.frag | 4 ++++\n src/libcamera/shaders/bayer_unpacked.frag | 6 +++++-\n 2 files changed, 9 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/shaders/bayer_1x_packed.frag b/src/libcamera/shaders/bayer_1x_packed.frag\nindex 90bd64570..c0632eb1f 100644\n--- a/src/libcamera/shaders/bayer_1x_packed.frag\n+++ b/src/libcamera/shaders/bayer_1x_packed.frag\n@@ -268,5 +268,9 @@ void main(void)\n \trgb.b = texture2D(blue_param, vec2(rgb.b, 0.5)).b;\n #endif\n \n+#if defined (SWAP_BLUE)\n+\tgl_FragColor = vec4(rgb.bgr, 1.0);\n+#else\n \tgl_FragColor = vec4(rgb, 1.0);\n+#endif\n }\ndiff --git a/src/libcamera/shaders/bayer_unpacked.frag b/src/libcamera/shaders/bayer_unpacked.frag\nindex 924c477de..a9996b94e 100644\n--- a/src/libcamera/shaders/bayer_unpacked.frag\n+++ b/src/libcamera/shaders/bayer_unpacked.frag\n@@ -163,5 +163,9 @@ void main(void) {\n rgb.b = texture2D(blue_param, vec2(rgb.b, 0.5)).b;\n #endif\n \n- gl_FragColor.rgb = rgb;\n+#if defined (SWAP_BLUE)\n+ gl_FragColor = vec4(rgb.bgr, 1.0);\n+#else\n+ gl_FragColor = vec4(rgb, 1.0);\n+#endif\n }\n", "prefixes": [ "v5", "07/24" ] }