Patch Detail
Show a patch.
GET /api/1.1/patches/25227/?format=api
{ "id": 25227, "url": "https://patchwork.libcamera.org/api/1.1/patches/25227/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25227/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251127022256.178929-14-bryan.odonoghue@linaro.org>", "date": "2025-11-27T02:22:45", "name": "[v2,13/22] libcamera: software_isp: Make output DMA sync contingent", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "bbc24e3404e986b0c8daa2edfa4d9c57eda948ad", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25227/mbox/", "series": [ { "id": 5616, "url": "https://patchwork.libcamera.org/api/1.1/series/5616/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5616", "date": "2025-11-27T02:22:32", "name": "GPUISP precursor series", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5616/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25227/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25227/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DE587C32DE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 27 Nov 2025 02:23:35 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 787E260AB8;\n\tThu, 27 Nov 2025 03:23:35 +0100 (CET)", "from mail-wm1-x333.google.com (mail-wm1-x333.google.com\n\t[IPv6:2a00:1450:4864:20::333])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 95746609E0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 27 Nov 2025 03:23:33 +0100 (CET)", "by mail-wm1-x333.google.com with SMTP id\n\t5b1f17b1804b1-477a219dbcaso2549635e9.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 26 Nov 2025 18:23:33 -0800 (PST)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4790b0e21e8sm71549495e9.15.2025.11.26.18.23.30\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 26 Nov 2025 18:23:31 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"aYOMmWPj\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1764210213; x=1764815013;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=nJt84EldY/UglCQL1W1m2dIaAxw2bYU8OhkHNUoIlY0=;\n\tb=aYOMmWPjpFQFY/bbvfR8oVCsV408MCM1vdXs0tcaI0CZ81ulxMvG/RDtckZXm6wU1E\n\tWBvqwODAVPCx/XNulbQriYkOYFN1BWbwX3ZxcJd05EROF2WaJLVt9MYlwLmOyq56XybW\n\te17lutM66yTQpSd4dGTEeOJW8k6m7Dz2evRstUDNgZm2CykPT+QDp4SHnXDFxplSW3tp\n\tBY5eNfztGShNZ75Za6OM0ZD9cyWZ+KZ7wQuu1CCYZP5PWW1CCvxb8kG0VNzZyidLcreO\n\t1gBSvbuvc08jnK2aGXe6oEBnXDIZtTg1AJU2WveEGmh0KfoeK7az7pqoC0c3og9xj7mW\n\tbArg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1764210213; x=1764815013;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=nJt84EldY/UglCQL1W1m2dIaAxw2bYU8OhkHNUoIlY0=;\n\tb=Y5AL6fuCIg2WDu0lYBAXXOqXVZoPGOEwXqBx4qlIZZtRoX5rcBGW11or8yQ7Z7rug2\n\tkZNYOAYPETDFc+hHsbuzWXkHUv4QmHSf/DEdUv3JLOEoC9g/7AehZ4pDQ1UYbA/gCDb0\n\t/lUfGgaQek+JNNV/6l+gMVpyY/vdk70wpcpDkBWdsHGqWurxLNKFfws6dol45GmbWEBI\n\tm7DPpnbnqbuZodSaEvxIuM/37NwTaQ2iPD9glvl63jnXs/+jBO5NhIz3RoPTPI3SA6XL\n\tp4rz637auMTFRBPFv7FgeEM1TzmBpoE34tR+o28RyJU6AGgrarMpCl5BYPOEevXdQy1H\n\tj/Rg==", "X-Gm-Message-State": "AOJu0YxlxirZpFnazSKJSFBaSvIZxQf4LDunEN3eYBXIdLgLJg7nbRfi\n\tJZhY04TsjQi340Ha+Nlh49AxHrl2ZNUpWksBCqKLD7tf0qvgZpyX/KwvdGQcS8TCIbEeF3UuiCb\n\t2A8Nsnyk=", "X-Gm-Gg": "ASbGncso30sSZx1+pcDo+PV/pIjljQ3xftaLP1D5FwCYzzDOxmv+YRy2R5BpxETkKBp\n\tk0FsTxIO/O08LpcfgTw05rqsPf3Q6+MtxLyoofpvPQnMfQdTyH5LUWEnjS1uBLmQH6P7E/4+5lJ\n\tTRFSot8Ti+kQcuSPt9GTsIXgJ2F3S2zMlNe9M9icFs55VVeOgzuaaaX59CnjG4GbPcOgb566kJ8\n\tw0mpU1x9Ynt60camrQauQLVSUStrr/87KcdLdRra3RxfhtmeIYRxIWvd7JGWn9a3TInbk/moEeV\n\trod1B96XcRJYgrnfmvlhuJ0mf1cqvjfARqIWxAAqJdPntSdd4F6QkqCt++JlGVB8cma1pGcdAdI\n\thO+yt/CNb+vdX3Z8z7ZMTVk+3Us7I8Vzvb8oQVMuW7dUYlCOBYwiRi2calQ1KlOHEcujSX7Q2ww\n\t1fk+KY8hNjisQvS/FdKaLxmEVrc1EbfN5060PnT0u5a2Ev5Zxm8b7sY0rkmSIANippLUM=", "X-Google-Smtp-Source": "AGHT+IElLYWnFlCgIxzJ2WoVQbAGqyXQi48Ct4FYTWjmDHdZOg06nVgE1hHY0vX/ZAKm03gmVS7HRw==", "X-Received": "by 2002:a05:600c:3b09:b0:471:13fa:1b84 with SMTP id\n\t5b1f17b1804b1-477c0185bc8mr249147045e9.12.1764210212913; \n\tWed, 26 Nov 2025 18:23:32 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tRobert Mader <robert.mader@collabora.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tMilan Zamazal <mzamazal@redhat.com>", "Subject": "[PATCH v2 13/22] libcamera: software_isp: Make output DMA sync\n\tcontingent", "Date": "Thu, 27 Nov 2025 02:22:45 +0000", "Message-ID": "<20251127022256.178929-14-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.51.2", "In-Reply-To": "<20251127022256.178929-1-bryan.odonoghue@linaro.org>", "References": "<20251127022256.178929-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The DMA sync output buffer from the GPU need only have its cache\ninvalidated if the CPU is going to modify the buffer. Right now this is\nnot required for gpuisp so only act on the output buffer if it is\nnon-null.\n\nSuggested-by: Robert Mader <robert.mader@collabora.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/debayer.cpp | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp\nindex 544921656..158128f30 100644\n--- a/src/libcamera/software_isp/debayer.cpp\n+++ b/src/libcamera/software_isp/debayer.cpp\n@@ -373,8 +373,10 @@ void Debayer::dmaSyncBegin(std::vector<DmaSyncer> &dmaSyncers, FrameBuffer *inpu\n \tfor (const FrameBuffer::Plane &plane : input->planes())\n \t\tdmaSyncers.emplace_back(plane.fd, DmaSyncer::SyncType::Read);\n \n-\tfor (const FrameBuffer::Plane &plane : output->planes())\n-\t\tdmaSyncers.emplace_back(plane.fd, DmaSyncer::SyncType::Write);\n+\tif (output) {\n+\t\tfor (const FrameBuffer::Plane &plane : output->planes())\n+\t\t\tdmaSyncers.emplace_back(plane.fd, DmaSyncer::SyncType::Write);\n+\t}\n }\n \n } /* namespace libcamera */\n", "prefixes": [ "v2", "13/22" ] }