Patch Detail
Show a patch.
GET /api/1.1/patches/25224/?format=api
{ "id": 25224, "url": "https://patchwork.libcamera.org/api/1.1/patches/25224/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25224/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251127022256.178929-11-bryan.odonoghue@linaro.org>", "date": "2025-11-27T02:22:42", "name": "[v2,10/22] libcamera: software_isp: Move Bayer params init from DebayerCpu to Debayer", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "bc98b0414802a4f733a0902cf99234a261030282", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25224/mbox/", "series": [ { "id": 5616, "url": "https://patchwork.libcamera.org/api/1.1/series/5616/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5616", "date": "2025-11-27T02:22:32", "name": "GPUISP precursor series", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5616/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25224/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25224/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 071E6C3260\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 27 Nov 2025 02:23:30 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A256360AB8;\n\tThu, 27 Nov 2025 03:23:29 +0100 (CET)", "from mail-wm1-x335.google.com (mail-wm1-x335.google.com\n\t[IPv6:2a00:1450:4864:20::335])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B83EB609DE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 27 Nov 2025 03:23:25 +0100 (CET)", "by mail-wm1-x335.google.com with SMTP id\n\t5b1f17b1804b1-477a1c28778so3189665e9.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 26 Nov 2025 18:23:25 -0800 (PST)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4790b0e21e8sm71549495e9.15.2025.11.26.18.23.23\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 26 Nov 2025 18:23:24 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"z5AMNo66\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1764210205; x=1764815005;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=rHp1ZpmpNd8F5seragsp7cEDNOHsYn8jNKQx3PfPjQs=;\n\tb=z5AMNo66mduPq1jHzSld5DGGqfkcpBjt0Qwtp9RkSHbtJJ9iVhWvQSlX0mVRS9enqP\n\tyxSzlnPMO6vZ+LTeaVDp4NoREEog2tAg02FCT36hiNKKR0saUlpYemrTllvXJHJgPO2x\n\tEjf2yje+bWSSmRBCDTxbJ2GFF+xk0ywXM3kkftXfZu+VcE9/V7FGp83VGe0McvGrho0Z\n\tIrpB/e9LpzsrZXcb7njxeryFJKsigCNqwjMp0M4F07PbFpxADleh8gYQsfYukN2kw+bc\n\t+wJQNuyGRrsGDp7f49fV/PEi9YLzXN9BZgWWcmO/S38/P9RGe+99EYegfv796nIe2FB7\n\tDZYA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1764210205; x=1764815005;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=rHp1ZpmpNd8F5seragsp7cEDNOHsYn8jNKQx3PfPjQs=;\n\tb=FwIGvmB3zgkCgc64vmcQbnaZbmefPQk1CLtkgftwPS3hZw4bEwEpZrSgJnWiAQ02ws\n\tgBnQPQwHzeEhHJTixkKI8T7Df8ipa1Vy/vU9rDP9QQkS1Dj3Bi82DNveSghuQM2pbNfr\n\tRvAjFZ3C8GYpXGn+jLOgOLahtuOdkHckogXtNnOKvC+OKeoJ7AeFPIMu05sp0fqZfvT/\n\t4jpwWDu7yIxcEKRWzOihN5WsE2cSF6jAYevOXKIEbhK6xldQCh/h7zBv/JrZci3dhJTj\n\tm1IeWHo2G3sapgAAcW+QPBaYHcjfLMEWpKxi3P6LJZ2m6C0sq+iN3+VNaiabHM+YzZBb\n\tfZHQ==", "X-Gm-Message-State": "AOJu0YwMQ2Y3eVrjGvEZMAwyJ+olbXkEoLM87vjA0tQzouXT6Xxa82CH\n\tAy6lJlPnKrcII9moSjQeqjVQY9Fuu/gFapA1QvSwQrzqrd1Onrfs07JcKdCSo5dPVbxoBYx+CfE\n\tpswS0c7s=", "X-Gm-Gg": "ASbGncucpM8mu/qcR70oMCkX3nJuAhfy7kG4MS/9z89FrKom5cKY57caj0nKvyFRr9C\n\tiwvo2FexIBg1GGyRo2D5R7WhkxsoYwxMhbcsZPlnm1D8zrxKi3kDENULzbNQCHSvx94xROWELOh\n\tOHclnrN98UQ+6kpeyV6tKuCficnSHIzhBgCOOnXhjNQQ+Mtz/KbmAwGgWJYZpqSTOHfwB28+XLN\n\tuRXBXz9v0onyuJmwfx1PuKikyajByt0ni8keSRcpsvNAU5zjAH/LGB/AJlwFX+bTIRthIiGMMek\n\tEWTi2se64KKn67MctDBIErFr0mW+2B1ybgqH7J7tjlavFRte6auWYuwkq1owggmur+nbletgqoQ\n\tLWbANWQTSBsiL8UMaWuPkgMxEaBiGeqDmhypT02sl1/vNrS6FsVXeaG04tvC6lev9XNY1nxY7qM\n\t5OPh8rK3Z0HnhJu/amBvWdsWW/K+RSrZv2AZ6oE7YivvX4EQWYMzbhjFw5h+nlIcPsv8odthddC\n\tNRvtA==", "X-Google-Smtp-Source": "AGHT+IFm3ugUOAuGXQVG7PI6CM//mxD2RbLwgIvj23fQw3ZTih/B4/N/T6qqDuitUveFarYzsfXUoA==", "X-Received": "by 2002:a05:600c:4591:b0:475:e067:f23d with SMTP id\n\t5b1f17b1804b1-47904b1fac9mr80618965e9.25.1764210205083; \n\tWed, 26 Nov 2025 18:23:25 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tMilan Zamazal <mzamazal@redhat.com>", "Subject": "[PATCH v2 10/22] libcamera: software_isp: Move Bayer params init\n\tfrom DebayerCpu to Debayer", "Date": "Thu, 27 Nov 2025 02:22:42 +0000", "Message-ID": "<20251127022256.178929-11-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.51.2", "In-Reply-To": "<20251127022256.178929-1-bryan.odonoghue@linaro.org>", "References": "<20251127022256.178929-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Move the initialisation of Bayer params and CCM to a new constructor in the\nDebayer class.\n\nEnsure we call the base class constructor from DebayerCpu's constructor in\nthe expected constructor order Debayer then DebayerCpu.\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/debayer.cpp | 11 +++++++++++\n src/libcamera/software_isp/debayer.h | 2 +-\n src/libcamera/software_isp/debayer_cpu.cpp | 8 --------\n 3 files changed, 12 insertions(+), 9 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp\nindex 1e3f08673..8cadfaadc 100644\n--- a/src/libcamera/software_isp/debayer.cpp\n+++ b/src/libcamera/software_isp/debayer.cpp\n@@ -109,6 +109,17 @@ namespace libcamera {\n \n LOG_DEFINE_CATEGORY(Debayer)\n \n+Debayer::Debayer(const GlobalConfiguration &configuration) : bench_(configuration)\n+{\n+\t/* Initialize color lookup tables */\n+\tfor (unsigned int i = 0; i < DebayerParams::kRGBLookupSize; i++) {\n+\t\tred_[i] = green_[i] = blue_[i] = i;\n+\t\tredCcm_[i] = { static_cast<int16_t>(i), 0, 0 };\n+\t\tgreenCcm_[i] = { 0, static_cast<int16_t>(i), 0 };\n+\t\tblueCcm_[i] = { 0, 0, static_cast<int16_t>(i) };\n+\t}\n+}\n+\n Debayer::~Debayer()\n {\n }\ndiff --git a/src/libcamera/software_isp/debayer.h b/src/libcamera/software_isp/debayer.h\nindex b562985a6..f4373ddeb 100644\n--- a/src/libcamera/software_isp/debayer.h\n+++ b/src/libcamera/software_isp/debayer.h\n@@ -33,7 +33,7 @@ LOG_DECLARE_CATEGORY(Debayer)\n class Debayer : public Object\n {\n public:\n-\tDebayer (const GlobalConfiguration &configuration) : bench_(configuration) {};\n+\tDebayer (const GlobalConfiguration &configuration);\n \tvirtual ~Debayer() = 0;\n \n \tvirtual int configure(const StreamConfiguration &inputCfg,\ndiff --git a/src/libcamera/software_isp/debayer_cpu.cpp b/src/libcamera/software_isp/debayer_cpu.cpp\nindex e55599f09..8f42d706b 100644\n--- a/src/libcamera/software_isp/debayer_cpu.cpp\n+++ b/src/libcamera/software_isp/debayer_cpu.cpp\n@@ -57,14 +57,6 @@ DebayerCpu::DebayerCpu(std::unique_ptr<SwStatsCpu> stats, const GlobalConfigurat\n \t */\n \tenableInputMemcpy_ =\n \t\tconfiguration.option<bool>({ \"software_isp\", \"copy_input_buffer\" }).value_or(true);\n-\n-\t/* Initialize color lookup tables */\n-\tfor (unsigned int i = 0; i < DebayerParams::kRGBLookupSize; i++) {\n-\t\tred_[i] = green_[i] = blue_[i] = i;\n-\t\tredCcm_[i] = { static_cast<int16_t>(i), 0, 0 };\n-\t\tgreenCcm_[i] = { 0, static_cast<int16_t>(i), 0 };\n-\t\tblueCcm_[i] = { 0, 0, static_cast<int16_t>(i) };\n-\t}\n }\n \n DebayerCpu::~DebayerCpu() = default;\n", "prefixes": [ "v2", "10/22" ] }