Patch Detail
Show a patch.
GET /api/1.1/patches/25218/?format=api
{ "id": 25218, "url": "https://patchwork.libcamera.org/api/1.1/patches/25218/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25218/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251127022256.178929-5-bryan.odonoghue@linaro.org>", "date": "2025-11-27T02:22:36", "name": "[v2,04/22] libcamera: swstats_cpu: Update statsProcessFn() / processLine0() documentation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "8da0e9fb46d79d4b5aa0d845428e9003b11c74ec", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25218/mbox/", "series": [ { "id": 5616, "url": "https://patchwork.libcamera.org/api/1.1/series/5616/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5616", "date": "2025-11-27T02:22:32", "name": "GPUISP precursor series", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5616/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25218/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25218/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8B043C3260\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 27 Nov 2025 02:23:16 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DBA6060AA3;\n\tThu, 27 Nov 2025 03:23:15 +0100 (CET)", "from mail-wm1-x332.google.com (mail-wm1-x332.google.com\n\t[IPv6:2a00:1450:4864:20::332])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6E934609E0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 27 Nov 2025 03:23:11 +0100 (CET)", "by mail-wm1-x332.google.com with SMTP id\n\t5b1f17b1804b1-477b91680f8so2521685e9.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 26 Nov 2025 18:23:11 -0800 (PST)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4790b0e21e8sm71549495e9.15.2025.11.26.18.23.09\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 26 Nov 2025 18:23:10 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"vSeHKphW\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1764210191; x=1764814991;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=BYLFp48Jtlh28DV0l7WkmFCL3lrDfDHVbIKL8htzT4E=;\n\tb=vSeHKphWtBjwqNtxLIGKXnm9wfqSmDElHzmWyKjB3iKQhucA/WBBdhR3GtCYYdWTYJ\n\tFk6NS6W183UHV3qZgmb8pfD/H2w60mdSdoymGczROk4aIDzX5ZFxBE7Z/3q2pJwq9yex\n\ti2KV1uJJau0A2JxOJHSXE+AqW1PUz6TaqaybbcOwY6kKoJ7vczftPErLWsH2nd0E6fe+\n\tflwyQls7x390DFZY8dQ/Jc1LSsFLnDeJhv8K5RUoxNs14CCuhM1w0yGGXXGqfPyZzlbn\n\tNla5r6gXm2R7k4/1hNraBZ9FAayMT5CM52/4P+o1JxJk6MjB1ZJ4bUIr0VeNNZlzRX1R\n\tPuTw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1764210191; x=1764814991;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=BYLFp48Jtlh28DV0l7WkmFCL3lrDfDHVbIKL8htzT4E=;\n\tb=gsM9W0SY3AtFDcwV3XlBUtVZEcJnV5VLwlZfeSrtkPN0EwREFQC0K+SSENavdFHOmT\n\tY7LRAxS8fERpt4hz+cbAAcy5e6cQkB9ST6tP4QefJb6m/1TXoSioJANYRgprujm0GRK1\n\t/edEtVUruBAt1ZP9dE3zoKv5s9zVAGPAybmqQbOaW+nCNU+lxMPmWUuu4Qa9xdEltcPa\n\tLXL6xA2RNp5Ra5ELRIAUTg1N3D89qN7mXc86Hp8JHeiu0ANpjSBXJJiq1/g/2q/5LAD8\n\tT7dhSJVRQRGvUlSE0lws+LK9hXeRpIubkRdbZXmdGhIOU6w+qsCe/8CEKnuBypYwymdD\n\tdLUg==", "X-Gm-Message-State": "AOJu0YxiQ/FpiOJKJudJx8Q+DOkljD+q4j7uT2fPBNJ7ZnuIohleflS9\n\tW8PwmP0gEk3u0dfnEqY0/es0MoVrQ+O4/OWE0SGQILZNEjlTlztCvdn6SPmmwEDQXvJGwQdfLVz\n\tm3uFAk8I=", "X-Gm-Gg": "ASbGnctBj0GIiLZr1K3pZKT5EpivwjNU+7VcHbgDKTkjzX7Av9Xc76/7xDx2IZ/+Xii\n\tYjCTW1m+LeBRo91YXB4sq1mD6ee6tPql6DjPf9HNOyg7JZmSOOQ7QvxvOcdZzv1V3fNThPU+kbs\n\t9jWCY73px1tjZmkS2q/OTz9zPLqt0pKsm/4seBnF0ZFSa4h/JSp7iGH/FaEXJ6cfXK05PCquEnl\n\tKxyENCRv1QFDLXxIOIZAlFEhzSYniPEIDL9G+LGnyMIk2+EzeNAS9Hi0ZLY0m7eVV4XOIrJe3s2\n\tgQCAyx639AmgizWnzXpM2VHEVs9XXS3UakjBoBQRbJ1l6CMJZyodvxn7ilKVbgFkNm5qyg3c04s\n\t2k3G3ouhnw0Ru8WRz4De6qXohznUPWyVLF2A2csNj5ANa83ymhNqoR34PIyR1t5JfwRv4f03uFN\n\tTHOc7poZqG3XWrOlKW33Twu5nSW8J9Q3Xh35JafoT3H8/JhTxOdhb7ymAoR5lvz1IFq5Y=", "X-Google-Smtp-Source": "AGHT+IHBz/3vtDnicqmetnkw42IdBF/8X5r27QL4RKG7YlAjPxsNYcs713zTv/NMssvNTVejPGNxKQ==", "X-Received": "by 2002:a05:600c:3ba1:b0:475:dd89:acb with SMTP id\n\t5b1f17b1804b1-477c11160cdmr221865095e9.22.1764210190788; \n\tWed, 26 Nov 2025 18:23:10 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Hans de Goede <hdegoede@redhat.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tMilan Zamazal <mzamazal@redhat.com>,\n\tBryan O'Donoghue <bryan.odonoghue@linaro.org>", "Subject": "[PATCH v2 04/22] libcamera: swstats_cpu: Update statsProcessFn() /\n\tprocessLine0() documentation", "Date": "Thu, 27 Nov 2025 02:22:36 +0000", "Message-ID": "<20251127022256.178929-5-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.51.2", "In-Reply-To": "<20251127022256.178929-1-bryan.odonoghue@linaro.org>", "References": "<20251127022256.178929-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Hans de Goede <hdegoede@redhat.com>\n\nUpdate the documentation of the statsProcessFn() / processLine0() src[]\npointer argument to take into account that swstats_cpu may also be used\nwith planar input data or with non Bayer single plane input data.\n\nThe statsProcessFn typedef is private, so no documentation is generated\nfor it. Move the new updated src[] pointer argument documentation to\nprocessLine0() so that it gets included in the generated docs.\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Hans de Goede <hdegoede@redhat.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/swstats_cpu.cpp | 13 +++++++++++++\n 1 file changed, 13 insertions(+)", "diff": "diff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp\nindex 4f7bdd231..9c03338a0 100644\n--- a/src/libcamera/software_isp/swstats_cpu.cpp\n+++ b/src/libcamera/software_isp/swstats_cpu.cpp\n@@ -72,6 +72,19 @@ namespace libcamera {\n * patternSize height == 1.\n * It'll process line 0 and 1 for input formats with patternSize height >= 2.\n * This function may only be called after a successful setWindow() call.\n+ *\n+ * This function takes an array of src pointers each pointing to a line in\n+ * the source image.\n+ *\n+ * Bayer input data requires (patternSize_.height + 1) src pointers, with\n+ * the middle element of the array pointing to the actual line being processed.\n+ * Earlier element(s) will point to the previous line(s) and later element(s)\n+ * to the next line(s). See the DebayerCpu::debayerFn documentation for details.\n+ *\n+ * Planar input data requires a src pointer for each plane, with src[0] pointing\n+ * to the line in plane 0, etc.\n+ *\n+ * For non Bayer single plane input data only a single src pointer is required.\n */\n \n /**\n", "prefixes": [ "v2", "04/22" ] }