Patch Detail
Show a patch.
GET /api/1.1/patches/25217/?format=api
{ "id": 25217, "url": "https://patchwork.libcamera.org/api/1.1/patches/25217/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25217/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251127022256.178929-4-bryan.odonoghue@linaro.org>", "date": "2025-11-27T02:22:35", "name": "[v2,03/22] meson: Automatically generate glsl_shaders.h from specified shader programs", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "78bfd4997334c20c8a02b8d8be329e8c31927538", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25217/mbox/", "series": [ { "id": 5616, "url": "https://patchwork.libcamera.org/api/1.1/series/5616/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5616", "date": "2025-11-27T02:22:32", "name": "GPUISP precursor series", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5616/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25217/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25217/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E3BA6C32DE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 27 Nov 2025 02:23:14 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 18AE360AA6;\n\tThu, 27 Nov 2025 03:23:14 +0100 (CET)", "from mail-wm1-x336.google.com (mail-wm1-x336.google.com\n\t[IPv6:2a00:1450:4864:20::336])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 004C460AA6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 27 Nov 2025 03:23:09 +0100 (CET)", "by mail-wm1-x336.google.com with SMTP id\n\t5b1f17b1804b1-47789cd2083so1244515e9.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 26 Nov 2025 18:23:09 -0800 (PST)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4790b0e21e8sm71549495e9.15.2025.11.26.18.23.08\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 26 Nov 2025 18:23:08 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"bmSd9sPi\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1764210189; x=1764814989;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=Tf4iz5iEYQ1oR7Y+wuSf5rxUztQz2jgouqu9GnH0HVI=;\n\tb=bmSd9sPie8FVuBAEliu+bdSuDudlYKGeP2r5KJeXhklxOnoiT6Zl7VeSxF8fpg0aR8\n\t8/dYaRba2oMbtMWjgpVxEWf6xuIf1gDh4af6rHdSMKSfiZrqJxJFgEph0rx88EHVljiE\n\tiDNOGZ5M0HvtX7J6gAGY8Sg86I5KCLj0MZHq8ioPyF6MF5LrLkX+KIRTfHWwx5PvGAtt\n\tkS2PAXasQutNQ5xNyJlQMPq6bp7D96BEp4hE0wYHUCQmn/AwyU6dQqYq3Qx3Yb8Xbb20\n\t63rTbReyK5NfsM3BpBYXgtvZPIyU/kvTjWe9RuN3XA9qfd0Cy5y3tClPGrjepUtAdtIn\n\tTShA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1764210189; x=1764814989;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=Tf4iz5iEYQ1oR7Y+wuSf5rxUztQz2jgouqu9GnH0HVI=;\n\tb=AcnJnXAHXMmgCF/rjXy9+WYveHlb1LP6bae6jUvZmiR620EvR2AQ1ua1Y1D3tTH1zi\n\t9kw82gNG7VbOsM9bmJYGEYHDaC/zVTWbeZpLOB77Itx+9oTKMzOA6OeDMxrC8rX05V7E\n\tPTfTIlsF8lnIJ8vZKlkm5pXJzChUWU0IWVDpXYyBFkEc3kjsGn/fh2W4IGd+szNIvV05\n\tvSrv+lvyVchTbwUh36l4d2Sg8LDD7004y0us2TSfXoW9eiUSIdFtx1t60M2eOn8DZcWi\n\tWx/tRA56vpN5W7IdAydlZ5SXL2NeFL96ipz2MY9V+A054PB2ALnA0/4IAqYjZX4kFEs8\n\tYnEA==", "X-Gm-Message-State": "AOJu0YyYl5AXZUqNJaEw71x00myeivmPbLJFcZCHFPLFv7N34bVIYmhQ\n\t+/HxXPvYqfGoXeHBIl9EeBV3uwL19WhICRDhuwh/i2p7DBJ/3EI17k5jvjkFHoHKBNRsTKXDyyA\n\t2p9+TrbI=", "X-Gm-Gg": "ASbGncuZqp37hQYozgKss9Ou7ospzr6M3E4SK1GxPuUCIUUE/nkS99iU/ztlgOgYBb/\n\tIuj70V0CF9OWhmnoMGJ4Ej8WXFGOSL3JbYSGr9oOZmTbcndrBwFnSpe3Iyei+jLHjQV7I4UGG+s\n\tMY256QC11pNFENIhlyvBjMWdg8PNkKjVLYog0KVmz0NgZJhRPKfS+vwL9RXH270JVt4QH1n6Ai9\n\tWoG7qswx5uIwpXkSp4conxDCW0XaAI0OyQgbLVceWE9MWpu4c8b+rGmzGW26fSwKcwg5mamYlPW\n\tPV3aYXF3ySMZ0Ay8/fzDlKt9HaL6/sGg0LUXmTI4aFxP48ds9yrh5qt9jau2l/ebW/OI2NeR0SQ\n\tGy4wuXevMrAPGvD86VclKJZMB2W2M5UNNrupibQwWffCq48CuVhT/AoAqaSb2Sbh/iS2P/yD3V7\n\tkVGvg/mZT9l21ED1sIXCg9ZkWZBFe39XhJ5xH9Izd/JxHg2/uaRqxsBfyMYE0dztskyqU=", "X-Google-Smtp-Source": "AGHT+IHkhqhf4+Pz+N2NY5qxP1ZbpX2Zo5ycIkowSHr6A6BMxoiu0QO/n1k4hAqFrhs4ZipdWGi+9w==", "X-Received": "by 2002:a05:600c:3b08:b0:477:214f:bd95 with SMTP id\n\t5b1f17b1804b1-477c114df06mr209302975e9.23.1764210189144; \n\tWed, 26 Nov 2025 18:23:09 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v2 03/22] meson: Automatically generate glsl_shaders.h from\n\tspecified shader programs", "Date": "Thu, 27 Nov 2025 02:22:35 +0000", "Message-ID": "<20251127022256.178929-4-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.51.2", "In-Reply-To": "<20251127022256.178929-1-bryan.odonoghue@linaro.org>", "References": "<20251127022256.178929-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Encode the bayer shader files into a header as part of the build process.\nQcam already compiles the shader files down into a QT resource file which\nit references internally.\n\nIn order to share the debayering shader programs outside of qcam create a\ngeneric header which both qcam and libcamera can operate from.\n\nAcked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/meson.build | 11 +++++++++++\n src/libcamera/shaders/meson.build | 10 ++++++++++\n utils/meson.build | 2 ++\n 3 files changed, 23 insertions(+)\n create mode 100644 src/libcamera/shaders/meson.build", "diff": "diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex 34e20f557..90d434a5a 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -76,6 +76,7 @@ subdir('ipa')\n subdir('pipeline')\n subdir('proxy')\n subdir('sensor')\n+subdir('shaders')\n subdir('software_isp')\n \n libdl = dependency('dl')\n@@ -182,6 +183,16 @@ libcamera_deps += [\n libyaml,\n ]\n \n+# Generate headers from shaders\n+libcamera_shader_headers = custom_target(\n+ 'gen-shader-headers',\n+ input : [shader_files],\n+ output : 'glsl_shaders.h',\n+ command : [gen_shader_headers, meson.project_source_root(), meson.project_build_root(), '@OUTPUT@', '@INPUT@'],\n+)\n+\n+libcamera_internal_headers += libcamera_shader_headers\n+\n # We add '/' to the build_rpath as a 'safe' path to act as a boolean flag.\n # The build_rpath is stripped at install time by meson, so we determine at\n # runtime if the library is running from an installed location by checking\ndiff --git a/src/libcamera/shaders/meson.build b/src/libcamera/shaders/meson.build\nnew file mode 100644\nindex 000000000..386b342d0\n--- /dev/null\n+++ b/src/libcamera/shaders/meson.build\n@@ -0,0 +1,10 @@\n+# SPDX-License-Identifier: CC0-1.0\n+\n+# List of shader files to convert to header hex\n+# for the purposes of inclusion in OpenGL debayering\n+shader_files = files([\n+ 'bayer_1x_packed.frag',\n+ 'bayer_8.frag',\n+ 'bayer_8.vert',\n+ 'identity.vert',\n+])\ndiff --git a/utils/meson.build b/utils/meson.build\nindex 95d657ac9..3deed8ad4 100644\n--- a/utils/meson.build\n+++ b/utils/meson.build\n@@ -3,5 +3,7 @@\n subdir('codegen')\n subdir('ipu3')\n \n+gen_shader_headers = files('gen-shader-headers.sh')\n+\n ## Module signing\n gen_ipa_priv_key = files('gen-ipa-priv-key.sh')\n", "prefixes": [ "v2", "03/22" ] }