Patch Detail
Show a patch.
GET /api/1.1/patches/25216/?format=api
{ "id": 25216, "url": "https://patchwork.libcamera.org/api/1.1/patches/25216/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25216/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251127022256.178929-3-bryan.odonoghue@linaro.org>", "date": "2025-11-27T02:22:34", "name": "[v2,02/22] utils: gen-shader-headers: Add a utility to generate headers from shaders", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "811bbd76269ce004477ac93c73282b11dc6c063a", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/1.1/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25216/mbox/", "series": [ { "id": 5616, "url": "https://patchwork.libcamera.org/api/1.1/series/5616/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5616", "date": "2025-11-27T02:22:32", "name": "GPUISP precursor series", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5616/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25216/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25216/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0307FC3260\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 27 Nov 2025 02:23:12 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B3CE860AA3;\n\tThu, 27 Nov 2025 03:23:12 +0100 (CET)", "from mail-wm1-x330.google.com (mail-wm1-x330.google.com\n\t[IPv6:2a00:1450:4864:20::330])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A14DB609E0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 27 Nov 2025 03:23:08 +0100 (CET)", "by mail-wm1-x330.google.com with SMTP id\n\t5b1f17b1804b1-477bf34f5f5so1993785e9.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 26 Nov 2025 18:23:08 -0800 (PST)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4790b0e21e8sm71549495e9.15.2025.11.26.18.23.06\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 26 Nov 2025 18:23:07 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"o6w3dVk8\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1764210188; x=1764814988;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=uyC98X/XHaAyWYIaQyyLtwB29WLvfE+rI98R7oKQJ7g=;\n\tb=o6w3dVk8Y5COPUFcCDWixtS3NUOoJwZQMaRB6MDN42Iky0ZUejdQbR6O3pscJ0yHOm\n\t6fUltxiCX8wEJ7LFH8XBdIfo/IJTYp6D4hhiPhQyAGU+b2UqaJ7oy5VQLJAcJrh5XF2E\n\ti/gun8bbXJ1ajC388x5dk6Q5+BZJuT5oqOTi6V/GOvQs+PtgZxWeXy3PdPQhA6kj4uQ+\n\t6hJ+DktL+5L7Ljk3Nb/jKD7HE/DwI/llKnr/QHDXmAUlbZ8Bwl/odkSUz9xWjZttVF13\n\t0k76uZEOPdXjww4jQg1toZqvMZS7UM7rxWcTNeVVBJgtNvrst0bhPl5HjePTSmCZLQZE\n\t5Scw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1764210188; x=1764814988;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=uyC98X/XHaAyWYIaQyyLtwB29WLvfE+rI98R7oKQJ7g=;\n\tb=IkCJp3jC2swBwDtpqqYq6iKoWbO55V71uSIxHGKkV4XmD1xpkfKQCBfz8Yi6AqK0UT\n\ticUm0qwxELhR2oDQgr1yl/XFJH3hS/XpJr4i9i+rH/7bmDqhqipAZkNVqUroSowjaBtg\n\t2WJgwCqTvIG143Oe/IXScLMpxoy+c5S2Tp1nfUqUa0sYbwJvOR14kJNMy0YGFRsn+s0P\n\t5lwCyJ/aDYqmdoLHwuUMpvdrqzqLDqMdSt1njHRvwspOKibkjDS1fFQvGnLnP6krL3mL\n\tDyEfNawgzajjd2Em3omw47NsT63+aCxC/WK2v3Im2CppXYBgdSXwCvoqB747uBJtT3VV\n\tRsxQ==", "X-Gm-Message-State": "AOJu0YxErqBMUCw7CxmvAKpPcHF3FQuvBAWchD9A96ecpt3KJq/yTU/j\n\tsi6lGNieT+T+L7Xpej6Ymp63qEBBkn5HSw2BsQmXPfgT1slmbz/CMKWWW/QOVHceUQlbmsgncee\n\tdQEPj5HQ=", "X-Gm-Gg": "ASbGncv3ZPT0c3Bqb9xwmlGsyP5L+IDh/dbXAX0f02cMQ3pAmPv/VNs1QxcgueWrqaH\n\thRGmDPH4xxSvBQ7NMEuxD3J4eNuV/FHjmqWLSm+hEglFW1vHFpkZwpnIMdMYMOVmdjuvdtyFbT8\n\tHImNQuoLgQJrAs5k82BbVLXEwn4DlwLJxjryleTn2sdugzs7MSPU8zFQXau1akSKYLReSf5wMJv\n\twJP0/hz/Cpupa8RXWZLy2C2Ju6W8zPzjD2Wdy1jrHTXcjG4faP6a+77DOS6aix4oWHTsTcAJ7QG\n\txxqNhqcp/z+S5NApvNNkDZvwVyJOvheV68NWrXRSH6W2ubpvRYBvb0ZqkrUnhKgCG0VgEWYYVj7\n\twkbBoCu4Bq2ZeKZd2821G45W3peULC7EHz+bVh1xr+PH5dBbMQL8UwVqINGiGWiR1ExlhQoYWoJ\n\tMI+UhdrgONyKT5EQ7qcXBRoht/p41xV0zWejAYmgiWFeNHklLtG3PHWMFrZ37v4zLQCzE=", "X-Google-Smtp-Source": "AGHT+IHTGtwXx09/kvhaqmu1L22ZFwtFr3LbaGgboPRLcTfUTs0flmY04A2zwG3fTs5u30TFeUlFDg==", "X-Received": "by 2002:a05:600c:354c:b0:477:a977:b8c2 with SMTP id\n\t5b1f17b1804b1-47904ae7322mr87633155e9.13.1764210188037; \n\tWed, 26 Nov 2025 18:23:08 -0800 (PST)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "pavel@ucw.cz, Bryan O'Donoghue <bryan.odonoghue@linaro.org>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v2 02/22] utils: gen-shader-headers: Add a utility to\n\tgenerate headers from shaders", "Date": "Thu, 27 Nov 2025 02:22:34 +0000", "Message-ID": "<20251127022256.178929-3-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.51.2", "In-Reply-To": "<20251127022256.178929-1-bryan.odonoghue@linaro.org>", "References": "<20251127022256.178929-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Two simple script to generate a header that contains GLSL shaders translated\nto C arrays.\n\nAcked-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n utils/gen-shader-header.py | 37 +++++++++++++++++++++++++\n utils/gen-shader-headers.sh | 55 +++++++++++++++++++++++++++++++++++++\n 2 files changed, 92 insertions(+)\n create mode 100755 utils/gen-shader-header.py\n create mode 100755 utils/gen-shader-headers.sh", "diff": "diff --git a/utils/gen-shader-header.py b/utils/gen-shader-header.py\nnew file mode 100755\nindex 000000000..731a63b41\n--- /dev/null\n+++ b/utils/gen-shader-header.py\n@@ -0,0 +1,37 @@\n+#!/usr/bin/env python3\n+# SPDX-License-Identifier: GPL-2.0-or-later\n+# Copyright (C) 2025, Bryan O'Donoghue.\n+#\n+# Author: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n+#\n+# A Python script which takes a list of shader files and converts each of them\n+# into a C header.\n+#\n+import sys\n+\n+try:\n+ with open(sys.argv[2]) as file:\n+ data = file.read()\n+ data_len = len(data)\n+\n+ name = sys.argv[1].replace(\".\", \"_\")\n+ name_len = name + \"_len\"\n+\n+ j = 0\n+ print(\"unsigned char\", name, \"[] = {\")\n+ for ch in data:\n+ print(f\"0x{ord(ch):02x}, \", end=\"\")\n+ j = (j + 1) % 16\n+ if j == 0:\n+ print()\n+ if j != 0:\n+ print()\n+ print(\"};\")\n+\n+ print()\n+ print(f\"const unsigned int {name_len}={data_len};\")\n+\n+except FileNotFoundError:\n+ print(f\"File {sys.argv[2]} not found\", file=sys.stderr)\n+except IOError:\n+ print(f\"Unable to read {sys.argv[2]}\", file=sys.stderr)\ndiff --git a/utils/gen-shader-headers.sh b/utils/gen-shader-headers.sh\nnew file mode 100755\nindex 000000000..81bf1584c\n--- /dev/null\n+++ b/utils/gen-shader-headers.sh\n@@ -0,0 +1,55 @@\n+#!/bin/sh\n+\n+set -e\n+\n+usage() {\n+\techo \"Usage: $0 <src_dir> <build_dir> <output_header_name> <shader_file1> [shader_file2 ...]\"\n+\techo\n+\techo \"Generates a C header file containing hex-encoded shader data.\"\n+\techo\n+\techo \"Arguments:\"\n+\techo \" src_dir Path to the base of the source directory\"\n+\techo \" build_dir Directory where shader files are located and header will be written\"\n+\techo \" output_header_name Name of the generated header file (relative to build_dir)\"\n+\techo \" shader_file(s) One or more shader files to embed in the header\"\n+\texit 1\n+}\n+\n+if [ $# -lt 4 ]; then\n+\techo \"Error: Invalid argument count.\"\n+\tusage\n+fi\n+\n+src_dir=\"$1\"; shift\n+build_dir=\"$1\"; shift\n+build_path=$build_dir/\"$1\"; shift\n+\n+cat <<EOF > \"$build_path\"\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/* This file is auto-generated, do not edit! */\n+\n+#pragma once\n+\n+EOF\n+\n+cat <<EOF >> \"$build_path\"\n+/*\n+ * List the names of the shaders at the top of\n+ * header for readability's sake\n+ *\n+EOF\n+\n+for file in \"$@\"; do\n+\tname=$(basename \"$build_dir/$file\" | tr '.' '_')\n+\techo \"[SHADER-GEN] $name\"\n+\techo \" * unsigned char $name;\" >> \"$build_path\"\n+done\n+\n+echo \"*/\" >> \"$build_path\"\n+\n+echo \"/* Hex encoded shader data */\" >> \"$build_path\"\n+for file in \"$@\"; do\n+\tname=$(basename \"$build_dir/$file\")\n+\t\"$src_dir/utils/gen-shader-header.py\" \"$name\" \"$build_dir/$file\" >> \"$build_path\"\n+\techo >> \"$build_path\"\n+done\n", "prefixes": [ "v2", "02/22" ] }