Patch Detail
Show a patch.
GET /api/1.1/patches/25210/?format=api
{ "id": 25210, "url": "https://patchwork.libcamera.org/api/1.1/patches/25210/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25210/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251126-cam-control-override-v2-1-305024a1f190@ideasonboard.com>", "date": "2025-11-26T09:38:51", "name": "[v2,1/3] libcamera: request: Create control list with Camera info map", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "d6d39f0e7bb835bae629d927330237fc4c03b146", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25210/mbox/", "series": [ { "id": 5614, "url": "https://patchwork.libcamera.org/api/1.1/series/5614/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5614", "date": "2025-11-26T09:38:50", "name": "libcamera: ipc: ControlLists without valid idmap break IPC", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5614/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25210/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25210/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F2857C32DE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 26 Nov 2025 09:39:12 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BFE2760AA2;\n\tWed, 26 Nov 2025 10:39:09 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 66DE9609E0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 26 Nov 2025 10:39:06 +0100 (CET)", "from [192.168.0.172] (mob-5-90-63-219.net.vodafone.it\n\t[5.90.63.219])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D3D386DE;\n\tWed, 26 Nov 2025 10:36:56 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"imqtkQT4\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1764149817;\n\tbh=mDBl7Wvas50tmJkad3FT4JCKFaF+rjyT+QZXO++qVDc=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=imqtkQT48inwC/Rc7J5kNUsXEAuRTCj+9p4E9ELw1OHOt5U0mJ4svknYb/+cOhli+\n\tDV3z4deTu75yANMOgQCgxhPxGqJVWx1aI8NwRh2lpbCh+lznHFC6jVAaCSwr1PuoVY\n\toVsLinN69WRNzCkJMxzkEauqIYXasywWrNRN2Cto=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Date": "Wed, 26 Nov 2025 10:38:51 +0100", "Subject": "[PATCH v2 1/3] libcamera: request: Create control list with Camera\n\tinfo map", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20251126-cam-control-override-v2-1-305024a1f190@ideasonboard.com>", "References": "<20251126-cam-control-override-v2-0-305024a1f190@ideasonboard.com>", "In-Reply-To": "<20251126-cam-control-override-v2-0-305024a1f190@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>, \n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "X-Mailer": "b4 0.14.2", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1562;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=mDBl7Wvas50tmJkad3FT4JCKFaF+rjyT+QZXO++qVDc=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBpJsq5/h0OrfdHkCZS/yUyRM0i9tA7mHkGrCH9B\n\tV0Hv22d39SJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaSbKuQAKCRByNAaPFqFW\n\tPJBhEADEa3SE656Rtwv/v1CJkk7pgDhO6FLyWRSF7FbloTjyasiLYmqqN78YkRXCXPBGsv0waHy\n\twhcHUC6C97cZNZ57MX7gJEtf4KBqjQGuQpafHQ9qoaKS4J2GPlU+Dmn7Dd6dtXB+iCcKXiUREKm\n\tJzrPtHkxsGoho8h5XUCHpSoQfwlPfVxp66zssbhQ8gL1RelcqC1Dd3rSNtQoDkKEoC8dZAq3/Nt\n\th8mP339Q/7mwtQQXZ18qSVywzSYTFrZU42qPAs5ylxvjR7rD7rn2Zj/pLuVwBBvk0thuJysX2Nk\n\tgJKjfOGs00h1iDAaRqwHrSCFF3jfXUu5K6ZR4c4HL2khsLC98lRFnm9cLeDZVEHlKu57Jl+bi33\n\tpbNyg0n/OfMKFDPE3ABJh7kYArCfOEULwzCsVbx8vt71yxWDe2UMV/HJJrOTipMI5t+5nw8lnzS\n\tTkQzriyDRVHpGpIwYNVku5athpm+pU1OMu4xdst54nyVf0665wbi9ZRm2QDdHqidFC+Wa4AtBmW\n\tqS4wE73VEkwq9fZtY6Q7aYRLXSJ5cCifMQVCI3/yll6gjgTYpeR2CSlUBuDOIjeqdXdKKhC8YkJ\n\tElpyVLmW4NoPQL2+CbQ1qFFkQ6Z7nVticIoSbszM2JoxQjdz6qHEAxlyYS9mwgzmiU4BfShw1iA\n\tX6+oknc9LWPNbzw==", "X-Developer-Key": "i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The control lists associated with a Request is created with the global\nlibcamera::controls::controls id map.\n\nThis is fine as the idmap/info map used to contruct a ControlList are not\nused for any control validation purposes by the libcamera code.\n\nHowever creating a ControlList with the camera ControlInfoMap has two\nadvantages:\n\n1) The idmap can be extracted from the info map, but not the other way\n around\n2) The control list is constructed with a valid map of info to the\n controls it can actually supports, instead of the global map of\n libcamera controls\n\nInitialize the ControlList part of a Request with the Camera control\ninfo map, as the association between a Request and a Camera is permanent\nand valid for the whole lifetime of a Request.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/request.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex 60565f5984971c7ab34e119a15b8141799f71071..2544a059f6984d930ec909c74e0b621c9fe82726 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -356,7 +356,7 @@ Request::Request(Camera *camera, uint64_t cookie)\n \t: Extensible(std::make_unique<Private>(camera)),\n \t cookie_(cookie), status_(RequestPending)\n {\n-\tcontrols_ = new ControlList(controls::controls,\n+\tcontrols_ = new ControlList(camera->controls(),\n \t\t\t\t camera->_d()->validator());\n \n \t/**\n", "prefixes": [ "v2", "1/3" ] }