Patch Detail
Show a patch.
GET /api/1.1/patches/25206/?format=api
{ "id": 25206, "url": "https://patchwork.libcamera.org/api/1.1/patches/25206/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25206/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251125162851.2301793-28-stefan.klug@ideasonboard.com>", "date": "2025-11-25T16:28:39", "name": "[v3,27/29] pipeline: rkisp1: Add warning to unclear format handling", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "81fd76df65bb3386dd7f3e3fd8c37ec7d110142d", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25206/mbox/", "series": [ { "id": 5613, "url": "https://patchwork.libcamera.org/api/1.1/series/5613/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5613", "date": "2025-11-25T16:28:12", "name": "Full dewarper support on imx8mp", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5613/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25206/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25206/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 429DEC3338\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 25 Nov 2025 16:30:16 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EC44860AD0;\n\tTue, 25 Nov 2025 17:30:15 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5119560A9E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 25 Nov 2025 17:30:15 +0100 (CET)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:bae1:340c:573c:570b])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 58C6F20E6; \n\tTue, 25 Nov 2025 17:28:06 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gHnYVq42\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1764088086;\n\tbh=bhI7RQpAaebY6zxQIfze+sNd3cGZao08ONXsHIuzw0A=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=gHnYVq42Rzz3qDbn87KppTXOq+G7jgtKZng6jl/atIGUXAe4Ca315+uRsBB63+eUv\n\tOWcnvGCDXGKXIg4ic4i9IGGM8E/GMlbRys7eKM5oij2+QltPcr3Ad6EkTOCLjLF+qN\n\tBCG2BUPo+sF5wa8dTx/cSjzQJKdXJTKhNV+mZJ0Q=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH v3 27/29] pipeline: rkisp1: Add warning to unclear format\n\thandling", "Date": "Tue, 25 Nov 2025 17:28:39 +0100", "Message-ID": "<20251125162851.2301793-28-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20251125162851.2301793-1-stefan.klug@ideasonboard.com>", "References": "<20251125162851.2301793-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "It is not mentioned when the sensorFormat is allowed to have zero size.\nAdd a warning and todo to that case but leave it in place for now.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 10 +++++++++-\n 1 file changed, 9 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex adce1de35263..dc7df22976ff 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -766,8 +766,16 @@ CameraConfiguration::Status RkISP1CameraConfiguration::validate()\n \tsensorFormat_ = sensor->getFormat(mbusCodes, accumulatedSensorSize,\n \t\t\t\t\t mainPath->maxResolution());\n \n-\tif (sensorFormat_.size.isNull())\n+\tif (sensorFormat_.size.isNull()) {\n+\t\t/*\n+\t\t * \\todo When can this happen? Should we return a failure in\n+\t\t * this case?\n+\t\t */\n \t\tsensorFormat_.size = sensor->resolution();\n+\t\tLOG(RkISP1, Warning)\n+\t\t\t<< \"Failed to select sensor format. Default to \"\n+\t\t\t<< sensorFormat_;\n+\t}\n \n \treturn status;\n }\n", "prefixes": [ "v3", "27/29" ] }