Patch Detail
Show a patch.
GET /api/1.1/patches/25205/?format=api
{ "id": 25205, "url": "https://patchwork.libcamera.org/api/1.1/patches/25205/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25205/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251125162851.2301793-27-stefan.klug@ideasonboard.com>", "date": "2025-11-25T16:28:38", "name": "[v3,26/29] libcamera: Add and implement LensDewarpEnable control", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ab757ecca858c6ca0dae9b750b2fee4ffe887982", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25205/mbox/", "series": [ { "id": 5613, "url": "https://patchwork.libcamera.org/api/1.1/series/5613/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5613", "date": "2025-11-25T16:28:12", "name": "Full dewarper support on imx8mp", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5613/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25205/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25205/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7811AC3338\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 25 Nov 2025 16:30:13 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 218C360B30;\n\tTue, 25 Nov 2025 17:30:13 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DA3B260AD0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 25 Nov 2025 17:30:11 +0100 (CET)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:bae1:340c:573c:570b])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id E933D6AF;\n\tTue, 25 Nov 2025 17:28:02 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DojNeDAJ\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1764088083;\n\tbh=Ph1nfg8mvjVX1JdKj+tQ/BpziA69Zqy+s4I6Wt+ey6U=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=DojNeDAJ7fnZAIRM3l/nGX+DisYSbW8VR+WIBu7jPd0zHC9jTIjtWOxxWPtE1dnOI\n\tL/76HLvu52j79+vOyWoFQC5SqoZG3Gin6zuHXkzYYeKwk19CaVk+VFvN8PrMxkgMLr\n\tq8ZVr4qN5T4BAiBgn37Rfzqzsa8So5k7SFZjUEMI=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>,\n\tPaul Elder <paul.elder@ideasonboard.com>", "Subject": "[PATCH v3 26/29] libcamera: Add and implement LensDewarpEnable\n\tcontrol", "Date": "Tue, 25 Nov 2025 17:28:38 +0100", "Message-ID": "<20251125162851.2301793-27-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20251125162851.2301793-1-stefan.klug@ideasonboard.com>", "References": "<20251125162851.2301793-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a LensDewarpEnable control to enable or disable lens dewarping if it\nis configured. Implement it inside the dw100 converter module.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\n\nChanges in v3:\n- Moved control handling into converter module\n- Moved yaml handling into converter module\n- Collected tag\n\nChanges in v2:\n- Merged control definition and usage into one patch\n- Improved control description\n- Fixed actual handling of LensDewarpEnable control that got lost in a\n previous rebase\n---\n src/libcamera/control_ids_core.yaml | 7 +++++++\n src/libcamera/converter/converter_dw100.cpp | 12 ++++++++++++\n 2 files changed, 19 insertions(+)", "diff": "diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\nindex f781865859ac..3bcb475fd102 100644\n--- a/src/libcamera/control_ids_core.yaml\n+++ b/src/libcamera/control_ids_core.yaml\n@@ -1346,4 +1346,11 @@ controls:\n reduces the WdrExposureValue until the amount of pixels that are close\n to saturation is lower than this value.\n \n+ - LensDewarpEnable:\n+ type: bool\n+ direction: inout\n+ description: |\n+ Enable or disable lens dewarping. This control is only available if lens\n+ dewarp parameters are configured in the tuning file.\n+\n ...\ndiff --git a/src/libcamera/converter/converter_dw100.cpp b/src/libcamera/converter/converter_dw100.cpp\nindex 03ffd939dc63..7adad1b502f0 100644\n--- a/src/libcamera/converter/converter_dw100.cpp\n+++ b/src/libcamera/converter/converter_dw100.cpp\n@@ -343,6 +343,9 @@ void ConverterDW100Module::updateControlInfos(const Stream *stream, ControlInfoM\n \tcontrols[&controls::ScalerCrop] = ControlInfo(Rectangle(sensorCrop_.x, sensorCrop_.y, 1, 1),\n \t\t\t\t\t\t sensorCrop_, sensorCrop_);\n \n+\tif (dewarpParams_.has_value())\n+\t\tcontrols[&controls::LensDewarpEnable] = ControlInfo(false, true, true);\n+\n \tif (!converter_.supportsRequests())\n \t\tLOG(Converter, Warning)\n \t\t\t<< \"dw100 kernel driver has no requests support.\"\n@@ -366,6 +369,12 @@ void ConverterDW100Module::setControls(const Stream *stream, const ControlList &\n \tauto &info = vertexMaps_[stream];\n \tauto &vertexMap = info.map;\n \n+\tconst auto &lensDewarpEnable = controls.get(controls::LensDewarpEnable);\n+\tif (lensDewarpEnable) {\n+\t\tvertexMap.setLensDewarpEnable(*lensDewarpEnable);\n+\t\tinfo.update = true;\n+\t}\n+\n \tconst auto &crop = controls.get(controls::ScalerCrop);\n \tif (crop) {\n \t\tvertexMap.setScalerCrop(*crop);\n@@ -394,6 +403,9 @@ void ConverterDW100Module::populateMetadata(const Stream *stream, ControlList &m\n \tauto &vertexMap = vertexMaps_[stream].map;\n \n \tmeta.set(controls::ScalerCrop, vertexMap.effectiveScalerCrop());\n+\n+\tif (dewarpParams_.has_value())\n+\t\tmeta.set(controls::LensDewarpEnable, vertexMap.lensDewarpEnable());\n }\n \n /**\n", "prefixes": [ "v3", "26/29" ] }