Patch Detail
Show a patch.
GET /api/1.1/patches/25189/?format=api
{ "id": 25189, "url": "https://patchwork.libcamera.org/api/1.1/patches/25189/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25189/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251125162851.2301793-11-stefan.klug@ideasonboard.com>", "date": "2025-11-25T16:28:22", "name": "[v3,10/29] libcamera: converter_v4l2_m2m: Add debug logging for formats", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "73e187ff83386d147ee1e5832e386a52db4f5a19", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25189/mbox/", "series": [ { "id": 5613, "url": "https://patchwork.libcamera.org/api/1.1/series/5613/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5613", "date": "2025-11-25T16:28:12", "name": "Full dewarper support on imx8mp", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5613/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25189/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25189/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B87A1C333C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 25 Nov 2025 16:29:25 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6863260AA9;\n\tTue, 25 Nov 2025 17:29:25 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3485660A86\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 25 Nov 2025 17:29:24 +0100 (CET)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:bae1:340c:573c:570b])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 3DCA22106; \n\tTue, 25 Nov 2025 17:27:15 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HpMmBx7q\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1764088035;\n\tbh=3a1hYayUKIPR784V6RG9gGQmR5U4Pd2Ul/cvHZ6nPuM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=HpMmBx7qX2pFqLKyTsfgCvi8YAKvQiR+6Lv6SaO9+bRkFn/GC1KSL5KxkBmtk2VNt\n\tEg8UQalzPC3CT9jeao0GyChXAXG1S9GWrOTf0t0muExDItsysEeeDTRWwI77wZye8P\n\t2wI70RX91+V5zXHcPaLM+XXidSg1FMkKfkKBzPEY=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>, Kieran Bingham\n\t<kieran.bingham@ideasonboard.com>, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t<barnabas.pocze@ideasonboard.com>, Paul Elder\n\t<paul.elder@ideasonboard.com>", "Subject": "[PATCH v3 10/29] libcamera: converter_v4l2_m2m: Add debug logging\n\tfor formats", "Date": "Tue, 25 Nov 2025 17:28:22 +0100", "Message-ID": "<20251125162851.2301793-11-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.51.0", "In-Reply-To": "<20251125162851.2301793-1-stefan.klug@ideasonboard.com>", "References": "<20251125162851.2301793-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Getting the requested input/output format is crucial for debugging. Add\nlog statements for that.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\n\nChanges in v3:\n- Collected tags\n\nChanges in v2:\n- Collected tag\n---\n src/libcamera/converter/converter_v4l2_m2m.cpp | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp\nindex 48e49f143cf1..37377ab24952 100644\n--- a/src/libcamera/converter/converter_v4l2_m2m.cpp\n+++ b/src/libcamera/converter/converter_v4l2_m2m.cpp\n@@ -111,6 +111,7 @@ int V4L2M2MConverter::V4L2M2MStream::configure(const StreamConfiguration &inputC\n \tformat.planesCount = 1;\n \tformat.planes[0].bpl = inputCfg.stride;\n \n+\tLOG(Converter, Debug) << \"Set input format to: \" << format;\n \tint ret = m2m_->output()->setFormat(&format);\n \tif (ret < 0) {\n \t\tLOG(Converter, Error)\n@@ -133,6 +134,7 @@ int V4L2M2MConverter::V4L2M2MStream::configure(const StreamConfiguration &inputC\n \tformat.fourcc = videoFormat;\n \tformat.size = outputCfg.size;\n \n+\tLOG(Converter, Debug) << \"Set output format to: \" << format;\n \tret = m2m_->capture()->setFormat(&format);\n \tif (ret < 0) {\n \t\tLOG(Converter, Error)\n", "prefixes": [ "v3", "10/29" ] }