Patch Detail
Show a patch.
GET /api/1.1/patches/25161/?format=api
{ "id": 25161, "url": "https://patchwork.libcamera.org/api/1.1/patches/25161/?format=api", "web_url": "https://patchwork.libcamera.org/patch/25161/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251124-cam-control-override-v1-2-dfc3a2f3feee@ideasonboard.com>", "date": "2025-11-24T16:43:45", "name": "[RFC,2/2] libcamera: request: Create control list with Camera info map", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "d6d39f0e7bb835bae629d927330237fc4c03b146", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/25161/mbox/", "series": [ { "id": 5609, "url": "https://patchwork.libcamera.org/api/1.1/series/5609/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5609", "date": "2025-11-24T16:43:43", "name": "libcamera: ipc: ControlLists without valid idmap break IPC", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5609/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/25161/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/25161/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4C992C32E0\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 24 Nov 2025 16:44:09 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6EFAA60AA0;\n\tMon, 24 Nov 2025 17:44:08 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4EF0B6096B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 24 Nov 2025 17:44:03 +0100 (CET)", "from [192.168.0.172] (mob-5-90-137-64.net.vodafone.it\n\t[5.90.137.64])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F183A741;\n\tMon, 24 Nov 2025 17:41:54 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KJWryPhV\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1764002515;\n\tbh=8eacksoLZfbdsblQSHnU5IxlIkspfQtVL1lxhb/8/s8=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=KJWryPhVsbonqLFW2ZwC8ec15i/iJ3x1nuKL9NSJa7oYfKRoWyzVlH6VWsRBuHZ6W\n\tg/Ya1xO37ni9tmuI1iqod769tqPpTOMRPVqmoXb1GyCYh7ZPcI+FAOORI3ASupYkAw\n\t9nRHjFw/oykw9/olMVyWsc1vvSLjj6X6KfKQWhYU=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Date": "Mon, 24 Nov 2025 17:43:45 +0100", "Subject": "[PATCH RFC 2/2] libcamera: request: Create control list with\n\tCamera info map", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20251124-cam-control-override-v1-2-dfc3a2f3feee@ideasonboard.com>", "References": "<20251124-cam-control-override-v1-0-dfc3a2f3feee@ideasonboard.com>", "In-Reply-To": "<20251124-cam-control-override-v1-0-dfc3a2f3feee@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "X-Mailer": "b4 0.14.2", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1499;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=8eacksoLZfbdsblQSHnU5IxlIkspfQtVL1lxhb/8/s8=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBpJItRUKDJdtSgp+tfg5gIntrUOVmSTk8MbyScy\n\tLdstmj5CkSJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaSSLUQAKCRByNAaPFqFW\n\tPMJKEACFSBkXZBZKAINd3Oy11PfStF/jswKUhqm/UHeaIBunohS65azeghvmddUxj7nttZffE6o\n\tfjJKn6tPJdLsp2x5bC2YZsqvT6QbmakoOvY1NawgOI/ankJuhlHxRfXAfvKV8Ic4QraJ3b0RxS9\n\tc9Ycy6ZAa+utEiX9oOc9tVvR8pwfg1tpWCnm8TceEjpgsRi/3ZUZFLqgEqwa/jOAjGFxiX4y46d\n\trW8wkX8GluRDjHcT7hSz3Ts/TXvcSEsurKTX6y/ZsgALK8ZNRRMZwKSekX3GFJfxDtTerpuJHsL\n\tpenoUcpZTI9bUF/PNQ4D3USjlNQ82uufHxwW8TjbeeOHetXIRDM+FCmrLfrf3fdJabu0P1R1ot6\n\t/HtAT0nyDxUy5PaFBJ9sFU1zeCxZgAhhLUJfBj2kbIKbhaGm27WQmh/MQLiB7HNLCo88rScePts\n\tvlLul1thVUlamr4LhAdZWlT7B8H1OnHWmIHx2liSgHrLLr28aAVVI+XSszPD5MIQfZnj/TqTh5e\n\t6zlQWT4Tbq2Eq75SuOBDxRRdksirzSzBR16K8vx7kJ5PsEId9tI9vgvmAz+igiwnVOsqa8uZ/jZ\n\tKEmSyWLPpwcRtZtdzqNvjYPpqKlAXTC0mTm2vErFzFd4bnPJaVWI4Wi0nhAQfJHJhB/hwxTAG1U\n\tchnd1s2eye6nTNw==", "X-Developer-Key": "i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The control lists associated with a Request is created with the global\nlibcamera::controls::controls id map.\n\nThis is fine as the idmap/info map used to contruct a ControlList are not\nused for any control validation purposes by the libcamera code.\n\nHowever creating a ControlList with the camera ControlInfoMap has two\nadvantages:\n\n1) The idmap can be extracted from the info map, but not the other way\n around\n2) The control list is constructed with a valid map of info to the\n controls it can actually supports, instead of the global map of\n libcamera controls\n\nInitialize the ControlList part of a Request with the Camera control\ninfo map, as the association between a Request and a Camera is permanent\nand valid for the whole lifetime of a Request.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/libcamera/request.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex 60565f5984971c7ab34e119a15b8141799f71071..2544a059f6984d930ec909c74e0b621c9fe82726 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -356,7 +356,7 @@ Request::Request(Camera *camera, uint64_t cookie)\n \t: Extensible(std::make_unique<Private>(camera)),\n \t cookie_(cookie), status_(RequestPending)\n {\n-\tcontrols_ = new ControlList(controls::controls,\n+\tcontrols_ = new ControlList(camera->controls(),\n \t\t\t\t camera->_d()->validator());\n \n \t/**\n", "prefixes": [ "RFC", "2/2" ] }